From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 04/16] of: changesets: Introduce changeset helper methods Date: Wed, 21 Feb 2018 14:19:02 +0200 Message-ID: <2176862.3cxL0kyTvc@avalon> References: <20180220231046.32638-1-laurent.pinchart+renesas@ideasonboard.com> <20180220231046.32638-5-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Geert Uytterhoeven Cc: Marek Vasut , Laurent Pinchart , Wolfram Sang , Koen Kooi , Pantelis Antoniou , Linux Kernel Mailing List , DRI Development , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux I2C , Matt Porter , Frank Rowand , Guenter Roeck List-Id: linux-i2c@vger.kernel.org SGkgR2VlcnQsCgpPbiBXZWRuZXNkYXksIDIxIEZlYnJ1YXJ5IDIwMTggMTI6MjE6NTAgRUVUIEdl ZXJ0IFV5dHRlcmhvZXZlbiB3cm90ZToKPiBPbiBXZWQsIEZlYiAyMSwgMjAxOCBhdCAxMjoxMCBB TSwgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+IEZyb206IFBhbnRlbGlzIEFudG9uaW91IDxw YW50ZWxpcy5hbnRvbmlvdUBrb25zdWxrby5jb20+Cj4gPiAKPiA+IENoYW5nZXNldHMgYXJlIHZl cnkgcG93ZXJmdWwsIGJ1dCB0aGUgbGFjayBvZiBhIGhlbHBlciBBUEkKPiA+IG1ha2VzIHVzaW5n IHRoZW0gY3VtYmVyc29tZS4gSW50cm9kdWNlIGEgc2ltcGxlIGNvcHkgYmFzZWQKPiA+IEFQSSB0 aGF0IG1ha2VzIHRoaW5ncyBjb25zaWRlcmFibHkgZWFzaWVyLgo+ID4gCj4gPiBUbyB3aXQsIGFk ZGluZyBhIHByb3BlcnR5IHVzaW5nIHRoZSByYXcgQVBJLgo+ID4gCj4gPiAgICAgICAgIHN0cnVj dCBwcm9wZXJ0eSAqcHJvcDsKPiA+ICAgICAgICAgcHJvcCA9IGt6YWxsb2Moc2l6ZW9mKCpwcm9w KSksIEdGUF9LRVJORUwpOwo+ID4gICAgICAgICBwcm9wLT5uYW1lID0ga3N0cmR1cCgiY29tcGF0 aWJsZSIpOwo+ID4gICAgICAgICBwcm9wLT52YWx1ZSA9IGtzdHJkdXAoImZvbyxiYXIiKTsKPiA+ ICAgICAgICAgcHJvcC0+bGVuZ3RoID0gc3RybGVuKHByb3AtPnZhbHVlKSArIDE7Cj4gPiAgICAg ICAgIG9mX2NoYW5nZXNldF9hZGRfcHJvcGVydHkob2NzLCBucCwgcHJvcCk7Cj4gPiAKPiA+IHdo aWxlIHVzaW5nIHRoZSBoZWxwZXIgQVBJCj4gPiAKPiA+ICAgICAgICAgb2ZfY2hhbmdlc2V0X2Fk ZF9wcm9wZXJ0eV9zdHJpbmcob2NzLCBucCwgImNvbXBhdGlibGUiLAo+ID4gICAgICAgICAKPiA+ ICAgICAgICAgICAgICAgICAgICAgICAgICJmb28sYmFyIik7Cj4gPiAKPiA+IFNpZ25lZC1vZmYt Ynk6IFBhbnRlbGlzIEFudG9uaW91IDxwYW50ZWxpcy5hbnRvbmlvdUBrb25zdWxrby5jb20+Cj4g PiBbRml4ZWQgbWVtb3J5IGxlYWsgaW4gX19vZl9jaGFuZ2VzZXRfYWRkX3VwZGF0ZV9wcm9wZXJ0 eV9jb3B5KCldCj4gPiBTaWduZWQtb2ZmLWJ5OiBMYXVyZW50IFBpbmNoYXJ0Cj4gPiA8bGF1cmVu dC5waW5jaGFydCtyZW5lc2FzQGlkZWFzb25ib2FyZC5jb20+Cj4gCj4gWW91IG1pc3NlZCBvbmUg Zml4IEkgaGF2ZSBpbiBteSB0b3BpYy9vdmVybGF5cyBicmFuY2gKPiBodHRwczovL2dpdC5rZXJu ZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9nZWVydC9yZW5lc2FzLWRyaXZlcnMuZ2l0 L2NvCj4gbW1pdC8/aD10b3BpYy9vdmVybGF5cyZpZD0xNTBmOTViOWRlYzc3Y2UzNzFjMjI5Zjdh YzRkNmRkODYyMGJlZjRhCj4gPiAtLS0gYS9pbmNsdWRlL2xpbnV4L29mLmgKPiA+ICsrKyBiL2lu Y2x1ZGUvbGludXgvb2YuaAo+ID4gCj4gPiArLyoqCj4gPiArICogb2ZfY2hhbmdlc2V0X2FkZF9w cm9wZXJ0eV91MzIgLSBDcmVhdGUgYSBuZXcgdTMyIHByb3BlcnR5Cj4gPiArICoKPiA+ICsgKiBA b2NzOiAgICAgICBjaGFuZ2VzZXQgcG9pbnRlcgo+ID4gKyAqIEBucDogICAgICAgICAgICAgICAg ZGV2aWNlIG5vZGUgcG9pbnRlcgo+ID4gKyAqIEBuYW1lOiAgICAgIG5hbWUgb2YgdGhlIHByb3Bl cnR5Cj4gPiArICogQHZhbDogICAgICAgdmFsdWUgaW4gaG9zdCBlbmRpYW4gZm9ybWF0Cj4gPiAr ICoKPiA+ICsgKiBBZGRzIGEgdTMyIHByb3BlcnR5IHRvIHRoZSBjaGFuZ2VzZXQuCj4gPiArICoK PiA+ICsgKiBSZXR1cm5zIHplcm8gb24gc3VjY2VzcywgYSBuZWdhdGl2ZSBlcnJvciB2YWx1ZSBv dGhlcndpc2UuCj4gPiArICovCj4gPiArc3RhdGljIGlubGluZSBpbnQgb2ZfY2hhbmdlc2V0X2Fk ZF9wcm9wZXJ0eV91MzIoc3RydWN0IG9mX2NoYW5nZXNldCAqb2NzLAo+ID4gKyAgICAgICAgICAg ICAgIHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnAsIGNvbnN0IGNoYXIgKm5hbWUsIHUzMiB2YWwpCj4g PiArewo+ID4gKyAgICAgICB2YWwgPSBjcHVfdG9fYmUzMih2YWwpOwo+IAo+IFlvdSBtdXN0IHVz ZSBhbiBpbnRlcm1lZGlhdGUsIHRvIGF2b2lkIGNvbXBsYWludHMgZnJvbSBzcGFyc2U6Cj4gCj4g ICAgIF9fYmUzMiB4ID0gY3B1X3RvX2JlMzIodmFsKTsKPiAKPiA+ICsgICAgICAgcmV0dXJuIF9f b2ZfY2hhbmdlc2V0X2FkZF91cGRhdGVfcHJvcGVydHlfY29weShvY3MsIG5wLCBuYW1lLAo+ID4g JnZhbCwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIHNpemVvZih2YWwpLCBmYWxzZSk7Cj4g Cj4gcy92YWwveC8KCkknbGwgZml4IGJvdGggaW4gdGhlIG5leHQgdmVyc2lvbiwgdGhhbmtzLgoK PiA+ICt9Cj4gPiArCj4gPiArLyoqCj4gPiArICogb2ZfY2hhbmdlc2V0X3VwZGF0ZV9wcm9wZXJ0 eV91MzIgLSBVcGRhdGUgdTMyIHByb3BlcnR5Cj4gPiArICoKPiA+ICsgKiBAb2NzOiAgICAgICBj aGFuZ2VzZXQgcG9pbnRlcgo+ID4gKyAqIEBucDogICAgICAgICAgICAgICAgZGV2aWNlIG5vZGUg cG9pbnRlcgo+ID4gKyAqIEBuYW1lOiAgICAgIG5hbWUgb2YgdGhlIHByb3BlcnR5Cj4gPiArICog QHZhbDogICAgICAgdmFsdWUgaW4gaG9zdCBlbmRpYW4gZm9ybWF0Cj4gPiArICoKPiA+ICsgKiBV cGRhdGVzIGEgdTMyIHByb3BlcnR5IHRvIHRoZSBjaGFuZ2VzZXQuCj4gPiArICoKPiA+ICsgKiBS ZXR1cm5zIHplcm8gb24gc3VjY2VzcywgYSBuZWdhdGl2ZSBlcnJvciB2YWx1ZSBvdGhlcndpc2Uu Cj4gPiArICovCj4gPiArc3RhdGljIGlubGluZSBpbnQgb2ZfY2hhbmdlc2V0X3VwZGF0ZV9wcm9w ZXJ0eV91MzIoCj4gPiArICAgICAgIHN0cnVjdCBvZl9jaGFuZ2VzZXQgKm9jcywgc3RydWN0IGRl dmljZV9ub2RlICpucCwKPiA+ICsgICAgICAgY29uc3QgY2hhciAqbmFtZSwgdTMyIHZhbCkKPiA+ ICt7Cj4gPiArICAgICAgIHZhbCA9IGNwdV90b19iZTMyKHZhbCk7Cj4gCj4gT2gsIGEgbmV3IG9u ZS4KPiAKPiA+ICsgICAgICAgcmV0dXJuIF9fb2ZfY2hhbmdlc2V0X2FkZF91cGRhdGVfcHJvcGVy dHlfY29weShvY3MsIG5wLCBuYW1lLAo+ID4gJnZhbCwKPiA+ICsgICAgICAgICAgICAgICAgICAg ICAgIHNpemVvZih2YWwpLCB0cnVlKTsKPiA+ICt9CgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGlu Y2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:47290 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751639AbeBUMSV (ORCPT ); Wed, 21 Feb 2018 07:18:21 -0500 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Laurent Pinchart , DRI Development , Linux-Renesas , Pantelis Antoniou , Rob Herring , Frank Rowand , Matt Porter , Koen Kooi , Guenter Roeck , Marek Vasut , Wolfram Sang , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux I2C Subject: Re: [PATCH v4 04/16] of: changesets: Introduce changeset helper methods Date: Wed, 21 Feb 2018 14:19:02 +0200 Message-ID: <2176862.3cxL0kyTvc@avalon> In-Reply-To: References: <20180220231046.32638-1-laurent.pinchart+renesas@ideasonboard.com> <20180220231046.32638-5-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Geert, On Wednesday, 21 February 2018 12:21:50 EET Geert Uytterhoeven wrote: > On Wed, Feb 21, 2018 at 12:10 AM, Laurent Pinchart wrote: > > From: Pantelis Antoniou > > > > Changesets are very powerful, but the lack of a helper API > > makes using them cumbersome. Introduce a simple copy based > > API that makes things considerably easier. > > > > To wit, adding a property using the raw API. > > > > struct property *prop; > > prop = kzalloc(sizeof(*prop)), GFP_KERNEL); > > prop->name = kstrdup("compatible"); > > prop->value = kstrdup("foo,bar"); > > prop->length = strlen(prop->value) + 1; > > of_changeset_add_property(ocs, np, prop); > > > > while using the helper API > > > > of_changeset_add_property_string(ocs, np, "compatible", > > > > "foo,bar"); > > > > Signed-off-by: Pantelis Antoniou > > [Fixed memory leak in __of_changeset_add_update_property_copy()] > > Signed-off-by: Laurent Pinchart > > > > You missed one fix I have in my topic/overlays branch > https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/co > mmit/?h=topic/overlays&id=150f95b9dec77ce371c229f7ac4d6dd8620bef4a > > --- a/include/linux/of.h > > +++ b/include/linux/of.h > > > > +/** > > + * of_changeset_add_property_u32 - Create a new u32 property > > + * > > + * @ocs: changeset pointer > > + * @np: device node pointer > > + * @name: name of the property > > + * @val: value in host endian format > > + * > > + * Adds a u32 property to the changeset. > > + * > > + * Returns zero on success, a negative error value otherwise. > > + */ > > +static inline int of_changeset_add_property_u32(struct of_changeset *ocs, > > + struct device_node *np, const char *name, u32 val) > > +{ > > + val = cpu_to_be32(val); > > You must use an intermediate, to avoid complaints from sparse: > > __be32 x = cpu_to_be32(val); > > > + return __of_changeset_add_update_property_copy(ocs, np, name, > > &val, > > + sizeof(val), false); > > s/val/x/ I'll fix both in the next version, thanks. > > +} > > + > > +/** > > + * of_changeset_update_property_u32 - Update u32 property > > + * > > + * @ocs: changeset pointer > > + * @np: device node pointer > > + * @name: name of the property > > + * @val: value in host endian format > > + * > > + * Updates a u32 property to the changeset. > > + * > > + * Returns zero on success, a negative error value otherwise. > > + */ > > +static inline int of_changeset_update_property_u32( > > + struct of_changeset *ocs, struct device_node *np, > > + const char *name, u32 val) > > +{ > > + val = cpu_to_be32(val); > > Oh, a new one. > > > + return __of_changeset_add_update_property_copy(ocs, np, name, > > &val, > > + sizeof(val), true); > > +} -- Regards, Laurent Pinchart