From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] net/enic: fix Tx and Rx queue stop and start Date: Fri, 15 Jul 2016 23:30:53 +0200 Message-ID: <2178957.VeIBf3gLIC@xps13> References: <1468351487-12002-1-git-send-email-johndale@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, bruce.richardson@intel.com To: John Daley Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 95E5F5587 for ; Fri, 15 Jul 2016 23:30:55 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id o80so45707699wme.1 for ; Fri, 15 Jul 2016 14:30:55 -0700 (PDT) In-Reply-To: <1468351487-12002-1-git-send-email-johndale@cisco.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-07-12 12:24, John Daley: > The exported device start and stop functions where not setting the queue > states to RTE_ETH_QUEUE_STATE_STARTED and RTE_ETH_QUEUE_STATE_STOPPED. > After starting the device, the RTE queue stop function would not call > the enic queue stop function since queue was already marked as stopped. > > Put queue state updates in the lower level queue start/stop functions > which are called by both device and queue start/stop functions. > > Fixes: fefed3d1e62c ("enic: new driver") > > Reviewed-by: Nelson Escobar > Signed-off-by: John Daley Applied, thanks