From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v12 1/3] mempool: support external mempool
	operations
Date: Wed, 15 Jun 2016 13:38:17 +0200
Message-ID: <2179753.hqDAO2p8Ql@xps13>
References: <1465919341-3209-1-git-send-email-david.hunt@intel.com>
 <20160615121444.3db1d573@pcviktorin.fit.vutbr.cz>
 <57612E1F.4040607@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Jan Viktorin <viktorin@rehivetech.com>,
 olivier.matz@6wind.com, jerin.jacob@caviumnetworks.com, shreyansh.jain@nxp.com
To: "Hunt, David" <david.hunt@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id 351F8C5A2
 for <dev@dpdk.org>; Wed, 15 Jun 2016 13:38:20 +0200 (CEST)
Received: by mail-wm0-f50.google.com with SMTP id f126so17772373wma.1
 for <dev@dpdk.org>; Wed, 15 Jun 2016 04:38:20 -0700 (PDT)
In-Reply-To: <57612E1F.4040607@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-06-15 11:29, Hunt, David:
> 
> On 15/6/2016 11:14 AM, Jan Viktorin wrote:
> > On Wed, 15 Jun 2016 08:47:02 +0100
> > David Hunt <david.hunt@intel.com> wrote:
> >
> 
> [...]
> 
> >
> >> +
> >> +/** Array of registered ops structs. */
> >> +extern struct rte_mempool_ops_table rte_mempool_ops_table;
> >> +
> >> +/**
> >> + * @internal Get the mempool ops struct from its index.
> >> + *
> >> + * @param ops_index
> >> + *   The index of the ops struct in the ops struct table. It must be a valid
> >> + *   index: (0 <= idx < num_ops).
> >> + * @return
> >> + *   The pointer to the ops struct in the table.
> >> + */
> >> +static inline struct rte_mempool_ops *
> >> +rte_mempool_ops_get(int ops_index)
> > Shouldn't this function be called rte_mempool_get/find_ops instead?
> 
> Jan,
> 
>     I think at this stage that it's probably OK as it is.  :)

?
What is the justification?