From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Igor Ryzhov <iryzhov@nfware.com>
Cc: dev@dpdk.org, maryam.tahhan@intel.com, olivier.matz@6wind.com
Subject: Re: [PATCH] ethdev: don't count missed packets in erroneous packets counter
Date: Thu, 17 Mar 2016 17:40:35 +0100 [thread overview]
Message-ID: <2180400.M1OUCR6DC3@xps13> (raw)
In-Reply-To: <1457615010-87436-1-git-send-email-iryzhov@nfware.com>
CC Maryam and Olivier who had discussions about imissed and other stats:
http://dpdk.org/ml/archives/dev/2015-August/022905.html
http://dpdk.org/ml/archives/dev/2015-September/023351.html
http://dpdk.org/ml/archives/dev/2015-September/023612.html
2016-03-10 16:03, Igor Ryzhov:
> Comment for "ierrors" counter says that it counts erroneous received packets. But for some reason "imissed" counter is added to "ierrors" counter in most drivers. It is a mistake, because missed packets are obviously not received. This patch fixes it.
According to this patch
http://dpdk.org/browse/dpdk/commit/?id=70bdb186
imissed was kept in ierrors because of backward compatibility.
I'm OK to remove imissed from ierrors.
Fixes: 70bdb18657da ("ethdev: add Rx error counters for missed, badcrc and badlen packets")
Fixes: 6bfe648406b5 ("i40e: add Rx error statistics")
Fixes: 856505d303f4 ("cxgbe: add port statistics")
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
next prev parent reply other threads:[~2016-03-17 16:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 13:03 [PATCH] ethdev: don't count missed packets in erroneous packets counter Igor Ryzhov
2016-03-14 7:30 ` Igor Ryzhov
2016-03-14 8:26 ` Lu, Wenzhuo
2016-03-17 12:02 ` Rahul Lakkireddy
2016-03-17 16:40 ` Thomas Monjalon [this message]
2016-03-22 10:06 ` Thomas Monjalon
2016-03-22 15:23 ` Tahhan, Maryam
2016-03-22 15:57 ` [PATCH] doc: notify Rx errors not counting missed packets anymore Thomas Monjalon
2016-03-22 16:58 ` Thomas Monjalon
2016-03-22 18:28 ` [PATCH] ethdev: don't count missed packets in erroneous packets counter Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2180400.M1OUCR6DC3@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=iryzhov@nfware.com \
--cc=maryam.tahhan@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.