From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/6] x264: add from meta-oe, update and tweak
Date: Fri, 09 Aug 2013 10:58:30 +0100 [thread overview]
Message-ID: <21844536.louSSSY83b@helios> (raw)
In-Reply-To: <20130809092044.GE17945@jama>
Hi Martin,
On Friday 09 August 2013 11:20:44 Martin Jansa wrote:
> On Fri, Aug 09, 2013 at 09:59:31AM +0100, Paul Eggleton wrote:
> > This is required by the default configuration of libav being brought over
> > from meta-oe. Changes from the meta-oe recipe:
> >
> > * Update to the latest revision from the stable branch (upstream does
> >
> > not seem to provide stable releases.)
> >
> > * Add LICENSE_FLAGS = "commercial"
> > * Enable PIC to fix text relocation warnings and disable warning for
> >
> > i586 (since PIC can't be used there)
> >
> > * Make SUMMARY value slightly shorter
> > * Indent SRC_URI properly
>
> I think it was indented correctly and styleguide doesn't define how many
> spaces should be used for multiline variables.
It doesn't, but the convention that is observed in OE-Core is to indent
multiple-line statements to the level of the start of the value in the first
line (as indeed the value of EXTRA_OECONF is indented in this recipe). FWIW, I
have altered the commit message to refer to consistency with other recipes
rather than correctness.
> > +EXTRA_OECONF = '--prefix=${prefix} \
> > + --host=${HOST_SYS} \
> > + --cross-prefix=${TARGET_PREFIX} \
> > + --sysroot=${STAGING_DIR_TARGET} \
> > + --enable-shared \
> > + --enable-static \
> > + --disable-lavf \
> > + --disable-swscale \
> > + --enable-pic \
>
> Don't mix tabs and spaces.
Oops, that's what I get for using vi without configuring it. Fixed on the
branch.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-08-09 9:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 8:59 [PATCH 0/6] Import libav from meta-oe Paul Eggleton
2013-08-09 8:59 ` [PATCH 1/6] yasm: add from meta-oe and tweak Paul Eggleton
2013-08-09 16:32 ` Burton, Ross
2013-08-09 16:37 ` Paul Eggleton
2013-08-09 8:59 ` [PATCH 2/6] x264: add from meta-oe, update " Paul Eggleton
2013-08-09 9:20 ` Martin Jansa
2013-08-09 9:58 ` Paul Eggleton [this message]
2013-08-09 8:59 ` [PATCH 3/6] libav: " Paul Eggleton
2013-08-14 12:22 ` Martin Jansa
2013-08-14 13:07 ` Phil Blundell
2013-08-14 13:57 ` Burton, Ross
2013-08-09 8:59 ` [PATCH 4/6] gst-ffmpeg: merge in bbappend from meta-oe Paul Eggleton
2013-08-09 8:59 ` [PATCH 5/6] gst-ffmpeg: enable using yasm during build Paul Eggleton
2013-08-09 8:59 ` [PATCH 6/6] gst-ffmpeg: set SUMMARY instead of DESCRIPTION Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21844536.louSSSY83b@helios \
--to=paul.eggleton@linux.intel.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.