From: Luke Jones <luke@ljones.dev>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
corentin.chary@gmail.com, platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/9] platform/x86: asus-wmi: support toggling POST sound
Date: Wed, 03 Apr 2024 13:06:17 +1300 [thread overview]
Message-ID: <21854739.fSG56mABFh@fedora> (raw)
In-Reply-To: <0c8635b9-db16-9125-63bc-7761800e3e96@linux.intel.com>
On Tuesday, 2 April 2024 11:47:08 PM NZDT Ilpo Järvinen wrote:
> On Tue, 2 Apr 2024, Luke D. Jones wrote:
> > Add support for toggling the BIOS POST sound on some ASUS laptops.
> >
> > Signed-off-by: Luke D. Jones <luke@ljones.dev>
> > ---
> >
> > .../ABI/testing/sysfs-platform-asus-wmi | 9 ++++
> > drivers/platform/x86/asus-wmi.c | 51 +++++++++++++++++++
> > include/linux/platform_data/x86/asus-wmi.h | 3 ++
> > 3 files changed, 63 insertions(+)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > b/Documentation/ABI/testing/sysfs-platform-asus-wmi index
> > ef1ac1a20a71..41b92e53e88a 100644
> > --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > @@ -194,3 +194,12 @@ Contact: "Luke Jones" <luke@ljones.dev>
> >
> > Description:
> > Set the target temperature limit of the Nvidia dGPU:
> > * min=75, max=87
> >
> > +
> > +What: /sys/devices/platform/<platform>/boot_sound
> > +Date: Apr 2024
> > +KernelVersion: 6.10
> > +Contact: "Luke Jones" <luke@ljones.dev>
> > +Description:
> > + Set if the BIOS POST sound is played on boot.
> > + * 0 - False,
> > + * 1 - True
> > \ No newline at end of file
>
> Add the last newline please.
Editor removed :(
>
> After fixing that, please add:
>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Done and done.
next prev parent reply other threads:[~2024-04-03 0:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 2:25 [PATCH v2 0/9] asus-wmi: add new features, clean up, fixes Luke D. Jones
2024-04-02 2:25 ` [PATCH v2 1/9] platform/x86: asus-wmi: add support for 2024 ROG Mini-LED Luke D. Jones
2024-04-02 10:43 ` Ilpo Järvinen
2024-04-02 23:59 ` Luke Jones
2024-04-02 2:26 ` [PATCH v2 2/9] platform/x86: asus-wmi: add support for Vivobook GPU MUX Luke D. Jones
2024-04-02 10:44 ` Ilpo Järvinen
2024-04-02 2:26 ` [PATCH v2 3/9] platform/x86: asus-wmi: add support variant of TUF RGB Luke D. Jones
2024-04-02 10:45 ` Ilpo Järvinen
2024-04-02 2:26 ` [PATCH v2 4/9] platform/x86: asus-wmi: support toggling POST sound Luke D. Jones
2024-04-02 10:47 ` Ilpo Järvinen
2024-04-03 0:06 ` Luke Jones [this message]
2024-04-02 2:26 ` [PATCH v2 5/9] platform/x86: asus-wmi: store a min default for ppt options Luke D. Jones
2024-04-02 10:49 ` Ilpo Järvinen
2024-04-03 0:09 ` Luke Jones
2024-04-03 8:21 ` Ilpo Järvinen
2024-04-02 2:26 ` [PATCH v2 6/9] platform/x86: asus-wmi: adjust formatting of ppt-<name>() functions Luke D. Jones
2024-04-02 10:51 ` Ilpo Järvinen
2024-04-02 2:26 ` [PATCH v2 7/9] platform/x86: asus-wmi: ROG Ally increase wait time, allow MCU powersave Luke D. Jones
2024-04-02 2:26 ` [PATCH v2 8/9] platform/x86: asus-wmi: Add support for " Luke D. Jones
2024-04-02 11:01 ` Ilpo Järvinen
2024-04-02 23:30 ` Luke Jones
2024-04-03 8:31 ` Ilpo Järvinen
2024-04-02 2:26 ` [PATCH v2 9/9] platform/x86: asus-wmi: cleanup main struct to avoid some holes Luke D. Jones
2024-04-02 11:02 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21854739.fSG56mABFh@fedora \
--to=luke@ljones.dev \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.