From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEEAF40BCC4 for ; Mon, 13 Jul 2026 14:16:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783952172; cv=none; b=eAkhoNMrq2bwG1MEmPVrSlswX/v/ZUb5ihNZ3wql3NAjpgHmuboDuPYTCpbMiecMXPZXDkaiqvjDtWYn0WV9pVvfmu3vf/GRIlFJAqzbC18DsDfMfxpSFZUKzgun00R+n5J5occZq6DCTP0Ul9kXmSF1rp7QZDSX/p+KVMAVU0E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783952172; c=relaxed/simple; bh=rjRRwXeoSvQ2Yt2kDuIXsZVmldbbQ93lhgFEVsggEBI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Sr0eXSpA+6KjPiJ3s2OnIY9wbJry05GOc//R7AGTcFhX3CWkE4AvXHMo1ZQJODyKgGAuibJZTe1tc5e1ksxm01LBGs9WjxwOLlFhztQwQw0EfydRIcz1NMoaSVyJK5x/0qz/ltjxgZVcHjP7lsXe7+aqaYNq4AL9BYdFimFPy/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=a89fZUTK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WdVI+wlZ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="a89fZUTK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WdVI+wlZ" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66DCE3ZJ1561381 for ; Mon, 13 Jul 2026 14:16:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= s9Td5s4NB4XQ8rznggNIITWnlk3IwS8MZDx5I4v8/zU=; b=a89fZUTKY0N0QfDn ltmn0X2fEeXWAMOmkV1ChSPUa4LS39VVSoRq/MX4HbD3qqM/PSJhF8PpwLaXSCa8 o9nt5KCmu4pxH/m1eaEOoVi2fQ9Q9X2Kt7TTtdVbWz1ofkcMHyIdecFd/UW3j/Ak qqd0pgE1cnesSMa/qX/22P+8OfLKvnaLqAoWZqi0XhbhmKzjeDMWUWDZGmAagz75 VlkBWRdyd5szxUzaEjlTba9l8CdVIuFjrbIYZS+ZbE2PXLX6aMTPY7RUq4ah5BSG R/pzV6uYg9lieDTYDjXTzL8sUm2HcMJCYuuayVxWkymPCXXUxbWBpiJ5QYGHGwvQ l4gJLA== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fcjn3awrq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 14:16:09 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-84a251c2e3eso1692505b3a.1 for ; Mon, 13 Jul 2026 07:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783952169; x=1784556969; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=s9Td5s4NB4XQ8rznggNIITWnlk3IwS8MZDx5I4v8/zU=; b=WdVI+wlZDmaK3lyYN35qalo7WpnokSscPrKHRzP2Ves/cO/rqLduxuHsz+CJkVPRBk XTbZ+xsESfTpNnUSW3hw+eR3M1BPv+puC63J6/fcEFGypcDAU9zFVuBa29yy9zGi/gM9 j5qMGZwtpGKaE2EGhiNwvEzVkcepbflHYTYG/4I00wzPrcZp3fsvPYnM9nb7snrzmCcY Zk/U/XoeVTsawBsNtMqm64PTaudMK6po4unWCtfYqU1bEVaL7RiLd5a1AwUWxrQbLZgO YU+knTaKDGpTzar56PdaK7bt2Oqvy75gX2xedsm/mjh/tmwD4rVgFlmVL1RbJafhjLxi QQwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783952169; x=1784556969; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=s9Td5s4NB4XQ8rznggNIITWnlk3IwS8MZDx5I4v8/zU=; b=o9pmw9cx1lEO2cY+XBVIPvaeSjyCdcWr6w6ftJVKmw5YDh2iikbwNNmVs5jcel9bgT vHJLj/cYCCsuWRclgPUbXK1YHHtY8LVIsu1mXcR2UPiDgjCvPkGhNzuvFdnCY3Gy+QJz rHTktdkKL84uuuX5KiRacikpg/CyHiQbjndpvcs5YK9E5IBm3xdJPJ1KpWFZIuV7hzOz 3nRGKySxGnmGnQcK42HtWiqJ/zwxt2IV5NCSYn7UH5htz39pbdI21EjkwUCpk4g3w45U 5b0ho5tBpA7AKj8UKQfBdP8AIOoJSU/2Y+ZyylP7UJsbCCi9SdNIqsXhNz/mqFjsTwgz /c0w== X-Forwarded-Encrypted: i=1; AHgh+RoASmlkJI+ioQUvDg//ml8vdBR7KVR3qUP+rLxNOgbDNF3PXtOwx1Ta8CQZYX98VX3qKlVfydd5x/NDMSo=@vger.kernel.org X-Gm-Message-State: AOJu0YzkXWL570wEIogz2D843jGcPpIyUBViIXOO2hJXFoR+buBJHMqN Mi7ys1O81F1nAgx4KgyoezhwGK9N4yNsNqoUFrXsiP6YzFgyRnxy1JjECrlsedypd5xMmvdWWTy nfOHhccbKBIsymMrKX2OGZ78WEfSBbD066pS0MH4ewzuBqSdG+He4vWV8i8gCToWt9YQ= X-Gm-Gg: AfdE7cn85n9Uh26h3JJc2odk4sfkazQ9C+kqnx94Lb6PefKoeH27PYx2qSmZErDAU2g Tgoymb6eXsJfvUDhPjRhT1OicEFeE9RufISc62ICPlSlTKdhO3KIAwmBSuPQzk4upzRyXjZ+1l0 Y3yzSjgtLzAM9JhSqrdvinNOEOdqJuRdkmqzRjHcHnQIhJwBiJFy4Xkg1Ew3/pAlPacvgiLf/LC zkwRYx7Q9YbkoidAm1gabJvO6UnqJ4wwnXyUlQpMRLSFBYe4UbJezz4kPGVUlKZK5A8IOmdBb2i Y6MhhhhFb5RMXVCtNm6U7paKdEdwZmMPz71eq6haXBC5Uc0LBIfs0XkFHLpDAfVBH282Cb3sAHt GJGGdq1aJ/oZY05vD5t2U03GOz4Nm17isn2HSZaquxKbf X-Received: by 2002:a05:6a00:1c99:b0:848:2ef5:50dd with SMTP id d2e1a72fcca58-8488ad09145mr7755445b3a.37.1783952169270; Mon, 13 Jul 2026 07:16:09 -0700 (PDT) X-Received: by 2002:a05:6a00:1c99:b0:848:2ef5:50dd with SMTP id d2e1a72fcca58-8488ad09145mr7755409b3a.37.1783952168780; Mon, 13 Jul 2026 07:16:08 -0700 (PDT) Received: from [192.168.0.215] ([49.205.244.213]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a49591cbdsm452482b3a.40.2026.07.13.07.16.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2026 07:16:07 -0700 (PDT) Message-ID: <21867efc-b5a8-4ed9-92b4-059a020731a6@oss.qualcomm.com> Date: Mon, 13 Jul 2026 19:46:02 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/7] bus: mhi: Add QDU100 Sahara variant and firmware fallback To: Manivannan Sadhasivam Cc: Jonathan Corbet , Shuah Khan , Jeff Hugo , Carl Vanderlip , Oded Gabbay , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, mhi@lists.linux.dev References: <20260701-sahara_protocol_new_v2-v6-0-3a78362c4741@oss.qualcomm.com> <20260701-sahara_protocol_new_v2-v6-4-3a78362c4741@oss.qualcomm.com> Content-Language: en-US From: Kishore Batta In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDE0NyBTYWx0ZWRfX8T71P8j3dpiX efBGyNn3dIDz68AfLtYbgxLB3Q7vB4PI57xxFFuc5EA1FNybbmgPooCHbqMMknEOWCcMKHO59xv 6d603cCqMKUM/n6j+f4fYzRp941y7PoniDSviaf2T6HeXSIQo8nYKEe45xgERbiGgX2m0ClKaWe jxXv5tNNzqtL2pAHL2NZbepZC5q6DuuhmJpOcBNHWAYhIqv5i8TC0GrG6h6QX8jg5x3DIahRyfs JddqHk3yt9c0PdI8V57kcJ0pl9dQ4cMpOTx/ErdvWz0XzLAeEvIMczEQlK6ROtWon5zMTHvAH6t HzOb1fJDqxtXvNpDP54wPger80SCnESo9TFS5tQJ4mv6uEmMxvdc+zA2o6qlAclv6rlqr63d1Hd 7Hk5RJPXCItafZRaXTh0J/7k7ah/PPNaiVFfW+oaozmvck2zTyfYR7iggApshDabhrCqUIo8QAe Ln8RXXlu0CNWFkwO6LA== X-Proofpoint-ORIG-GUID: X39101dUH8_sT7CIiLfGognpVEvd2hHz X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDE0NyBTYWx0ZWRfX0TepZsWLEI5G GHcgd/seg+fVGMySVP8jBjE5O55ukboVpGVY1oZ5tgiiqdIHZqfVd3Q7exm5JykEA8pvoDaXL/J yNTcY0R8/zFHRE1ULDcme31Wyq+p9Pw= X-Proofpoint-GUID: X39101dUH8_sT7CIiLfGognpVEvd2hHz X-Authority-Analysis: v=2.4 cv=aaJRWxot c=1 sm=1 tr=0 ts=6a54f32a cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=KtsNJ/6bKgz7QsArn2OSsQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=ggBkse9BzyKxnYN-cX8A:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_03,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130147 On 7/9/2026 11:49 AM, Manivannan Sadhasivam wrote: > On Wed, Jul 01, 2026 at 04:07:38PM +0530, Kishore Batta wrote: >> The Sahara driver currently selects a firmware image table based on the >> attached device, but it does not recognize QDU100 devices that expose the >> protocol on the SAHARA MHI channel. As a result, the host cannot associate >> QDU100 devices with the correct firmware namespace during image transfer. >> >> Extend the probe time variant selection to match the SAHARA MHI channel and >> associate it with the QDU100 firmware folder. Add a firmware lookup >> fallback for cases where an image does not have an explicit entry in the >> device's firmware table. This allows required images to be provisioned by >> the platform. >> >> This change only affects devices matched on the SAHARA MHI channel and >> does not change behavior for existing AIC100 and AIC200 devices. >> >> Signed-off-by: Kishore Batta >> --- >> drivers/bus/mhi/host/clients/sahara/sahara.c | 27 +++++++++++++++-- >> drivers/bus/mhi/host/pci_generic.c | 45 ++++++++++++++++++++++++++++ >> 2 files changed, 70 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/bus/mhi/host/clients/sahara/sahara.c b/drivers/bus/mhi/host/clients/sahara/sahara.c >> index e339c67e236af271645ca81cc517efd9eead87e4..9adbd84859073d8024ba2a5fcfa33897439d6759 100644 >> --- a/drivers/bus/mhi/host/clients/sahara/sahara.c >> +++ b/drivers/bus/mhi/host/clients/sahara/sahara.c >> @@ -189,6 +189,7 @@ static bool is_streaming(struct sahara_context *context) >> >> static int sahara_find_image(struct sahara_context *context, u32 image_id) >> { >> + char *fw_path; >> int ret; >> >> if (image_id == context->active_image_id) >> @@ -201,8 +202,28 @@ static int sahara_find_image(struct sahara_context *context, u32 image_id) >> } >> >> if (image_id >= context->table_size || !context->image_table[image_id]) { >> - dev_err(&context->mhi_dev->dev, "request for unknown image: %d\n", image_id); >> - return -EINVAL; >> + if (!context->fw_folder) { >> + dev_err(&context->mhi_dev->dev, >> + "Request for unknown image: %u (no fw folder)\n", image_id); >> + return -EINVAL; >> + } >> + >> + fw_path = kasprintf(GFP_KERNEL, "qcom/%s/%u", >> + context->fw_folder, image_id); >> + if (!fw_path) >> + return -ENOMEM; >> + >> + ret = firmware_request_nowarn(&context->firmware, >> + fw_path, >> + &context->mhi_dev->dev); >> + kfree(fw_path); >> + if (ret) { >> + dev_err(&context->mhi_dev->dev, >> + "request for unknown image: %d\n", image_id); >> + return -EINVAL; >> + } >> + context->active_image_id = image_id; >> + return 0; >> } >> >> /* >> @@ -870,8 +891,10 @@ static void sahara_mhi_dl_xfer_cb(struct mhi_device *mhi_dev, struct mhi_result >> >> static const struct mhi_device_id sahara_mhi_match_table[] = { >> { .chan = "QAIC_SAHARA", }, >> + { .chan = "SAHARA"}, >> {}, >> }; >> +MODULE_DEVICE_TABLE(mhi, sahara_mhi_match_table); >> > This change should belong to a separate patch. > >> static struct mhi_driver sahara_mhi_driver = { >> .id_table = sahara_mhi_match_table, >> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c >> index 391ab146f501c6ce1c81f6138f7c491a49c2f264..82e41632afc555a53dec3d8395558ae039b33bbd 100644 >> --- a/drivers/bus/mhi/host/pci_generic.c >> +++ b/drivers/bus/mhi/host/pci_generic.c >> @@ -300,6 +300,43 @@ static const struct mhi_pci_dev_info mhi_qcom_qdu100_info = { >> .reset_on_remove = true, >> }; >> >> +static const char * const qdu100_image_table[] = { >> + [5] = "qcom/qdu100/uefi.elf", >> + [8] = "qcom/qdu100/qdsp6sw.mbn", >> + [16] = "qcom/qdu100/efs1.bin", >> + [17] = "qcom/qdu100/efs2.bin", >> + [20] = "qcom/qdu100/efs3.bin", >> + [23] = "qcom/qdu100/aop.mbn", >> + [25] = "qcom/qdu100/tz.mbn", >> + [29] = "qcom/qdu100/zeros_1sector.bin", >> + [33] = "qcom/qdu100/hypvm.mbn", >> + [34] = "qcom/qdu100/mdmddr.mbn", >> + [36] = "qcom/qdu100/multi_image_qti.mbn", >> + [37] = "qcom/qdu100/multi_image.mbn", >> + [38] = "qcom/qdu100/xbl_config.elf", >> + [39] = "qcom/qdu100/abl_userdebug.elf", >> + [40] = "qcom/qdu100/zeros_1sector.bin", >> + [41] = "qcom/qdu100/devcfg.mbn", >> + [42] = "qcom/qdu100/zeros_1sector.bin", >> + [45] = "qcom/qdu100/tools_l.elf", >> + [46] = "qcom/qdu100/Quantum.elf", >> + [47] = "qcom/qdu100/quest.elf", >> + [48] = "qcom/qdu100/xbl_ramdump.elf", >> + [49] = "qcom/qdu100/shrm.elf", >> + [50] = "qcom/qdu100/cpucp.elf", >> + [51] = "qcom/qdu100/aop_devcfg.mbn", >> + [52] = "qcom/qdu100/fw_csm_gsi_3.0.elf", >> + [53] = "qcom/qdu100/qdsp6sw_dtbs.elf", >> + [54] = "qcom/qdu100/qupv3fw.elf", >> +}; >> + >> +static const struct mhi_sahara_fw_table qdu100_sahara_fw = { >> + .image_table = qdu100_image_table, >> + .table_size = ARRAY_SIZE(qdu100_image_table), >> + .fw_folder = "qdu100", >> + .non_streaming = false, >> +}; >> + >> static const struct mhi_channel_config mhi_qcom_sa8775p_channels[] = { >> MHI_CHANNEL_CONFIG_UL(46, "IP_SW0", 2048, 1), >> MHI_CHANNEL_CONFIG_DL(47, "IP_SW0", 2048, 2), >> @@ -1399,6 +1436,14 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) >> >> pci_set_drvdata(pdev, mhi_pdev); >> >> + /* >> + * Provide Sahara firmware mapping. Sahara consumes it via >> + * mhi_dev->mhi_cntrl->sahara_fw at probe time. >> + */ >> + if (info == &mhi_qcom_qdu100_info || >> + (info->name && !strcmp(info->name, "qcom-qdu100"))) >> + mhi_cntrl->sahara_fw = &qdu100_sahara_fw; >> + > Why are you adding QAIC MHI controller config in pci_generic driver? This driver > only handles Modem devices. > > - Mani Hi Mani, Above one is for QDU100 device. QAIC is not added in this file. >