From: Thomas Monjalon <thomas@monjalon.net>
To: Ric Li <ricmli@outlook.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com, david.marchand@redhat.com
Subject: Re: [PATCH v2 1/2] build: fix list_dir_globs failure in MSYS2
Date: Wed, 11 Oct 2023 17:27:22 +0200 [thread overview]
Message-ID: <2188661.NgBsaNRSFp@thomas> (raw)
In-Reply-To: <TYAP286MB0300BB597DDFC33CF7D2BA70CCF9A@TYAP286MB0300.JPNP286.PROD.OUTLOOK.COM>
20/09/2023 16:18, Ric Li:
> When running 'meson setup' on Windows with MSYS2,
> "list-dir-globs.py * failed with status 1".
We don't know why it is failing?
What about other usages of list_dir_globs in drivers and lib?
> Avoid using globbing to get components for app build
> since they are already listed in the meson file.
I don't understand the logic.
> +disable_apps = ',' + get_option('disable_apps')
> +disable_apps = run_command(list_dir_globs, disable_apps, check: true).stdout().split()
This could fail.
> +
> +enable_apps = ',' + get_option('enable_apps')
> +enable_apps = run_command(list_dir_globs, enable_apps, check: true).stdout().split()
> +if enable_apps.length() == 0
> + enable_apps = apps
> +endif
If nothing is enabled, we enable all?
next prev parent reply other threads:[~2023-10-11 15:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 13:15 [PATCH 1/2] build: fix list_dir_globs failure in MSYS2 Ric Li
2023-09-19 8:12 ` Bruce Richardson
2023-09-19 12:19 ` Ric Li
2023-09-20 14:18 ` [PATCH v2 " Ric Li
2023-09-20 15:07 ` Bruce Richardson
2023-10-11 15:27 ` Thomas Monjalon [this message]
2023-10-11 15:34 ` Bruce Richardson
2023-10-24 16:08 ` Ric Li
2024-02-18 13:45 ` Thomas Monjalon
[not found] ` <20230920141846.2187-1-ricmli@outlook.com>
2023-09-20 14:18 ` [PATCH v2 2/2] doc: add MSYS2 building guide Ric Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2188661.NgBsaNRSFp@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ricmli@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.