From: John Kacur <jkacur@gmail.com>
To: Suneeth D <Suneeth.D@amd.com>
Cc: linux-rt-users@vger.kernel.org, williams@redhat.com,
jkacur@redhat.com, bigeasy@linutronix.de
Subject: Re: [PATCH v3] cyclictest: Fix BUILD failure for GCC_VER < 15
Date: Fri, 11 Sep 2026 15:06:07 -0400 (EDT) [thread overview]
Message-ID: <218ceea9-abd5-8dfe-1e0c-85c1e81f8e50@gmail.com> (raw)
In-Reply-To: <20260911053216.2601-1-Suneeth.D@amd.com>
On Fri, 11 Sep 2026, Suneeth D wrote:
> timerthread() uses bool, true, and false. Those are keywords in C23,
> which became GCC's default in GCC 15 (-std=gnu23), so the file compiles
> there without stdbool.h. With GCC 14 and earlier the default is gnu17,
> where they are provided by <stdbool.h>, and the build fails without it.
>
> Fixes: 98fcd661ac59 (cyclictest: Acquire a lock before invoking pthread_cond_signal())
> Closes: https://lore.kernel.org/linux-rt-users/4ce24139-5f7e-4180-a290-bcc15fb4f559@amd.com/
> Signed-off-by: Suneeth D <Suneeth.D@amd.com>
> Signed-off-by: John Kacur <jkacur@redhat.com>
> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>
> Please ignore the previously sent v2. Sorry for the noise.
>
> Changes since v2 ---> v3:
>
> * Add Signed-off tag by John Kacur
>
You don't need to create a third patch version just to include my
sign-off. That's just my acknowledgement that I've accepted the patch into
my repo
Cheers
John Kacur
prev parent reply other threads:[~2026-09-11 19:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 5:32 [PATCH v3] cyclictest: Fix BUILD failure for GCC_VER < 15 Suneeth D
2026-09-11 19:06 ` John Kacur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=218ceea9-abd5-8dfe-1e0c-85c1e81f8e50@gmail.com \
--to=jkacur@gmail.com \
--cc=Suneeth.D@amd.com \
--cc=bigeasy@linutronix.de \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.