Re: [PATCH v1 1/1] malloc/mp: fix wait condition handling

[Thomas Monjalon <thomas@monjalon.net>]

12/07/2024 13:41, Anatoly Burakov:
> From coverity's point of view, it is theoretically possible to have an
> infinite wait on a wait condition because while we do check for timeout,
> we do not check for whether the event we are waiting for has already
> occurred by the time we get to the first cond_wait call (in this case,
> it's state of memory request list entry's state being set to COMPLETE).
> 
> This can't really happen as the only time a wait condition is triggered
> is when we are receiving a memory event (so the entry we are waiting on
> cannot change before wait condition is triggered because it's protected
> by a mutex), so either we receive an event and modify entry state, or we
> exit wait on a timeout and do not care about request state. However, it's
> better to keep coverity happy.
> 
> Coverity issue: 425709
> Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks.