From: "Daniel González Cabanelas" <dgcbueu@gmail.com>
To: davem@davemloft.net
Cc: kuba@kernel.org, f.fainelli@gmail.com,
gregkh@linuxfoundation.org, netdev@vger.kernel.org,
noltari@gmail.com
Subject: [PATCH v3] bcm63xx_enet: fix internal phy IRQ assignment
Date: Wed, 24 Feb 2021 17:11:33 +0100 [thread overview]
Message-ID: <2190629.1yaby32tsi@tool> (raw)
The current bcm63xx_enet driver doesn't asign the internal phy IRQ. As a
result of this it works in polling mode.
Fix it using the phy_device structure to assign the platform IRQ.
Tested under a BCM6348 board. Kernel dmesg before the patch:
Broadcom BCM63XX (1) bcm63xx_enet-0:01: attached PHY driver [Broadcom
BCM63XX (1)] (mii_bus:phy_addr=bcm63xx_enet-0:01, irq=POLL)
After the patch:
Broadcom BCM63XX (1) bcm63xx_enet-0:01: attached PHY driver [Broadcom
BCM63XX (1)] (mii_bus:phy_addr=bcm63xx_enet-0:01, irq=17)
Pluging and uplugging the ethernet cable now generates interrupts and the
PHY goes up and down as expected.
Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com>
---
changes in V3:
- snippet moved after the mdiobus err check
- snippet moved after the mdiobus registration
- added missing brackets
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
index fd876721316..22c782ed76a 100644
--- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
@@ -1818,14 +1818,22 @@ static int bcm_enet_probe(struct platform_device *pdev)
* if a slave is not present on hw */
bus->phy_mask = ~(1 << priv->phy_id);
- if (priv->has_phy_interrupt)
- bus->irq[priv->phy_id] = priv->phy_interrupt;
-
ret = mdiobus_register(bus);
if (ret) {
dev_err(&pdev->dev, "unable to register mdio bus\n");
goto out_free_mdio;
}
+
+ if (priv->has_phy_interrupt) {
+ phydev = mdiobus_get_phy(bus, priv->phy_id);
+ if (!phydev) {
+ dev_err(&dev->dev, "no PHY found\n");
+ goto out_unregister_mdio;
+ }
+
+ bus->irq[priv->phy_id] = priv->phy_interrupt;
+ phydev->irq = priv->phy_interrupt;
+ }
} else {
/* run platform code to initialize PHY device */
--
2.30.1
next reply other threads:[~2021-02-24 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 16:11 Daniel González Cabanelas [this message]
2021-02-24 17:08 ` [PATCH v3] bcm63xx_enet: fix internal phy IRQ assignment Florian Fainelli
2021-02-25 22:14 ` Andrew Lunn
2021-03-10 4:55 ` kernel test robot
2021-03-10 4:55 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2190629.1yaby32tsi@tool \
--to=dgcbueu@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noltari@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.