From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>
Subject: [PATCH] vpmu: Is CONFIG_SMP used anymore?
Date: Wed, 08 Feb 2012 14:14:31 +0100
Message-ID: <2192614.Ifr2rPImK0@amur>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Hi,

while locking at the vpmu stuff I found the following stuff:

diff -r a55e0f9c7b4e xen/arch/x86/oprofile/nmi_int.c
--- a/xen/arch/x86/oprofile/nmi_int.c	Wed Feb 08 12:28:47 2012 +0100
+++ b/xen/arch/x86/oprofile/nmi_int.c	Wed Feb 08 14:11:06 2012 +0100
@@ -305,7 +305,7 @@ static int __init p4_init(char ** cpu_ty
 	}
 
 #ifndef CONFIG_SMP
-	*cpu_type = "i386/p4", XENOPROF_CPU_TYPE_SIZE);
+	*cpu_type = "i386/p4";
 	model = &op_p4_spec;
 	return 1;
 #else


Is CONFIG_SMP always switched on? It seems nobody tested without CONFIG_SMP.
Thanks.

Dietmar.


-- 
Company details: http://ts.fujitsu.com/imprint.html