All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tom Hochstein" <tom.hochstein@nxp.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] meson: Fix wrapper handling of implicit setup command
Date: Fri, 03 Mar 2023 12:26:27 -0800	[thread overview]
Message-ID: <2193.1677875187297755462@lists.openembedded.org> (raw)
In-Reply-To: <CANNYZj_icOJayS1odPQE4oi1bESHR5gTT=xJS7QA95ijRe=5fg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]

On Fri, Mar 3, 2023 at 11:08 AM, Alexander Kanavin wrote:

> 
> This should have been caught by meta/lib/oeqa/sdk/cases/buildepoxy.py
> - why wasn't it? Does the test need to be fixed?

The simple test case doesn't have the problematic syntax. Should I add this to the patch?

diff --git a/meta/lib/oeqa/sdk/cases/buildepoxy.py b/meta/lib/oeqa/sdk/cases/buildepoxy.py
index ee515be188..147ee3e0ee 100644
--- a/meta/lib/oeqa/sdk/cases/buildepoxy.py
+++ b/meta/lib/oeqa/sdk/cases/buildepoxy.py
@@ -35,7 +35,7 @@ class EpoxyTest(OESDKTestCase):
self.assertTrue(os.path.isdir(dirs["source"]))
os.makedirs(dirs["build"])

-            log = self._run("meson -Degl=no -Dglx=no -Dx11=false {build} {source}".format(**dirs))
+            log = self._run("meson --warnlevel 1 -Degl=no -Dglx=no -Dx11=false {build} {source}".format(**dirs))
# Check that Meson thinks we're doing a cross build and not a native
self.assertIn("Build type: cross build", log)
self._run("ninja -C {build} -v".format(**dirs))

[-- Attachment #2: Type: text/html, Size: 1516 bytes --]

      reply	other threads:[~2023-03-03 20:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03 18:44 [PATCH] meson: Fix wrapper handling of implicit setup command Tom Hochstein
2023-03-03 19:08 ` [OE-core] " Alexander Kanavin
2023-03-03 20:26   ` Tom Hochstein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2193.1677875187297755462@lists.openembedded.org \
    --to=tom.hochstein@nxp.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.