From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2] mempool/dpaa2: add DPAA2 hardware
	offloaded mempool
Date: Tue, 11 Apr 2017 09:50:55 +0200
Message-ID: <21940728.tivBTtkBCF@xps13>
References: <1489754838-1455-2-git-send-email-hemant.agrawal@nxp.com>
 <20170410215847.704092d2@neon> <9977cf0c-e1cf-b235-e199-c5242daa75c2@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Olivier MATZ <olivier.matz@6wind.com>, dev@dpdk.org, shreyansh.jain@nxp.com,
 ferruh.yigit@intel.com
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com
 [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id 6248E282
 for <dev@dpdk.org>; Tue, 11 Apr 2017 09:50:57 +0200 (CEST)
Received: by mail-wr0-f169.google.com with SMTP id c55so89547496wrc.3
 for <dev@dpdk.org>; Tue, 11 Apr 2017 00:50:57 -0700 (PDT)
In-Reply-To: <9977cf0c-e1cf-b235-e199-c5242daa75c2@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-04-11 11:28, Hemant Agrawal:
> On 4/11/2017 1:28 AM, Olivier MATZ wrote:
> > Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
> >> --- a/drivers/bus/Makefile
> >> +++ b/drivers/bus/Makefile
> >> @@ -33,6 +33,10 @@ include $(RTE_SDK)/mk/rte.vars.mk
> >>
> >>  core-libs := librte_eal librte_mbuf librte_mempool librte_ring librte_ether
> >>
> >> +ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL),y)
> >> +CONFIG_RTE_LIBRTE_FSLMC_BUS = $(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL)
> >> +endif
> >> +
> >>  DIRS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += fslmc
> >>  DEPDIRS-fslmc = ${core-libs}
> >>
> >
> > What's the purpose of this?
> > Not sure we are allowed to modify the configs in the Makefiles.
> 
> DPAA2_MEMPOOL will not work without the DPAA2 mempool hw instance 
> detected on FSLMC_BUS.
> So, it is required that if you are enabling DPAA2_MEMPOOL, FSLMC_BUS is 
> to be enabled.
> 
> Currently the config structure do not provide such dependency definitions.
> 
> This was done based on the suggestions on the initial patches from 
> Ferruh and Jerin.

Please do not do that.
We do not change the configuration in the back of the user.
This kind of dependency should be managed in the configuration step
which do not exist yet.

You can use $(error) to stop the compilation instead.