From: Thomas Monjalon <thomas@monjalon.net>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Kevin Traynor <ktraynor@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>,
David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Pei Zhang <pezhang@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization
Date: Fri, 14 May 2021 11:25:35 +0200 [thread overview]
Message-ID: <2195769.KCgusFtMK6@thomas> (raw)
In-Reply-To: <17be3129-4c4b-4be1-75f5-672d36a819ed@intel.com>
14/05/2021 11:09, Ferruh Yigit:
> On 5/14/2021 9:18 AM, David Marchand wrote:
> > On Thu, May 13, 2021 at 5:04 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >>> If you choose to revert, we can ask Red Hat QA to test RC3 without
> >>> further delay. Please let us know when you consider the options.
> >>>
> >>
> >> If the patch is not good to go as it is I suggest reverting it, as far as I know
> >> Chenbo will be off for Friday & Monday, so it doesn't leave much time to
> >> update/test a new version.
> >
> > Yes, reverting is the safer, and the author proposed the same.
> >
>
> ack. Chenbo mentioned this is an optimization, so it should be OK to revert.
>
>
> Thomas,
>
> Can you revert the patch [1] in the main repo, or do you prefer a patch for it?
>
> [1]
> 968bbc7e2e50 ("vhost: avoid IOTLB mempool allocation while IOMMU disabled")
It would be better to have a patch with the correct explanation of the issue
and few acks if possible.
next prev parent reply other threads:[~2021-05-14 9:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 12:28 [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization Chenbo Xia
2021-05-13 13:10 ` Ferruh Yigit
2021-05-13 13:26 ` Kevin Traynor
2021-05-13 14:11 ` David Marchand
2021-05-13 14:38 ` Kevin Traynor
2021-05-13 15:03 ` Ferruh Yigit
2021-05-14 8:18 ` David Marchand
2021-05-14 9:09 ` Ferruh Yigit
2021-05-14 9:25 ` Thomas Monjalon [this message]
2021-05-14 8:16 ` David Marchand
2021-05-17 12:46 ` Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2195769.KCgusFtMK6@thomas \
--to=thomas@monjalon.net \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ktraynor@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=pezhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.