From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: linux-arm-kernel@lists.infradead.org,
Sascha Hauer <s.hauer@pengutronix.de>
Cc: imx@lists.linux.dev, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
linux@ew.tq-group.com,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Conor Dooley <conor+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH] arm64: dts: freescale: tqma9352: Fix watchdog reset
Date: Wed, 03 Jul 2024 14:40:07 +0200 [thread overview]
Message-ID: <2197747.irdbgypaU6@steina-w> (raw)
In-Reply-To: <20240703120409.1103787-1-s.hauer@pengutronix.de>
Hi Sascha,
thanks for the patch.
Am Mittwoch, 3. Juli 2024, 14:04:09 CEST schrieb Sascha Hauer:
> On the tqma9352 the board is reset through an external PMIC, so
> set the fsl,ext-reset-output property to enable triggering the
> output pin on a watchdog trigger.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> index 9d2328c185c90..e9d89b4bbba04 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> @@ -151,6 +151,7 @@ &wdog3 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_wdog>;
> status = "okay";
> + fsl,ext-reset-output;
As Fabio mentioned, status is the last property. With that fixed:
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> };
>
> &iomuxc {
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
prev parent reply other threads:[~2024-07-03 12:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 12:04 [PATCH] arm64: dts: freescale: tqma9352: Fix watchdog reset Sascha Hauer
2024-07-03 12:15 ` Fabio Estevam
2024-07-03 12:40 ` Alexander Stein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2197747.irdbgypaU6@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@ew.tq-group.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.