From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2498E3803F9; Fri, 28 Aug 2026 06:36:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787898996; cv=none; b=tAFZj2zMa1sR51YsSRhdkD9wl9vzQTKjbSLTIqUJNy0Ude3i04txIGDal7JwNNzgdWkUZse0qqmzn3z6EVnm/EVQounSx37/1Px5NN5RB7gBm1pfomDmuVcVzV0FNEdTMj4zAcjfxruM4QXNCvLVDRJMmQ3X2ozd8UUWd9ubqck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787898996; c=relaxed/simple; bh=mKyJGr0xXsffdv0VlNpwMXOCX1B0klmbMpV+oundKQQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eOVuWnFdg8H/F43sHxUJa5E8NAb3ybwqq4h86NMeLoGBPuIyQXON6cCnlYL3gesAqo463BUb5yNAwiEnZqaITZhE03Vj1rOLDPKmrRq6W8/fsQ6YSd8+rTVreD4P8Wmr8HeTpARSNWtG4tsAVWVdFQmvshpljJiM0cpmZ1S+C4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k2p92F6v; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k2p92F6v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD7E51F000E9; Fri, 28 Aug 2026 06:36:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787898994; bh=YYjgr1O1eqSfiDf48+HBf+HsSZb6YSwqsVnmyCy40/M=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=k2p92F6v7/Z6dejV9xCz4FtNyADbz4xhvY4/Zhn6Xk8AvN87B1SXodDDRGEGL5MM9 TvglwUs4/JSHe2thoLeZwbdtz6yukkmMAQ4sD4WvSYTprp9LmnEqEWpICamqUKSRBW nhg5GWcuU6NLSdFEG9BgeMVdmmXld6iAYJMNtlhM4Wx2E6md7rwQ4NXvID2WkGTqoo H5fubEk/dVddMwvbk2e2smiKM07O9HXbd1f906lOZM4ZPLkNALmjhP/Gl8UUmiEmvY Z9tK6XB58bFHSS7lW2LVLwq2HiMpfzo34Yg5TRPvO96KIMcvCtVIJ9wgy7eXUSvt/e IxTnENw3qCShw== Message-ID: <21dec355-0cd7-4250-a7f4-e93f3e446504@kernel.org> Date: Fri, 28 Aug 2026 08:36:29 +0200 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] dt-bindings: media: i2c: Add onsemi AR0234 image sensor binding To: Alexander Shiyan Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Mauro Carvalho Chehab , Rob Herring , Sakari Ailus , Hans Verkuil , Quentin Freimanis , Laurent Pinchart , Dave Stevenson References: <20260820075524.2056029-1-eagle.alexander923@gmail.com> <20260820075524.2056029-2-eagle.alexander923@gmail.com> <20260827-legendary-viridian-tamarin-4e56e5@quoll> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28/08/2026 07:51, Alexander Shiyan wrote: > Hello. > >> On Thu, Aug 20, 2026 at 10:55:23AM +0300, Alexander Shiyan wrote: >>> Add devicetree binding for the onsemi AR0234 CMOS image sensor. >>> Signed-off-by: Alexander Shiyan >>> --- >>> .../bindings/media/i2c/onnn,ar0234.yaml | 121 ++++++++++++++++++ >>> 1 file changed, 121 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml >> >> Unanswered Sashiko comments. > > I do not understand this remark. > The corrections based on sashiko-bot's feedback are included in the > cover letter. > Is something wrong? You received here Sashiko report which looks reasonable and you did not answer it. At least I could not find such answer. > >>> diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml > ... >>> +properties: >>> + compatible: >>> + enum: >>> + - onnn,ar0234cssc >>> + - onnn,ar0234cssm >>> + - onnn,ar0234cs >>> + description: >>> + The AR0234 sensor exists in two different models, a colour variant >>> + (AR0234CSSC) and a monochrome variant (AR0234CSSM). The device exposes >>> + the model through registers, allowing for auto-detection with a common >>> + "onnn,ar0234cs" compatible string. >> >> So all devices are compatible? Then why compatibility is not expressed? >> What are the actual programming differences between sc, sm and "none" >> variants? > > Perhaps I need to revert to the compatibility strings that were used > in version 2 > (https://patchwork.kernel.org/project/linux-media/patch/20260807102847.1813059-2-eagle.alexander923@gmail.com/). > > From a programming standpoint, it makes almost no difference which > sensor is used > - the only differences are in the output format and the format count. > Either way, the driver always uses the sensor model determined via > register reads. > If the specified type does not match the detected one, only a warning > will be printed. Devices should be made compatible with the fallback or even the color and mono variants could be dropped. That depends on the difference between color/mono. Best regards, Krzysztof