From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59CD425B668 for ; Mon, 10 Feb 2025 18:29:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739212179; cv=none; b=kHiL4rH6rvUka0FkTlhBNLKTHqn3LAbJWTSqV487hHnjrlp7B2TELdyI0pD9FNpwTWZhvGWiXnS8Vt7dTR5otbGXOW0CFpN5ZxMM5Lap0YeWjATEPcNW1OeIH3gkVEmLFSfOtNORwvnUr7NR8g/xUNu+ZWAX8f5CZINzrm0HhVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739212179; c=relaxed/simple; bh=MEHNkZcXxpS+hxkJ8mhV4LTpVb3YAe9QrpC2DPoZQwI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h72aN7KQD5rxplxd3xr0CC+DxDotWpdQ8pmjR/+g9p5VdzPW+Nx523s/ckKPmbZND4wck/YDS9m5PDoYhFe32bPJ5qy8s4NWuyMhgYW2TADf3Nx9+K/8ZAe7MEI5HucgQqqfg2lRf6WRp62H0SdKGHO67t1GkYwD3yCb02RxCu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AaB2ZDwa; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AaB2ZDwa" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51A96uU4008036 for ; Mon, 10 Feb 2025 18:29:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DC8spSheSA6T2HlKCCR7T2kUJcOm4paxe3Ffd4AgHC4=; b=AaB2ZDway5aRMwnk 3eNLQZGGbfidcqgdLxFpJP8IaO8Wifap5paQ5N/6Wn/LtaYnTYfD5+TgdI7bDpEj DfsqwA6nmQNczgKxh+yWbwGD5PBKelO9F34y10TtY2ppBkq+t5Hqi9jRRkky6PA8 Pd8hPc4V1F9aI7jGyL5kPSIochE7V1EUn89VbzbLU+KPCNc5t9rzy7Tz7xmpaFAa j9Cq8KgF2iDJlyLf94yrMaao00u3nl1Z75eF7XqkfMR12ZjAXtdvbXc+uRB8k32I mzKIZbwt/T6HIiIOe+l2VQGjRTdDbOVgJUUUlzZLDBdqhCi8O9w7Qnes0fwfOLwj hs0hZw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44p0guw88n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 10 Feb 2025 18:29:37 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4717d747eb8so3186301cf.0 for ; Mon, 10 Feb 2025 10:29:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739212176; x=1739816976; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DC8spSheSA6T2HlKCCR7T2kUJcOm4paxe3Ffd4AgHC4=; b=VAZy5VYzC4fUyQj87jLHLYutUqbYRwOsU6FJvNKAcc4NkNXtyEdbB6kb+KWteHI7Lw GxBlNjn2wzzvvQlIUa1A4yBJUj19RE1EJ5fg20iavzkSw6FT5bo0n3TyLpERQ4blIOZI oxAFEPykRgU/+MxONNvnEjiIZ+vxD3RRITC9Vf57thqJivcVftbK8NxIv2aj+fMs5aa4 f1FHuENiodlAs8vZXy0pBP6w/Tj2INeSco/EY4RY+lPwLK2pLeGOukLObKOdgWGPqWwc H2BMLokApYRd9CBy+GIb5Y+HMkqUPQjIJo+lHiiMbIc9KN9rlbSM7uMYvKubuK/J1mq1 YFRA== X-Gm-Message-State: AOJu0YxvHlh9n4etG12Mf959eL8otQ6tr3I1uwUzuYdu5vqBaDP43smK wA4pDHZtjdfjraKnUdbUZal3tyklxbwY9rzfBeNr1c6tp9hH0M7NJGZZhCHX7bAn5nsqrruzEMb 1ajUR+uHoo2h6ZXDqDz757eWL/xdS3zki5w73vS985GUWZtcK3eKE/4qY0Y1Fs4h0 X-Gm-Gg: ASbGncvfRcAWUerKCSIDRHZgYDRYT55nCCDVRSG42xV72NF/8QnP9u3IVroQQREYTii d24+i/vBdohvbSjMJATQVi3UaD6os/uWgIobBHI9k3pUAj2YC+UV3JZx9wZVHebiy8T+HBhdv1J S7uxIhIctW7lvB2aB085nqH/p1a981KWrFW75ZJAowWno8ukG6EVXnUtSMXAk/2V7oFQ0/qWTVH 9BS/QgnURgh72je/gMNhmOF0CvtsDvSw2l6zJIpjgJgIVmQ9t7271IrJbRZ6/y5SYnuGBGn2/wz vLNthJF1kxwFlbDuVq1dWrf15nOtUfzsoE1d41mqEqroYbXLrIB+Fef2BM0= X-Received: by 2002:a05:622a:1b87:b0:467:6bbf:c1ab with SMTP id d75a77b69052e-471679c7d79mr82349431cf.3.1739212176383; Mon, 10 Feb 2025 10:29:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IFEghXy0DEgESwZcs8Zekt9lj2aXRJe3t0RR5F0okviQbvHiJuXISN8X79nOYm3W2jhxw1mJA== X-Received: by 2002:a05:622a:1b87:b0:467:6bbf:c1ab with SMTP id d75a77b69052e-471679c7d79mr82349161cf.3.1739212175596; Mon, 10 Feb 2025 10:29:35 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7bcd53bf5sm298925066b.87.2025.02.10.10.29.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2025 10:29:35 -0800 (PST) Message-ID: <21f7eb11-bb0d-4e4d-a4b1-780c03fb86d9@oss.qualcomm.com> Date: Mon, 10 Feb 2025 19:29:33 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8650: add PPI interrupt partitions for the ARM PMUs To: neil.armstrong@linaro.org, Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250207-topic-sm8650-pmu-ppi-partition-v1-0-dd3ba17b3eea@linaro.org> <20250207-topic-sm8650-pmu-ppi-partition-v1-2-dd3ba17b3eea@linaro.org> <6aa71142-3b1d-476f-9c78-1207fbbed3f5@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: GO55e3XM2yMoQr6SGCPjhcAbnLgNBzG5 X-Proofpoint-GUID: GO55e3XM2yMoQr6SGCPjhcAbnLgNBzG5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-10_10,2025-02-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=947 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502100149 On 10.02.2025 4:30 PM, neil.armstrong@linaro.org wrote: > On 10/02/2025 16:23, Konrad Dybcio wrote: >> On 9.02.2025 3:44 PM, Neil Armstrong wrote: >>> On 07/02/2025 21:30, Konrad Dybcio wrote: >>>> On 7.02.2025 11:31 AM, Neil Armstrong wrote: >>>>> The PMUs shares the same per-cpu (PPI) interrupt, so declare the proper >>>>> interrupt partition maps and use the 4th interrupt cell to pass the >>>>> partition phandle for each ARM PMU node. >>>>> >>>>> Signed-off-by: Neil Armstrong >>>>> --- >>>> >>>>> @@ -5309,6 +5309,20 @@ intc: interrupt-controller@17100000 { >>>>>                #size-cells = <2>; >>>>>                ranges; >>>>>    +            ppi-partitions { >>>>> +                ppi_cluster0: interrupt-partition-0 { >>>>> +                    affinity = <&cpu0 &cpu1>; >>>>> +                }; >>>>> + >>>>> +                ppi_cluster1: interrupt-partition-1 { >>>>> +                    affinity = <&cpu2 &cpu3 &cpu4 &cpu5 &cpu6>; >>>>> +                }; >>>>> + >>>>> +                ppi_cluster2: interrupt-partition-2 { >>>>> +                    affinity = <&cpu7>; >>>>> +                }; >>>> >>>> I'm not sure this is accurate. >>>> >>>> I *think* it's cores 0-1 and 2-7, but I can't find a concrete answer >>> >>> Core 7 is a Cortex-X4, and has a dedicated PMU node, look at the cpu compatibles. >> >> Look at what these compatibles do in code. Nothing special for the X. > > So you suggest to revert Rob's change ? > > https://lore.kernel.org/all/20240417204247.3216703-1-robh@kernel.org/ > > So what I understood is that yes the code is the same, but the perf > attributes are not necessarily the same between heterogeneous cores, > so each instance here would load the attributes for each core type > correctly instead of only using the ones from the first core > > Again, other SoCs uses this same scheme so I wonder what's the issue here ? So I'm a little confused here. Is this partitioning scheme only describing a set of same-kind cores to Linux so that the PMU interrupts only arrive at one PMU device? Or does it reflect some actual physical topology of clusters and how they're connected to the GIC? If the former, I have no issues with this version of the patch. Konrad