From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail27.static.mailgun.info ([104.130.122.27]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jegMc-0005UV-4x for ath11k@lists.infradead.org; Fri, 29 May 2020 14:52:08 +0000 MIME-Version: 1.0 Date: Fri, 29 May 2020 20:21:42 +0530 From: Sathishkumar Muruganandam Subject: Re: [PATCH 1/2] mac80211: enable TKIP when using encapsulation offloading In-Reply-To: <86c1e5d23093f350bdabdde4c305c33ecde06b3b.camel@sipsolutions.net> References: <1587720951-9222-1-git-send-email-murugana@codeaurora.org> <1587720951-9222-2-git-send-email-murugana@codeaurora.org> (sfid-20200424_113624_468114_4CC488DE) <7fb606edf1e5c7ab5b1446d637768ee7@codeaurora.org> <4bab3197997bb2dd6555ff920c5dd1cb@codeaurora.org> <92eddf5d153781b2698ad258aac2fbe4@codeaurora.org> <86c1e5d23093f350bdabdde4c305c33ecde06b3b.camel@sipsolutions.net> Message-ID: <21fcffb4db13e9f0b70669d2e7f97d8a@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Johannes Berg Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org On 2020-05-29 20:14, Johannes Berg wrote: > On Fri, 2020-05-29 at 20:10 +0530, Sathishkumar Muruganandam wrote: >> On 2020-05-29 18:16, Johannes Berg wrote: >> > On Fri, 2020-05-29 at 17:59 +0530, Sathishkumar Muruganandam wrote: >> > > Yes, currently only tx encap support is added and rx decap support is >> > > in >> > > progress to do TKIP MIC error reporting to userspace via >> > > cfg80211_michael_mic_failure(). >> > >> > Yes, but can you actually call that? It requires a netdev. I don't >> > think >> > you can easily get it from the vif? >> > >> >> Yes, that's right. Currently the plan is to add new mac80211 api for >> rx >> decap where >> we can call cfg80211_michael_mic_failure() and not called directly >> from >> driver. > > Sure, that sounds fine. > > Really what I was saying is that we should have that together, not just > this patch that allows TKIP offload, but then nothing that actually > makes that working properly/safely. Sure, thanks Johannes ! Will include this along with rx decap patch. > >> Whether we can expose netdev to driver for doing such cfg80211 call ? > > I've always worried that if we expose the netdev we'll just get all > kinds of messy things happening in the driver :) > > But maybe not. I guess it doesn't make a big difference. > Sure, will fallback to mac80211 approach for rx decap. Thanks for your review ! Thanks, Sathishkumar _______________________________________________ ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35EBCC433E1 for ; Fri, 29 May 2020 14:52:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1568A2077D for ; Fri, 29 May 2020 14:52:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Nbotl77T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726907AbgE2OwG (ORCPT ); Fri, 29 May 2020 10:52:06 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:25812 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726476AbgE2OwF (ORCPT ); Fri, 29 May 2020 10:52:05 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1590763925; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=v/Rs67JNO7w/HTKxrh2duaFxLsZGJt9CRKendA0K2IM=; b=Nbotl77T41YtTQ4/GRwi+EOwroPDjY0m0M95z/Fhs+vcJuWjv0xrDjZ5P8GyqksMmpdqea4x 9+NwfHFyqAX7YEqNG9+IzAcP7vLRXA7RwulR4tAv3Hk5gi+2LGZqOQhAzuDRzTc7OpQc8lIT +aTto0Z0+HqMRDxrF15DpXEKYxY= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 5ed1217fc6d4683243abc350 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 29 May 2020 14:51:43 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 410E9C433CA; Fri, 29 May 2020 14:51:43 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: murugana) by smtp.codeaurora.org (Postfix) with ESMTPSA id DABC4C433C9; Fri, 29 May 2020 14:51:42 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 29 May 2020 20:21:42 +0530 From: Sathishkumar Muruganandam To: Johannes Berg Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/2] mac80211: enable TKIP when using encapsulation offloading In-Reply-To: <86c1e5d23093f350bdabdde4c305c33ecde06b3b.camel@sipsolutions.net> References: <1587720951-9222-1-git-send-email-murugana@codeaurora.org> <1587720951-9222-2-git-send-email-murugana@codeaurora.org> (sfid-20200424_113624_468114_4CC488DE) <7fb606edf1e5c7ab5b1446d637768ee7@codeaurora.org> <4bab3197997bb2dd6555ff920c5dd1cb@codeaurora.org> <92eddf5d153781b2698ad258aac2fbe4@codeaurora.org> <86c1e5d23093f350bdabdde4c305c33ecde06b3b.camel@sipsolutions.net> Message-ID: <21fcffb4db13e9f0b70669d2e7f97d8a@codeaurora.org> X-Sender: murugana@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-05-29 20:14, Johannes Berg wrote: > On Fri, 2020-05-29 at 20:10 +0530, Sathishkumar Muruganandam wrote: >> On 2020-05-29 18:16, Johannes Berg wrote: >> > On Fri, 2020-05-29 at 17:59 +0530, Sathishkumar Muruganandam wrote: >> > > Yes, currently only tx encap support is added and rx decap support is >> > > in >> > > progress to do TKIP MIC error reporting to userspace via >> > > cfg80211_michael_mic_failure(). >> > >> > Yes, but can you actually call that? It requires a netdev. I don't >> > think >> > you can easily get it from the vif? >> > >> >> Yes, that's right. Currently the plan is to add new mac80211 api for >> rx >> decap where >> we can call cfg80211_michael_mic_failure() and not called directly >> from >> driver. > > Sure, that sounds fine. > > Really what I was saying is that we should have that together, not just > this patch that allows TKIP offload, but then nothing that actually > makes that working properly/safely. Sure, thanks Johannes ! Will include this along with rx decap patch. > >> Whether we can expose netdev to driver for doing such cfg80211 call ? > > I've always worried that if we expose the netdev we'll just get all > kinds of messy things happening in the driver :) > > But maybe not. I guess it doesn't make a big difference. > Sure, will fallback to mac80211 approach for rx decap. Thanks for your review ! Thanks, Sathishkumar