From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH v2] block-sha1: remove use of assembly
Date: Tue, 08 Mar 2022 14:38:06 +0100 [thread overview]
Message-ID: <220308.864k48y35f.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <20220308022240.2809483-1-sandals@crustytoothpaste.net>
On Tue, Mar 08 2022, brian m. carlson wrote:
I think the $subject of the patch needs updating. It's not removing all
the assemply from the file, after this patch we still have the
ARM-specific assembly.
I don't have a box to test that on, but I wonder if that also triggers
the pedantic mode?
Perhaps:
block-sha1: remove superfluous i386 and x86-64 assembly
?
next prev parent reply other threads:[~2022-03-08 13:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 23:25 [PATCH] block-sha1: remove use of assembly brian m. carlson
2022-03-07 23:32 ` Taylor Blau
2022-03-08 2:20 ` brian m. carlson
2022-03-08 2:22 ` [PATCH v2] " brian m. carlson
2022-03-08 13:38 ` Ævar Arnfjörð Bjarmason [this message]
2022-03-09 22:10 ` brian m. carlson
2022-03-09 22:32 ` Taylor Blau
2022-03-09 23:52 ` Ævar Arnfjörð Bjarmason
2022-03-10 1:59 ` Carlo Marcelo Arenas Belón
2022-03-10 2:34 ` Taylor Blau
2022-03-10 17:47 ` [PATCH v3] block-sha1: remove use of obsolete x86 assembly brian m. carlson
2022-03-10 19:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220308.864k48y35f.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.