All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Elia Pinto <gitter.spiros@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 2/2] git-curl-compat.h: addition of all symbols defined by curl
Date: Wed, 16 Mar 2022 15:47:17 +0100	[thread overview]
Message-ID: <220316.86czimdkb0.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <20220316140106.14678-3-gitter.spiros@gmail.com>


On Wed, Mar 16 2022, Elia Pinto wrote:

Per the comment on v1 I really think we should not do this...

> This file was produced from a modified version of symbols.pl
> (https://github.com/curl/curl/blob/master/docs/libcurl/symbols.pl) and
> by manually adding the previous comments describing the dates of release
> of some curl versions not currently reported in the symbols-in-versions.
>
> To do this the symbols are listed in the order defined in the file
> symbols-in-versions rather than as they were previously inserted based
> on release dates.
>
> Most of these symbols are not used by git today. However, inserting
> them all starting from an automatic tool makes it largely unnecessary
> to update this file and therefore reduces the possibility
> of introducing possible errors in the future.
>
> Helped-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>

But more generally, re your reply on v1:

    In the end I did not understand if you think it is worthwhile that i
    do a reroll of  the patch[...]

Better than a re-roll is replying to outstanding concerns about your
patches. I.e. this, which still applies here
https://lore.kernel.org/git/220315.86pmmndmre.gmgdl@evledraar.gmail.com/

  reply	other threads:[~2022-03-16 14:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16 14:01 [PATCH 0/2] addition of all symbols defined by curl Elia Pinto
2022-03-16 14:01 ` [PATCH 1/2] curl: streamline conditional compilation Elia Pinto
2022-03-16 14:43   ` Ævar Arnfjörð Bjarmason
2022-03-16 18:04     ` Junio C Hamano
2022-03-16 14:01 ` [PATCH 2/2] git-curl-compat.h: addition of all symbols defined by curl Elia Pinto
2022-03-16 14:47   ` Ævar Arnfjörð Bjarmason [this message]
2022-03-16 22:24     ` Elia Pinto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=220316.86czimdkb0.gmgdl@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=gitter.spiros@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.