From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Victoria Dye via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de,
gitster@pobox.com, Victoria Dye <vdye@github.com>
Subject: Re: [PATCH] contrib/scalar: fix 'all' target in Makefile
Date: Wed, 06 Apr 2022 10:21:14 +0200 [thread overview]
Message-ID: <220406.861qyafwer.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <pull.1205.git.1649198136190.gitgitgadget@gmail.com>
On Tue, Apr 05 2022, Victoria Dye via GitGitGadget wrote:
> From: Victoria Dye <vdye@github.com>
>
> Add extra ':' to second 'all' target definition to allow 'scalar' to build.
> Without this fix, the 'all:' and 'all::' targets together cause a build
> failure when 'scalar' build is enabled with 'INCLUDE_SCALAR':
>
> Makefile:14: *** target file `all' has both : and :: entries. Stop.
Thanks for the fix, and sorry.
I missed this because I build and install scalar locally with a patch on
top[1] to integrate it into the main Makefile, so I wasn't running this
part, even if I was building, testing and installing it as part of my
local build.
1. https://lore.kernel.org/git/patch-1.1-86fb8d56307-20211028T185016Z-avarab@gmail.com/
prev parent reply other threads:[~2022-04-06 11:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 22:35 [PATCH] contrib/scalar: fix 'all' target in Makefile Victoria Dye via GitGitGadget
2022-04-06 8:21 ` Ævar Arnfjörð Bjarmason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220406.861qyafwer.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.