From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCC39C04FDE for ; Fri, 9 Dec 2022 17:32:26 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2DFD221FB; Fri, 9 Dec 2022 18:31:34 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2DFD221FB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1670607144; bh=6gaByd85Ir5jpC5TjpFdxoKpv9W8N2P7lwLZnGk0xEw=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=ZKUbCGXmO5VdIPR/j71UMnLUpGsgFjTN78gMxdzyP0HvrCvFkohtqNGJibMRcAtbS wI0GhGmDOWHUn8LDasmmnjaXnTHE/GSGAhqIFnYjl4/KGntHdkKYKGa9D6DeEmpWM3 bSis5A9CFRQaaDeEkrW7Q3NKnDo6YBPQefPWtC0o= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D8E67F80115; Fri, 9 Dec 2022 18:31:33 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 31204F800F8; Fri, 9 Dec 2022 18:31:33 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 18E0EF800F8 for ; Fri, 9 Dec 2022 18:31:30 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 18E0EF800F8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=F9lb5mf+ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670607092; x=1702143092; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=6gaByd85Ir5jpC5TjpFdxoKpv9W8N2P7lwLZnGk0xEw=; b=F9lb5mf+nIz6SVU9R4KchFlOKjf7SKcnV+zuYKE+Pm/qWEbfHehIhZ2M 8ZO3XcEae5kseK3wheV4l1iHJV0taAXPdHLpHqCtnGp+MKfqQgQtKi2J/ TxHcB92Ec9OJmNVKX0Rucbgtb8iPvvyJjkNnE15OJOjnRopmyDplNQE29 0WG/U990yEDAjP0EjMmqISEO5Qecs72fXktjyZCjTuIzP23UNpBTQQbVA +fE+pjiTUsMJ/DlBbwAKGH4FRek0VfU4IJHYderclYSYuPkEFK25ZrjaU tcGzdhBnEuqzH2pey4sW1LZ/OpZMjaedLc0W5q+Y/CNj0VPJO6xSuHjZJ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10556"; a="316213602" X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208";a="316213602" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2022 09:31:26 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10556"; a="625180439" X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208";a="625180439" Received: from bdmeredi-mobl2.amr.corp.intel.com (HELO [10.212.15.195]) ([10.212.15.195]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2022 09:31:25 -0800 Message-ID: <22043956-e18c-9ed6-5091-188ae40f3cd9@linux.intel.com> Date: Fri, 9 Dec 2022 11:31:24 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.4.2 Subject: Re: [PATCH v1] ASoC: Intel: sof_nau8825: add support for nau8825 with amp nau8318 To: Ajye Huang References: <20221209150503.11875-1-ajye_huang@compal.corp-partner.google.com> Content-Language: en-US From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Libin Yang , Liam Girdwood , Cezary Rojewski , Kai Vehmanen , ye xingchen , Peter Ujfalusi , Takashi Iwai , linux-kernel@vger.kernel.org, "balamurugan . c" , Mark Brown , Muralidhar Reddy , Ranjani Sridharan , Akihiko Odaki , David Lin , alsa-devel@alsa-project.org, Bard Liao , Brent Lu , Yong Zhi Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >> This looks inconsistent with the commit message. There are separate >> Kconfigs for different codecs. >> >> SND_SOC_NAU8315 >> SND_SOC_NAU8825 >> >> Which is it? >> > > Sorry about confusing you, I think it is better to change the title as > ASoC: Intel: sof_nau8825: add combination of nau8825 headset codec > with nau8318 Amp. Suggested edit: ASoC: Intel: sof_nau8825: add variant with nau8318 amplifier. > > And add some information about Nuvoton chips in the comment message. > *** > The nau8315 and nau8318 are both Nuvoton Amp chips. They use the same > Amp driver nau8315.c. The acpi_device_id for nau8315 is "NVTN2010", > for nau8318 is "NVTN2012". That should be added in the commit message please. >> NAK for this v1. Please clarify which codec you are using and make sure >> all references are consistent. >> >> > > I apologize for the unclear comment message, please give me any > suggestions if needed, and I will send v2 for review. > thanks. Ok, makes sense now. Please do include the explanations on 8315/8318 variants, I couldn't figure out what chips were used. I would also not use the same topology name as a different platform with another amplifier. I appreciate you trying to reuse when possible, but it's just better to create a new topology file. That way if you want any update down the road you can do so, it's more maintainable and risk-free. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 984A8C10F1E for ; Fri, 9 Dec 2022 17:31:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229763AbiLIRba (ORCPT ); Fri, 9 Dec 2022 12:31:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbiLIRb2 (ORCPT ); Fri, 9 Dec 2022 12:31:28 -0500 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C5A115709 for ; Fri, 9 Dec 2022 09:31:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670607087; x=1702143087; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=6gaByd85Ir5jpC5TjpFdxoKpv9W8N2P7lwLZnGk0xEw=; b=aK4aLT8f04EgmqTPTsh1o2xVK8uuJ7rVcR4uBe8P+ful5SbfV6yyc2cS X3k2Jk0af1hrCzODoWfcgTXzM8rbuiZ795uKt3oY4rzzCC/GtsYDB1CS9 46jh5e8FBIx23iQP5lMvi1dfDL1GQbB0tba22bqIRXKb+BwYUtBhmaWUC 536AAnj/JYmMQhh2NAT9aRAE4rtjrBp/fkiMqmGKzoqt7Hj1qqVJbY8CR LOfRUZhyUbjNA5scZkfqArXUJCdVvaPX4185iAxm8Roga6Gy+lMVSG3zw sX33TyyFyGTgycRMsdraZmJhMja+Ue94vF2BqOS1iLEbg373QNCx6MFx8 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10556"; a="316213601" X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208";a="316213601" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2022 09:31:26 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10556"; a="625180439" X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208";a="625180439" Received: from bdmeredi-mobl2.amr.corp.intel.com (HELO [10.212.15.195]) ([10.212.15.195]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2022 09:31:25 -0800 Message-ID: <22043956-e18c-9ed6-5091-188ae40f3cd9@linux.intel.com> Date: Fri, 9 Dec 2022 11:31:24 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.4.2 Subject: Re: [PATCH v1] ASoC: Intel: sof_nau8825: add support for nau8825 with amp nau8318 To: Ajye Huang Cc: Libin Yang , "balamurugan . c" , Cezary Rojewski , Kai Vehmanen , Bard Liao , Takashi Iwai , linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , Muralidhar Reddy , Ranjani Sridharan , Akihiko Odaki , ye xingchen , David Lin , alsa-devel@alsa-project.org, Peter Ujfalusi , Brent Lu , Yong Zhi References: <20221209150503.11875-1-ajye_huang@compal.corp-partner.google.com> Content-Language: en-US From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> This looks inconsistent with the commit message. There are separate >> Kconfigs for different codecs. >> >> SND_SOC_NAU8315 >> SND_SOC_NAU8825 >> >> Which is it? >> > > Sorry about confusing you, I think it is better to change the title as > ASoC: Intel: sof_nau8825: add combination of nau8825 headset codec > with nau8318 Amp. Suggested edit: ASoC: Intel: sof_nau8825: add variant with nau8318 amplifier. > > And add some information about Nuvoton chips in the comment message. > *** > The nau8315 and nau8318 are both Nuvoton Amp chips. They use the same > Amp driver nau8315.c. The acpi_device_id for nau8315 is "NVTN2010", > for nau8318 is "NVTN2012". That should be added in the commit message please. >> NAK for this v1. Please clarify which codec you are using and make sure >> all references are consistent. >> >> > > I apologize for the unclear comment message, please give me any > suggestions if needed, and I will send v2 for review. > thanks. Ok, makes sense now. Please do include the explanations on 8315/8318 variants, I couldn't figure out what chips were used. I would also not use the same topology name as a different platform with another amplifier. I appreciate you trying to reuse when possible, but it's just better to create a new topology file. That way if you want any update down the road you can do so, it's more maintainable and risk-free.