From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Sebastian Reichel <sre@kernel.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/omap: dsi: Fix missing of_platform_depopulate()
Date: Thu, 08 Nov 2018 19:08:57 +0200 [thread overview]
Message-ID: <2205760.spbUmrxuY7@avalon> (raw)
In-Reply-To: <20181108170145.GL56134@atomide.com>
Hi Tony,
On Thursday, 8 November 2018 19:01:45 EET Tony Lindgren wrote:
> * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [181107 05:30]:
> > On Tuesday, 6 November 2018 17:28:02 EET Tony Lindgren wrote:
> > > We're missing a call to of_platform_depopulate() on errors for dsi.
> > > Looks like dss is already doing this.
> > >
> > > Signed-off-by: Tony Lindgren <tony@atomide.com>
> >
> > This makes sense to me. You may however want to note in the commit message
> > that this patch also turns the of_platform_populate() failures into fatal
> > errors.
>
> Well of_platform_populate() failure should be fatal here,right? :)
I'm not complaining about the functional change, just the lack of visibility
:-)
> Tomi, let me know if you need a resend with updated comments or
> if you want to update the message yourself to your liking.
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-11-08 17:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 15:28 [PATCH] drm/omap: dsi: Fix missing of_platform_depopulate() Tony Lindgren
2018-11-07 13:30 ` Laurent Pinchart
2018-11-08 17:01 ` Tony Lindgren
2018-11-08 17:08 ` Laurent Pinchart [this message]
2018-11-08 17:29 ` Sebastian Reichel
2018-11-12 10:07 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2205760.spbUmrxuY7@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-omap@vger.kernel.org \
--cc=sre@kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.