From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm/bridge/synopsys: dsi: Adopt SPDX identifiers Date: Wed, 24 Jan 2018 01:32:08 +0200 Message-ID: <2205915.z0ubSpqczI@avalon> References: <20180122102608.12565-1-philippe.cornu@st.com> <3169703.7pajs7FEnH@avalon> <2bf185e2-9b02-3632-dc9a-baf8f4109b44@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <2bf185e2-9b02-3632-dc9a-baf8f4109b44@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philippe CORNU Cc: Maxime Coquelin , "linux-rockchip@lists.infradead.org" , David Airlie , Brian Norris , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Yannick FERTRE , "linux-arm-kernel@lists.infradead.org" , Ludovic BARRE , Mickael REULIER , Vincent ABRIOU , Bhumika Goyal , Alexandre TORGUE List-Id: linux-rockchip.vger.kernel.org SGkgUGhpbGlwcGUsCgpPbiBUdWVzZGF5LCAyMyBKYW51YXJ5IDIwMTggMTI6MjU6NTEgRUVUIFBo aWxpcHBlIENPUk5VIHdyb3RlOgo+IE9uIDAxLzIzLzIwMTggMTI6MzAgQU0sIExhdXJlbnQgUGlu Y2hhcnQgd3JvdGU6Cj4gPiBPbiBNb25kYXksIDIyIEphbnVhcnkgMjAxOCAxMjoyNjowOCBFRVQg UGhpbGlwcGUgQ29ybnUgd3JvdGU6Cj4gPj4gQWRkIFNQRFggaWRlbnRpZmllcnMgdG8gdGhlIFN5 bm9wc3lzIERlc2lnbldhcmUgTUlQSSBEU0kKPiA+PiBob3N0IGNvbnRyb2xsZXIgZHJpdmVyLgo+ ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogUGhpbGlwcGUgQ29ybnUgPHBoaWxpcHBlLmNvcm51QHN0 LmNvbT4KPiA+PiAtLS0KPiA+PiAKPiA+PiAgIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lub3Bz eXMvZHctbWlwaS1kc2kuYyB8IDYgKy0tLS0tCj4gPj4gICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNl cnRpb24oKyksIDUgZGVsZXRpb25zKC0pCj4gPj4KPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2JyaWRnZS9zeW5vcHN5cy9kdy1taXBpLWRzaS5jCj4gPj4gYi9kcml2ZXJzL2dwdS9k cm0vYnJpZGdlL3N5bm9wc3lzL2R3LW1pcGktZHNpLmMgaW5kZXgKPiA+PiA0NmIwZTczNDA0ZDEu LmUwNjgzNmRlYzc3YyAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3N5 bm9wc3lzL2R3LW1pcGktZHNpLmMKPiA+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3N5 bm9wc3lzL2R3LW1pcGktZHNpLmMKPiA+PiBAQCAtMSwxMiArMSw4IEBACj4gPj4gKy8vIFNQRFgt TGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wCj4gPiAKPiA+IEFjY29yZGluZyB0byBEb2N1bWVu dGF0aW9uL3Byb2Nlc3MvbGljZW5zZS1ydWxlcy50eHQgdGhpcyB3b3VsZCBjaGFuZ2UKPiA+IHRo ZSBleGlzdGluZyBsaWNlbnNlLiBUaGUgY29ycmVjdCBpZGVudGlmaWVyIGlzIEdQTC0yLjArLgo+ IAo+IFlvdSBhcmUgcmlnaHQsIEkgZGlkIG5vdCBwdXQgdGhlIGNvcnJlY3QgaWRlbnRpZmllciA6 KAo+IAo+IEFmdGVyIHJlYWRpbmcgbW9yZSBzcGR4Lm9yZywgSSB3b25kZXIgaWYgdGhlIGNvcnJl Y3QgdmFsdWUgc2hvdWxkIGJlIAo+IEdQTC0yLjAtb3ItbGF0ZXIgaW5zdGVhZCBvZiBHUEwtMi4w Kwo+IAo+IGh0dHBzOi8vc3BkeC5vcmcvbGljZW5zZXMvR1BMLTIuMC1vci1sYXRlci5odG1sCj4g aHR0cHM6Ly9zcGR4Lm9yZy9saWNlbnNlcy9HUEwtMi4wKy5odG1sCj4gCj4gV2hhdCBpcyB5b3Vy IG9waW5pb24/CgpJIGFncmVlIGluIHByaW5jaXBsZSwgYW5kIEkndmUgZXZlbiBhc2tlZCBmb3Ig dGhhdCBiZWZvcmUsIGJ1dCBJJ3ZlIGJlZW4gdG9sZCAKdGhhdCB3ZSBzaG91bGQgc3RpY2sgdG8g dGhlIGxpY2Vuc2UgaWRlbnRpZmllcnMgZGVmaW5lZCBpbiBEb2N1bWVudGF0aW9uLwpwcm9jZXNz L2xpY2Vuc2UtcnVsZXMudHh0LiBUaGUgZmlsZSBtaWdodCBnZXQgdXBkYXRlZCB0byB1c2UgR1BM LTIuMC1vci1sYXRlciAKYW5kIEdQTC0yLjAtb25seSBsYXRlciwgYW5kIGtlcm5lbCBzb3VyY2Vz IHdpbGwgbGlrZWx5IHRoZW4gZ2V0IHBhdGNoZWQgaW4gb25lIApnby4KCj4gPj4gIC8qCj4gPj4g ICAqIENvcHlyaWdodCAoYykgMjAxNiwgRnV6aG91IFJvY2tjaGlwIEVsZWN0cm9uaWNzIENvLiwg THRkCj4gPj4gICAqIENvcHlyaWdodCAoQykgU1RNaWNyb2VsZWN0cm9uaWNzIFNBIDIwMTcKPiA+ PiAgICoKPiA+PiAtICogVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVk aXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKPiA+PiAtICogaXQgdW5kZXIgdGhlIHRlcm1zIG9m IHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkKPiA+PiAtICog dGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNpb24gMiBvZiB0aGUgTGlj ZW5zZSwgb3IKPiA+PiAtICogKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KPiA+ PiAtICoKPiA+PiAgICogTW9kaWZpZWQgYnkgUGhpbGlwcGUgQ29ybnUgPHBoaWxpcHBlLmNvcm51 QHN0LmNvbT4KPiA+PiAgICogVGhpcyBnZW5lcmljIFN5bm9wc3lzIERlc2lnbldhcmUgTUlQSSBE U0kgaG9zdCBkcml2ZXIgaXMgYmFzZWQgb24gdGhlCj4gPj4gICAqIFJvY2tjaGlwIHZlcnNpb24g ZnJvbSByb2NrY2hpcC9kdy1taXBpLWRzaS5jIHdpdGggcGh5ICYgYnJpZGdlIEFQSXMuCgotLSAK UmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Wed, 24 Jan 2018 01:32:08 +0200 Subject: [PATCH] drm/bridge/synopsys: dsi: Adopt SPDX identifiers In-Reply-To: <2bf185e2-9b02-3632-dc9a-baf8f4109b44@st.com> References: <20180122102608.12565-1-philippe.cornu@st.com> <3169703.7pajs7FEnH@avalon> <2bf185e2-9b02-3632-dc9a-baf8f4109b44@st.com> Message-ID: <2205915.z0ubSpqczI@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Philippe, On Tuesday, 23 January 2018 12:25:51 EET Philippe CORNU wrote: > On 01/23/2018 12:30 AM, Laurent Pinchart wrote: > > On Monday, 22 January 2018 12:26:08 EET Philippe Cornu wrote: > >> Add SPDX identifiers to the Synopsys DesignWare MIPI DSI > >> host controller driver. > >> > >> Signed-off-by: Philippe Cornu > >> --- > >> > >> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 +----- > >> 1 file changed, 1 insertion(+), 5 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > >> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index > >> 46b0e73404d1..e06836dec77c 100644 > >> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > >> @@ -1,12 +1,8 @@ > >> +// SPDX-License-Identifier: GPL-2.0 > > > > According to Documentation/process/license-rules.txt this would change > > the existing license. The correct identifier is GPL-2.0+. > > You are right, I did not put the correct identifier :( > > After reading more spdx.org, I wonder if the correct value should be > GPL-2.0-or-later instead of GPL-2.0+ > > https://spdx.org/licenses/GPL-2.0-or-later.html > https://spdx.org/licenses/GPL-2.0+.html > > What is your opinion? I agree in principle, and I've even asked for that before, but I've been told that we should stick to the license identifiers defined in Documentation/ process/license-rules.txt. The file might get updated to use GPL-2.0-or-later and GPL-2.0-only later, and kernel sources will likely then get patched in one go. > >> /* > >> * Copyright (c) 2016, Fuzhou Rockchip Electronics Co., Ltd > >> * Copyright (C) STMicroelectronics SA 2017 > >> * > >> - * This program is free software; you can redistribute it and/or modify > >> - * it under the terms of the GNU General Public License as published by > >> - * the Free Software Foundation; either version 2 of the License, or > >> - * (at your option) any later version. > >> - * > >> * Modified by Philippe Cornu > >> * This generic Synopsys DesignWare MIPI DSI host driver is based on the > >> * Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752289AbeAWXcA (ORCPT ); Tue, 23 Jan 2018 18:32:00 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:36946 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751444AbeAWXb6 (ORCPT ); Tue, 23 Jan 2018 18:31:58 -0500 From: Laurent Pinchart To: Philippe CORNU Cc: Archit Taneja , Andrzej Hajda , David Airlie , Brian Norris , Benjamin Gaignard , Bhumika Goyal , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Sandy Huang , Heiko Stubner , "linux-arm-kernel@lists.infradead.org" , "linux-rockchip@lists.infradead.org" , Yannick FERTRE , Vincent ABRIOU , Alexandre TORGUE , Maxime Coquelin , Ludovic BARRE , Mickael REULIER Subject: Re: [PATCH] drm/bridge/synopsys: dsi: Adopt SPDX identifiers Date: Wed, 24 Jan 2018 01:32:08 +0200 Message-ID: <2205915.z0ubSpqczI@avalon> Organization: Ideas on Board Oy In-Reply-To: <2bf185e2-9b02-3632-dc9a-baf8f4109b44@st.com> References: <20180122102608.12565-1-philippe.cornu@st.com> <3169703.7pajs7FEnH@avalon> <2bf185e2-9b02-3632-dc9a-baf8f4109b44@st.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philippe, On Tuesday, 23 January 2018 12:25:51 EET Philippe CORNU wrote: > On 01/23/2018 12:30 AM, Laurent Pinchart wrote: > > On Monday, 22 January 2018 12:26:08 EET Philippe Cornu wrote: > >> Add SPDX identifiers to the Synopsys DesignWare MIPI DSI > >> host controller driver. > >> > >> Signed-off-by: Philippe Cornu > >> --- > >> > >> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 +----- > >> 1 file changed, 1 insertion(+), 5 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > >> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index > >> 46b0e73404d1..e06836dec77c 100644 > >> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > >> @@ -1,12 +1,8 @@ > >> +// SPDX-License-Identifier: GPL-2.0 > > > > According to Documentation/process/license-rules.txt this would change > > the existing license. The correct identifier is GPL-2.0+. > > You are right, I did not put the correct identifier :( > > After reading more spdx.org, I wonder if the correct value should be > GPL-2.0-or-later instead of GPL-2.0+ > > https://spdx.org/licenses/GPL-2.0-or-later.html > https://spdx.org/licenses/GPL-2.0+.html > > What is your opinion? I agree in principle, and I've even asked for that before, but I've been told that we should stick to the license identifiers defined in Documentation/ process/license-rules.txt. The file might get updated to use GPL-2.0-or-later and GPL-2.0-only later, and kernel sources will likely then get patched in one go. > >> /* > >> * Copyright (c) 2016, Fuzhou Rockchip Electronics Co., Ltd > >> * Copyright (C) STMicroelectronics SA 2017 > >> * > >> - * This program is free software; you can redistribute it and/or modify > >> - * it under the terms of the GNU General Public License as published by > >> - * the Free Software Foundation; either version 2 of the License, or > >> - * (at your option) any later version. > >> - * > >> * Modified by Philippe Cornu > >> * This generic Synopsys DesignWare MIPI DSI host driver is based on the > >> * Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs. -- Regards, Laurent Pinchart