All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,
	jerin.jacob@caviumnetworks.com
Subject: Re: [PATCH] eal: call plugin init before device parse
Date: Fri, 13 Oct 2017 15:40:02 +0200	[thread overview]
Message-ID: <2207048.supWhzNK8P@xps> (raw)
In-Reply-To: <5bc3a00c-2027-7b83-db34-719bdae051be@redhat.com>

13/10/2017 14:35, Maxime Coquelin:
> 
> On 10/13/2017 01:55 PM, Santosh Shukla wrote:
> > Default eal_init code calls
> > 0. eal_plugins_init
> > 1. eal_option_device_parse
> > 2. rte_bus_scan
> > 
> > IOVA commit:cf408c224 missed on calling eal_plugins_init before
> > eal_option_device_parse, rte_bus_scan and that introduced below
> > regression for shared mode:
> > 
> > with CONFIG_RTE_BUILD_SHARED_LIB=y:
> > 
> > 'net_vhost0,iface=/tmp/vhost-user2' -d ./install/lib/librte_pmd_vhost.so
> > -- --portmask=1 --disable-hw-vlan -i --rxq=1 --txq=1 --nb-cores=1
> > --eth-peer=0,52:54:00:11:22:12
> > EAL: Detected 4 lcore(s)
> > ERROR: failed to parse device "net_vhost0"
> > EAL: Unable to parse device 'net_vhost0,iface=/tmp/vhost-user2'
> > PANIC in main():
> > Cannot init EAL
> > 
> > Fixes: cf408c224 ("eal: auto detect IOVA mode")
> > 
> > Reported-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> > Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> > ---
> >   lib/librte_eal/bsdapp/eal/eal.c   | 10 +++++++---
> >   lib/librte_eal/linuxapp/eal/eal.c | 10 +++++++---
> >   2 files changed, 14 insertions(+), 6 deletions(-)
> 
> Tested-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Applied, thanks

      reply	other threads:[~2017-10-13 13:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-13 11:55 [PATCH] eal: call plugin init before device parse Santosh Shukla
2017-10-13 12:35 ` Maxime Coquelin
2017-10-13 13:40   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2207048.supWhzNK8P@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=santosh.shukla@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.