All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Adam Dinwoodie <adam@dinwoodie.org>,
	GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [RFC PATCH 1B] credential-cache--daemon: close input before exit-ing
Date: Thu, 07 Jul 2022 15:00:17 +0200	[thread overview]
Message-ID: <220707.86pmih847l.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <c344938b-afe9-edef-1e0d-fbe2425c8c01@ramsayjones.plus.com>


On Thu, Jul 07 2022, Ramsay Jones wrote:

> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>  builtin/credential-cache--daemon.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/builtin/credential-cache--daemon.c b/builtin/credential-cache--daemon.c
> index 4c6c89ab0d..556393498f 100644
> --- a/builtin/credential-cache--daemon.c
> +++ b/builtin/credential-cache--daemon.c
> @@ -138,6 +138,7 @@ static void serve_one_client(FILE *in, FILE *out)
>  		 * process actually ends, which closes the socket and gives
>  		 * them EOF.
>  		 */
> +		fclose(in);
>  		exit(0);
>  	}
>  	else if (!strcmp(action.buf, "erase"))

This is called by a function that will also close stdout, shouldn't we
be closing it here?

  reply	other threads:[~2022-07-07 13:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07  1:54 [RFC PATCH 1B] credential-cache--daemon: close input before exit-ing Ramsay Jones
2022-07-07 13:00 ` Ævar Arnfjörð Bjarmason [this message]
2022-07-07 15:35   ` Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=220707.86pmih847l.gmgdl@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=adam@dinwoodie.org \
    --cc=git@vger.kernel.org \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.