Re: [PATCH v3] examples/skeleton-cat: PQoS CAT and CDP, example of libpqos usage

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2016-03-07 16:54, Wojciech Andralojc:
> +M: Tomasz Kantecki <tomasz.kantecki@intel.com>
> +F: examples/skeleton-cat/
> +F: doc/guides/sample_app_ug/skeleton-cat.rst

Please keep the alphabetical order.

> +Basic Forwarding sample application is a simple *skeleton* example of
> +a forwarding application. It has been extended to make use of CAT via extended
> +command line options and linking against the libpqos library.

The skeleton aims to show a minimal piece of code (but bigger than hello world).
For any other usage, I think the "l2fwd" name is more appropriate.

> +DIRS-y += skeleton-cat

It cannot be enabled everytime, because of the dependency.
We already have this problem with examples/vm_power_manager
and libvirt dependency. It must be solved by improving the build system.

In this case, we can simply use the variable PQOS_LIBRARY_PATH to
enable the build.

[...]
> +# Default location of PQoS library and includes,
> +# can be overridden by command line or environment
> +PQOS_INSTALL_PATH ?= /usr/local/

This default value is useless because we should detect the dependency
before trying to compile.

[...]
> +LDLIBS += $(PQOS_LIBRARY_PATH) \

Why this backslash?