sg/parse-options-subcommand (was: What's cooking in git.git (Aug 2022, #07; Fri, 19))

["Ævar Arnfjörð Bjarmason" <avarab@gmail.com>]

On Fri, Aug 19 2022, Junio C Hamano wrote:

> * sg/parse-options-subcommand (2022-08-19) 20 commits
>  - builtin/worktree.c: let parse-options parse subcommands
>  - builtin/stash.c: let parse-options parse subcommands
>  - builtin/sparse-checkout.c: let parse-options parse subcommands
>  - builtin/remote.c: let parse-options parse subcommands
>  - builtin/reflog.c: let parse-options parse subcommands
>  - builtin/notes.c: let parse-options parse subcommands
>  - builtin/multi-pack-index.c: let parse-options parse subcommands
>  - builtin/hook.c: let parse-options parse subcommands
>  - builtin/gc.c: let parse-options parse 'git maintenance's subcommands
>  - builtin/commit-graph.c: let parse-options parse subcommands
>  - builtin/bundle.c: let parse-options parse subcommands
>  - parse-options: add support for parsing subcommands
>  - parse-options: drop leading space from '--git-completion-helper' output
>  - parse-options: clarify the limitations of PARSE_OPT_NODASH
>  - parse-options: PARSE_OPT_KEEP_UNKNOWN only applies to --options
>  - api-parse-options.txt: fix description of OPT_CMDMODE
>  - t0040-parse-options: test parse_options() with various 'parse_opt_flags'
>  - t5505-remote.sh: check the behavior without a subcommand
>  - t3301-notes.sh: check that default operation mode doesn't take arguments
>  - git.c: update NO_PARSEOPT markings
>
>  Introduce the "subcommand" mode to parse-options API and update the
>  command line parser of Git commands with subcommands.
>
>  Will merge to 'next'?
>  source: <20220819160411.1791200-1-szeder.dev@gmail.com>

I looked it over is detail this time around (and meant to for v1). I
think that all of what I mentioned in my review can be left for later,
except maybe the subtle change in "case" label fall-through pointed out
in [1], but it doesn't introduce any functional changes. So if SZEDER is
happy with it I'm fine with it.

1. https://lore.kernel.org/git/220819.86h7285a1o.gmgdl@evledraar.gmail.com/