From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: "Strawbridge, Michael" <Michael.Strawbridge@amd.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
"Tuikov, Luben" <Luben.Tuikov@amd.com>,
"brian m . carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH 2/2] Update sendemail-validate hook docs to add header file parameter
Date: Fri, 11 Nov 2022 16:10:29 +0100 [thread overview]
Message-ID: <221111.86sfipmsoe.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <20221111021502.449662-3-michael.strawbridge@amd.com>
On Fri, Nov 11 2022, Strawbridge, Michael wrote:
> Add documentation for the new smtp header file parameter used by the
> sendemail-validate git-send-email hook.
>
> sendemail-validate accepts the patch file as the first parameter (same as
> before) and now also adds the smtp header information as the second parameter.
>
> Cc: Luben Tuikov <luben.tuikov@amd.com>
> Cc: brian m. carlson <sandals@crustytoothpaste.net>
> Signed-off-by: Michael Strawbridge <michael.strawbridge@amd.com>
> ---
> Documentation/githooks.txt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt
> index a16e62bc8c..c1baf34454 100644
> --- a/Documentation/githooks.txt
> +++ b/Documentation/githooks.txt
> @@ -583,10 +583,10 @@ processed by rebase.
> sendemail-validate
> ~~~~~~~~~~~~~~~~~~
>
> -This hook is invoked by linkgit:git-send-email[1]. It takes a single parameter,
> -the name of the file that holds the e-mail to be sent. Exiting with a
> -non-zero status causes `git send-email` to abort before sending any
> -e-mails.
> +This hook is invoked by linkgit:git-send-email[1]. It takes two parameters,
> +the name of a file that holds the patch and the name of a file that holds the
> +smtp headers. Exiting with a non-zero status causes `git send-email` to abort
> +before sending any e-mails.
>
> fsmonitor-watchman
> ~~~~~~~~~~~~~~~~~~
As this is just documenting the change in 1/2 after-the-fact, we really
should squash it into that.
If you are doing another commit, the better thing to do would be to
first change the docs to say e.g.:
This hook is invoked by linkgit:git-send-email[1]. It's provided with
these parameters, in order:
* A file that holds the....
Then instead of your "actual" change being a reword change etc. you can
just add another bullet-point.
Or you could just squash this as-is...
next prev parent reply other threads:[~2022-11-11 15:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 2:15 [PATCH 0/2] Expose header information to git-send-email's sendemail-validate hook Strawbridge, Michael
2022-11-11 2:15 ` [PATCH 1/2] " Strawbridge, Michael
2022-11-11 2:15 ` [PATCH 2/2] Update sendemail-validate hook docs to add header file parameter Strawbridge, Michael
2022-11-11 15:10 ` Ævar Arnfjörð Bjarmason [this message]
2022-11-11 19:12 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=221111.86sfipmsoe.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=Luben.Tuikov@amd.com \
--cc=Michael.Strawbridge@amd.com \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.