From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t7610: use "file:///dev/null", not "/dev/null", fixes MinGW
Date: Thu, 17 Nov 2022 11:08:08 +0100 [thread overview]
Message-ID: <221117.86o7t5j3jd.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <Y3Q3xQeaXGPemcWv@nand.local>
On Tue, Nov 15 2022, Taylor Blau wrote:
> On Wed, Nov 16, 2022 at 12:40:14AM +0100, Ævar Arnfjörð Bjarmason wrote:
>> On MinGW the "/dev/null" is translated to "nul" on command-lines, even
>> though as in this case it'll never end up referring to an actual file.
>>
>> So on Windows the fix for the previous "example.com" timeout issue in
>> 8354cf752ec (t7610: fix flaky timeout issue, don't clone from
>> example.com, 2022-11-05) would yield:
>>
>> fatal: repo URL: 'nul' must be absolute or begin with ./|../
>>
>> Let's evade this yet again by prefixing this with "file://", which
>> makes this pass in the Windows CI.
>
> Thanks very much. I just picked this up on top of my 'ab/t7610-timeout'
> branch and pushed it out to ttaylorr/git to double-check your results
> against CI. (Not that I don't trust you, of course, but I'm feeling like
> I should be extra-cautious ;-)).
>
> Assuming that all looks good, then I'll push out a new version of 'next'
> and dependent branches to the usual spots so that we can get 'next' back
> to green.
>
> Thanks for working on this so quickly.
And thank for picking it up! Looks like "next" is passing CI now:
https://github.com/git/git/actions/runs/3475751137/jobs/5810308794
next prev parent reply other threads:[~2022-11-17 10:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-05 11:54 [PATCH] t7610: fix flaky timeout issue, don't clone from example.com Ævar Arnfjörð Bjarmason
2022-11-09 22:47 ` Taylor Blau
2022-11-09 23:55 ` Ævar Arnfjörð Bjarmason
2022-11-10 2:17 ` Taylor Blau
2022-11-15 19:42 ` Taylor Blau
2022-11-15 23:40 ` [PATCH] t7610: use "file:///dev/null", not "/dev/null", fixes MinGW Ævar Arnfjörð Bjarmason
2022-11-16 1:07 ` Taylor Blau
2022-11-17 10:08 ` Ævar Arnfjörð Bjarmason [this message]
2022-11-17 21:50 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=221117.86o7t5j3jd.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.