From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v3 25/32] drm/exynos: Clean up FIMD power on/off routines Date: Mon, 11 Nov 2013 03:09:53 +0100 Message-ID: <2211761.yYlRFPR9up@flatron> References: <1383063198-10526-1-git-send-email-seanpaul@chromium.org> <1383063198-10526-26-git-send-email-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f171.google.com (mail-ea0-f171.google.com [209.85.215.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 825F2FA47D for ; Sun, 10 Nov 2013 22:05:29 -0800 (PST) Received: by mail-ea0-f171.google.com with SMTP id h10so163849eak.30 for ; Sun, 10 Nov 2013 22:05:26 -0800 (PST) In-Reply-To: <1383063198-10526-26-git-send-email-seanpaul@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Sean Paul Cc: dri-devel@lists.freedesktop.org, marcheu@chromium.org List-Id: dri-devel@lists.freedesktop.org Hi Sean, On Tuesday 29 of October 2013 12:13:11 Sean Paul wrote: > This patch separates the fimd_activate function into poweron/poweroff > functions to be more consistent with the other drivers in exynos drm. It > also properly cleans up after failures in poweron. The functions have > also been shuffled around such that they are all in the same > spot in the file and poweron/poweroff can be called from the dpms function. > > Signed-off-by: Sean Paul > --- > > Changes in v2: > - Added to the patchset > Changes in v3: None > > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 247 +++++++++++++++++-------------- > 1 file changed, 135 insertions(+), 112 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz