From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: phillip.wood@dunelm.org.uk
Cc: git@vger.kernel.org, Phillip Wood <phillip.wood123@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] test-lib.sh: discover "git" in subdirs of "contrib/buildsystems/out"
Date: Thu, 01 Dec 2022 18:13:58 +0100 [thread overview]
Message-ID: <221201.86mt87gi50.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <9c6400ce-6f71-6f1c-dd7e-719c7181fe83@dunelm.org.uk>
On Thu, Dec 01 2022, Phillip Wood wrote:
> On 01/12/2022 16:39, Ævar Arnfjörð Bjarmason wrote:
>> Fix a regression in [1] and discover git built by cmake in subdirs of
>> "contrib/buildsystems/out", in addition to the "out" directory itself.
>
> How do you propose to find the most recent build? There are different
> directories for different architectures and different directories for
> debug and release builds.
I'm not proposing to do that, besides, if you built locally for
different architectures running the tests would just fail, wouldn't it?
> Hard coding the build directory is a bad idea and should be dropped.
I think it's a better idea to target the common case of a user building
& being able to run the tests form t/, rather than requiring
bootstrapping that process by running "ctest".
Did you test that case on v2.38.0 and/or master? I.e. is VS running that
ctest portion automatically?
next prev parent reply other threads:[~2022-12-01 17:15 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 9:40 What's cooking in git.git (Nov 2022, #07; Tue, 29) Junio C Hamano
2022-11-29 18:59 ` ab/remove--super-prefix and -rc0 (was What's cooking in git.git (Nov 2022, #07; Tue, 29)) Glen Choo
2022-11-30 3:43 ` Junio C Hamano
2022-11-30 18:14 ` Glen Choo
2022-11-30 19:43 ` Ævar Arnfjörð Bjarmason
2022-12-01 5:20 ` Junio C Hamano
2022-12-01 17:44 ` Glen Choo
2022-12-01 21:26 ` Junio C Hamano
2022-11-29 19:08 ` What's cooking in git.git (Nov 2022, #07; Tue, 29) Glen Choo
2022-11-30 3:45 ` Junio C Hamano
2022-11-30 18:08 ` Glen Choo
2022-11-29 21:16 ` ds/bundle-uri-4 (was Re: What's cooking in git.git (Nov 2022, #07; Tue, 29)) Derrick Stolee
2022-12-01 15:06 ` Derrick Stolee
2022-12-02 0:25 ` Junio C Hamano
2022-11-30 9:57 ` ab/cmake-nix-and-ci " Phillip Wood
2022-11-30 10:16 ` Ævar Arnfjörð Bjarmason
2022-12-01 14:23 ` Phillip Wood
2022-12-01 16:39 ` [PATCH] test-lib.sh: discover "git" in subdirs of "contrib/buildsystems/out" Ævar Arnfjörð Bjarmason
2022-12-01 16:48 ` Phillip Wood
2022-12-01 17:13 ` Ævar Arnfjörð Bjarmason [this message]
2022-12-01 23:00 ` Junio C Hamano
2022-12-02 15:14 ` Phillip Wood
2022-12-02 16:40 ` Ævar Arnfjörð Bjarmason
2022-12-02 23:10 ` Jeff King
2022-12-03 1:12 ` Junio C Hamano
2022-12-03 1:41 ` Ævar Arnfjörð Bjarmason
2022-12-05 9:15 ` Jeff King
2022-12-05 23:34 ` Taylor Blau
2022-12-05 23:46 ` Ævar Arnfjörð Bjarmason
2022-12-06 0:35 ` Taylor Blau
2022-12-06 1:36 ` Jeff King
2022-12-06 1:43 ` Ævar Arnfjörð Bjarmason
2022-12-06 2:05 ` Jeff King
2022-12-06 2:19 ` Ævar Arnfjörð Bjarmason
2022-12-06 3:52 ` Junio C Hamano
2022-12-06 9:54 ` Phillip Wood
2022-12-06 10:57 ` Ævar Arnfjörð Bjarmason
2022-12-08 9:29 ` ab/cmake-nix-and-ci, was " Johannes Schindelin
2022-12-08 11:34 ` Ævar Arnfjörð Bjarmason
2022-12-09 3:48 ` Junio C Hamano
2022-12-09 13:55 ` Ævar Arnfjörð Bjarmason
2022-12-07 1:00 ` Taylor Blau
2022-11-30 10:02 ` What's cooking in git.git (Nov 2022, #07; Tue, 29) Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=221201.86mt87gi50.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=phillip.wood123@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.