From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12560CDB482 for ; Tue, 17 Oct 2023 14:02:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9cafqmF5aCq7HXnA9ymbQQvi/It2f8lbHvX5fFde4Bs=; b=jitsocCbLATEuW vrxlgb3ZU+RgU2J62V2pvxRvimCrS5ao9lzovjmdteJptO/saqUuNPoAf/caoPMQ3NtaBwXf6dXK9 tOk0+DcB+InSqiPPnYN6xpU554lW+Mvw44/zvHR2YjhJtkXsDSQcAjDbF1g39K7AHbUb7oz4YQugt Ca//50vJrCAblU2TLA5MJUL4PJF4euiiqYM0WeNBn2TmKWidQctccKzdpxKG5wiUzXbmWobIGP9Nv X/wOyKPVLiAYN07MhTEOKcgjwkIT2hQxBSKv9DWDFVwYxIZbQWH5k7qe3PfxxDdGzKOywBHMoP4rp WFBVm8cd2sGwUL6+PtBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qskeE-00CTwl-1a; Tue, 17 Oct 2023 14:02:14 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qskeA-00CTvL-1k for linux-arm-kernel@lists.infradead.org; Tue, 17 Oct 2023 14:02:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1697551330; x=1729087330; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jANLk1Fnic8hXh7J6ape/eAxnsf8qTgjV0Zfaqe390w=; b=OAzxZG3EzLlUe/nZ8WwyY760l7RoAC3ShpkYCxZWeFEnhgFcK1q+AoHI je7++6piGLHBTmomZXXw/WtkmXgmslpe5Jf/hqezPakpktSVK803j2sDx 7y72ds6oW16yYbDbAUy1uXXHH//MQIAMddx/yppba9CBWJNUCNQzXSmAp ewh2Lxz7mxBgGghErsL6qpJS66e0CUE//h9WV3HJMasndR80Gqeakjx4R hDdfmDy3DZLEEMKQ5jhFSIe9AN2f73BX4GHauSQKckxjy5ZewK1OQ4399 9rfiNhYWHWQUF2rnjnatE4GomZnB5oLfQjmKa3rOV3/IzojaqApl3OX0k A==; X-IronPort-AV: E=Sophos;i="6.03,232,1694728800"; d="scan'208";a="33509080" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 17 Oct 2023 16:02:08 +0200 Received: from steina-w.localnet (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id BC0BB280082; Tue, 17 Oct 2023 16:02:07 +0200 (CEST) From: Alexander Stein To: Jacky Bai , "lgirdwood@gmail.com" , "broonie@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" , Joy Zou Cc: "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1 2/3] regulator: pca9450: add pca9451a support Date: Tue, 17 Oct 2023 16:02:09 +0200 Message-ID: <2213718.72vocr9iq0@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <20230531065724.3671795-1-joy.zou@nxp.com> <4630917.iIbC2pHGDl@steina-w> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231017_070210_997339_F8BA3415 X-CRM114-Status: GOOD ( 48.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpBbSBEaWVuc3RhZywgMS4gQXVndXN0IDIwMjMsIDEyOjE3OjIwIENFU1Qgc2NocmllYiBK b3kgWm91Ogo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZyb206IEFsZXhhbmRl ciBTdGVpbgo+ID4gPGFsZXhhbmRlci5zdGVpbkBldy50cS1ncm91cC5jb208bWFpbHRvOmFsZXhh bmRlci5zdGVpbkBldy50cS1ncm91cC5jb20+Pgo+ID4gCiBTZW50OiAyMDIz5bm0N+aciDXml6Ug MjE6MTMKPiA+IFRvOiBKYWNreSBCYWkgPHBpbmcuYmFpQG54cC5jb208bWFpbHRvOnBpbmcuYmFp QG54cC5jb20+PjsKPiA+IGxnaXJkd29vZEBnbWFpbC5jb208bWFpbHRvOmxnaXJkd29vZEBnbWFp bC5jb20+Owo+ID4gYnJvb25pZUBrZXJuZWwub3JnPG1haWx0bzpicm9vbmllQGtlcm5lbC5vcmc+ Owo+ID4gcm9iaCtkdEBrZXJuZWwub3JnPG1haWx0bzpyb2JoK2R0QGtlcm5lbC5vcmc+Owo+ID4g a3J6eXN6dG9mLmtvemxvd3NraStkdEBsaW5hcm8ub3JnPG1haWx0bzprcnp5c3p0b2Yua296bG93 c2tpK2R0QGxpbmFyby5vcgo+ID4gZz47IGNvbm9yK2R0QGtlcm5lbC5vcmc8bWFpbHRvOmNvbm9y K2R0QGtlcm5lbC5vcmc+Owo+ID4gc2hhd25ndW9Aa2VybmVsLm9yZzxtYWlsdG86c2hhd25ndW9A a2VybmVsLm9yZz47Cj4gPiBzLmhhdWVyQHBlbmd1dHJvbml4LmRlPG1haWx0bzpzLmhhdWVyQHBl bmd1dHJvbml4LmRlPjsKPiA+IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZzxt YWlsdG86bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWQKPiA+IGVhZC5vcmc+OyBKb3kgWm91 IDxqb3kuem91QG54cC5jb208bWFpbHRvOmpveS56b3VAbnhwLmNvbT4+IENjOgo+ID4ga2VybmVs QHBlbmd1dHJvbml4LmRlPG1haWx0bzprZXJuZWxAcGVuZ3V0cm9uaXguZGU+Owo+ID4gZmVzdGV2 YW1AZ21haWwuY29tPG1haWx0bzpmZXN0ZXZhbUBnbWFpbC5jb20+OyBkbC1saW51eC1pbXgKPiA+ IDxsaW51eC1pbXhAbnhwLmNvbTxtYWlsdG86bGludXgtaW14QG54cC5jb20+PjsKPiA+IGRldmlj ZXRyZWVAdmdlci5rZXJuZWwub3JnPG1haWx0bzpkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZz47 Cj4gPiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc8bWFpbHRvOmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkCj4gPiBlYWQub3JnPjsKPiA+IGxpbnV4LWtlcm5lbEB2Z2Vy Lmtlcm5lbC5vcmc8bWFpbHRvOmxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+Cj4gPiBTdWJq ZWN0OiBbRVhUXSBSZTogW1BBVENIIHYxIDIvM10gcmVndWxhdG9yOiBwY2E5NDUwOiBhZGQgcGNh OTQ1MWEKPiA+IHN1cHBvcnQ+Cj4gPgo+ID4KPiA+IENhdXRpb246IFRoaXMgaXMgYW4gZXh0ZXJu YWwgZW1haWwuIFBsZWFzZSB0YWtlIGNhcmUgd2hlbiBjbGlja2luZyBsaW5rcwo+ID4gb3IKIG9w ZW5pbmcgYXR0YWNobWVudHMuIFdoZW4gaW4gZG91YnQsIHJlcG9ydCB0aGUgbWVzc2FnZSB1c2lu ZyB0aGUKPiA+ICdSZXBvcnQgdGhpcyBlbWFpbCcgYnV0dG9uCj4gPgo+ID4KPiA+Cj4gPgo+ID4g SGVsbG8sCj4gPgo+ID4KPiA+Cj4gPiBBbSBNaXR0d29jaCwgNS4gSnVsaSAyMDIzLCAwODo1MDoy NCBDRVNUIHNjaHJpZWIgSm95IFpvdToKPiA+IAo+ID4gPgo+ID4gPgo+ID4gPiA+IC0tLS0tT3Jp Z2luYWwgTWVzc2FnZS0tLS0tCj4gPiA+ID4gRnJvbTogQWxleGFuZGVyIFN0ZWluCj4gPiA+ID4g PGFsZXhhbmRlci5zdGVpbkBldy50cS1ncm91cC5jb208bWFpbHRvOmFsZXhhbmRlci5zdGVpbkBl dy50cS1ncm91cC5jCj4gPiA+ID4gb20+PgogU2VudDogMjAyM+W5tDXmnIgzMeaXpSAxOTozNQo+ ID4gPiA+IFRvOiBKYWNreSBCYWkgPHBpbmcuYmFpQG54cC5jb208bWFpbHRvOnBpbmcuYmFpQG54 cC5jb20+PjsKPiA+ID4gPiBsZ2lyZHdvb2RAZ21haWwuY29tPG1haWx0bzpsZ2lyZHdvb2RAZ21h aWwuY29tPjsKPiA+ID4gPiBicm9vbmllQGtlcm5lbC5vcmc8bWFpbHRvOmJyb29uaWVAa2VybmVs Lm9yZz47Cj4gPiA+ID4gcm9iaCtkdEBrZXJuZWwub3JnPG1haWx0bzpyb2JoK2R0QGtlcm5lbC5v cmc+Owo+ID4gPiA+IGtyenlzenRvZi5rb3psb3dza2krZHRAbGluYXJvLm9yZzxtYWlsdG86a3J6 eXN6dG9mLmtvemxvd3NraStkdEBsaW5hcgo+ID4gPiA+IG8ub3JnPjsgY29ub3IrZHRAa2VybmVs Lm9yZzxtYWlsdG86Y29ub3IrZHRAa2VybmVsLm9yZz47Cj4gPiA+ID4gc2hhd25ndW9Aa2VybmVs Lm9yZzxtYWlsdG86c2hhd25ndW9Aa2VybmVsLm9yZz47Cj4gPiA+ID4gcy5oYXVlckBwZW5ndXRy b25peC5kZTxtYWlsdG86cy5oYXVlckBwZW5ndXRyb25peC5kZT47Cj4gPiA+ID4gbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnPG1haWx0bzpsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluCj4gPiA+ID4gZnJhZGVhZC5vcmc+IENjOiBrZXJuZWxAcGVuZ3V0cm9uaXguZGU8bWFpbHRv Omtlcm5lbEBwZW5ndXRyb25peC5kZT47Cj4gPiA+ID4gZmVzdGV2YW1AZ21haWwuY29tPG1haWx0 bzpmZXN0ZXZhbUBnbWFpbC5jb20+OyBkbC1saW51eC1pbXgKPiA+ID4gPiA8bGludXgtaW14QG54 cC5jb208bWFpbHRvOmxpbnV4LWlteEBueHAuY29tPj47Cj4gPiA+ID4gZGV2aWNldHJlZUB2Z2Vy Lmtlcm5lbC5vcmc8bWFpbHRvOmRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnPjsKPiA+ID4gPiBs aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc8bWFpbHRvOmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW4KPiA+ID4gPiBmcmFkZWFkLm9yZz47Cj4gPiA+ID4gbGludXgta2VybmVsQHZn ZXIua2VybmVsLm9yZzxtYWlsdG86bGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZz47Cj4gPiA+ ID4gSm95IFpvdQo+ID4gIAo+ID4gIDxqb3kuem91QG54cC5jb208bWFpbHRvOmpveS56b3VAbnhw LmNvbT4+Cj4gPiAgCj4gPiA+ID4gU3ViamVjdDogUmU6IFtQQVRDSCB2MSAyLzNdIHJlZ3VsYXRv cjogcGNhOTQ1MDogYWRkIHBjYTk0NTFhCj4gPiA+ID4gc3VwcG9ydAo+ID4gPiA+Cj4gPiA+ID4K PiA+ID4gPgo+ID4gPiA+IEhpLAo+ID4gPiA+IAo+ID4gPiA+ID4gQEAgLTEwNCw3ICsxMDQsMTUg QEAgc3RhdGljIGNvbnN0IHN0cnVjdCByZWd1bGF0b3Jfb3BzCj4gPiA+ID4gPiBwY2E5NDUwX2xk b19yZWd1bGF0b3Jfb3BzID0geyAqIDAuNjAgdG8gMi4xODc1ViAoMTIuNW1WIHN0ZXApCj4gPiA+ ID4gPgo+ID4gPiA+ID4KPiA+ID4gPiA+Cj4gPiA+ID4gPiAgICovCj4gPiA+ID4gPgo+ID4gPiA+ ID4KPiA+ID4gPiA+Cj4gPiA+ID4gPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBsaW5lYXJfcmFuZ2Ug cGNhOTQ1MF9kdnNfYnVja192b2x0c1tdID0gewo+ID4gPiA+ID4KPiA+ID4gPiA+Cj4gPiA+ID4g Pgo+ID4gPiA+ID4gLSAgICAgUkVHVUxBVE9SX0xJTkVBUl9SQU5HRSg2MDAwMDAsICAweDAwLCAw eDdGLCAxMjUwMCksCj4gPiA+ID4gPiArICAgICBSRUdVTEFUT1JfTElORUFSX1JBTkdFKDYwMDAw MCwgMHgwMCwgMHg3RiwgMTI1MDApLCB9Owo+ID4gPiA+ID4gKwo+ID4gPiA+ID4gKy8qCj4gPiA+ ID4gPiArICogQlVDSzEvMwo+ID4gPiA+ID4gKyAqIDAuNjUgdG8gMi4yMzc1ViAoMTIuNW1WIHN0 ZXApCj4gPiA+ID4KPiA+ID4gPgo+ID4gPiA+Cj4gPiA+ID4KPiA+ID4gPgo+ID4gPiA+IFJlYWRp bmcgdGhpcyBjb21tZW50LCBpdCBzZWVtcyB0aGUgc2FtZSBkaXN0aW5jdGlvbiBuZWVkcyB0byBi ZSBkb25lCj4gPiA+ID4gZm9yCj4gPiA+ID4gQlVDSzMgYXMgd2VsbCwgbm8/Cj4gPiA+Cj4gPiA+ Cj4gPiA+Cj4gPiA+IFNvcnJ5IGZvciB0aGUgbGF0ZSByZXBseSEKPiA+ID4gVGhlIEJVQ0sxIGFu ZCBCVUNLMyBhcmUgZHVhbCBwaGFzZSwgc28gZG9uJ3QgbmVlZCB0byBiZSBkb25lIGZvciBCVUNL My4KPiA+ID4KPiA+ID4KPiA+ID4KPiA+ID4gPgo+ID4gPiA+Cj4gPiA+ID4KPiA+ID4gPiA+ICsg Ki8KPiA+ID4gPiA+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGxpbmVhcl9yYW5nZSBwY2E5NDUwX3Ry aW1fZHZzX2J1Y2tfdm9sdHNbXSA9IHsKPiA+ID4gPiA+ICsgICAgIFJFR1VMQVRPUl9MSU5FQVJf UkFOR0UoNjUwMDAwLCAweDAwLCAweDdGLCAxMjUwMCksCj4gPiA+ID4gPgo+ID4gPiA+ID4KPiA+ ID4gPiA+Cj4gPiA+ID4gPiAgfTsKPiAKPiAKPiAKPiA+ID4gPiA+IEBAIC03MDgsOCArOTE3LDkg QEAgc3RhdGljIGludCBwY2E5NDUwX2kyY19wcm9iZShzdHJ1Y3QgaTJjX2NsaWVudAo+ID4gPiA+ ID4gKmkyYykKPiA+ID4gPiA+Cj4gPiA+ID4gPgo+ID4gPiA+ID4KPiA+ID4gPiA+ICAgICAgIGNv bnN0IHN0cnVjdCBwY2E5NDUwX3JlZ3VsYXRvcl9kZXNjICAgICAqcmVndWxhdG9yX2Rlc2M7Cj4g PiA+ID4gPiAgICAgICBzdHJ1Y3QgcmVndWxhdG9yX2NvbmZpZyBjb25maWcgPSB7IH07Cj4gPiA+ ID4gPiAgICAgICBzdHJ1Y3QgcGNhOTQ1MCAqcGNhOTQ1MDsKPiA+ID4gPiA+Cj4gPiA+ID4gPgo+ ID4gPiA+ID4KPiA+ID4gPiA+IC0gICAgIHVuc2lnbmVkIGludCBkZXZpY2VfaWQsIGk7Cj4gPiA+ ID4gPiArICAgICB1bnNpZ25lZCBpbnQgZGV2aWNlX2lkLCBpLCB2YWw7Cj4gPiA+ID4gPgo+ID4g PiA+ID4KPiA+ID4gPiA+Cj4gPiA+ID4gPiAgICAgICB1bnNpZ25lZCBpbnQgcmVzZXRfY3RybDsK PiA+ID4gPiA+Cj4gPiA+ID4gPgo+ID4gPiA+ID4KPiA+ID4gPiA+ICsgICAgIGJvb2wgcG1pY190 cmltID0gZmFsc2U7Cj4gPiA+ID4gPgo+ID4gPiA+ID4KPiA+ID4gPiA+Cj4gPiA+ID4gPiAgICAg ICBpbnQgcmV0Owo+ID4gPiA+ID4KPiA+ID4gPiA+Cj4gPiA+ID4gPgo+ID4gPiA+ID4KPiA+ID4g PiA+Cj4gPiA+ID4gPiAgICAgICBpZiAoIWkyYy0+aXJxKSB7Cj4gPiA+ID4gPgo+ID4gPiA+ID4K PiA+ID4gPiA+Cj4gPiA+ID4gPiBAQCAtNzIxLDYgKzkzMSwyMiBAQCBzdGF0aWMgaW50IHBjYTk0 NTBfaTJjX3Byb2JlKHN0cnVjdAo+ID4gPiA+ID4gaTJjX2NsaWVudAo+ID4gPiA+ID4gKmkyYykK PiA+ID4gPiA+Cj4gPiA+ID4gPgo+ID4gPiA+ID4KPiA+ID4gPiA+ICAgICAgIGlmICghcGNhOTQ1 MCkKPiA+ID4gPiA+Cj4gPiA+ID4gPgo+ID4gPiA+ID4KPiA+ID4gPiA+ICAgICAgICAgICAgICAg cmV0dXJuIC1FTk9NRU07Cj4gPiA+ID4gPgo+ID4gPiA+ID4KPiA+ID4gPiA+Cj4gPiA+ID4gPgo+ ID4gPiA+ID4KPiA+ID4gPiA+ICsgICAgIHBjYTk0NTAtPnJlZ21hcCA9IGRldm1fcmVnbWFwX2lu aXRfaTJjKGkyYywKPiA+ID4gPiA+ICsKPiA+ID4gPgo+ID4gPiA+Cj4gPiA+ID4KPiA+ID4gPiAm cGNhOTQ1MF9yZWdtYXBfY29uZmlnKTsKPiA+ID4gPgo+ID4gPiA+Cj4gPiA+ID4KPiA+ID4gPiA+ ICsgICAgIGlmIChJU19FUlIocGNhOTQ1MC0+cmVnbWFwKSkgewo+ID4gPiA+ID4gKyAgICAgICAg ICAgICBkZXZfZXJyKCZpMmMtPmRldiwgInJlZ21hcCBpbml0aWFsaXphdGlvbiBmYWlsZWRcbiIp Owo+ID4gPiA+ID4gKyAgICAgICAgICAgICByZXR1cm4gUFRSX0VSUihwY2E5NDUwLT5yZWdtYXAp Owo+ID4gPiA+ID4gKyAgICAgfQo+ID4gPiA+ID4gKwo+ID4gPiA+ID4gKyAgICAgcmV0ID0gcmVn bWFwX3JlYWQocGNhOTQ1MC0+cmVnbWFwLCBQQ0E5NDUwX1JFR19QV1JDVFJMLAo+ID4gPiA+Cj4g PiA+ID4KPiA+ID4gPgo+ID4gPiA+ICZ2YWwpOwo+ID4gPiA+Cj4gPiA+ID4KPiA+ID4gPgo+ID4g PiA+ID4gKyAgICAgaWYgKHJldCkgewo+ID4gPiA+ID4gKyAgICAgICAgICAgICBkZXZfZXJyKCZp MmMtPmRldiwgIlJlYWQgZGV2aWNlIGlkIGVycm9yXG4iKTsKPiA+ID4gPiA+ICsgICAgICAgICAg ICAgcmV0dXJuIHJldDsKPiA+ID4gPiA+ICsgICAgIH0KPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICsg ICAgIGlmICh2YWwgJiBQQ0E5NDUwX1JFR19QV1JDVFJMX1RPRkZfREVCKQo+ID4gPiA+ID4gKyAg ICAgICAgICAgICBwbWljX3RyaW0gPSB0cnVlOwo+ID4gPiA+Cj4gPiA+ID4KPiA+ID4gPgo+ID4g PiA+Cj4gPiA+ID4KPiA+ID4gPiBQQ0E5NDUwX1JFR19QV1JDVFJMIGlzIGEgcmVhZC93cml0ZSBy ZWdpc3Rlci4gSG93IGlzIGl0IHBvc3NpYmxlIHRvCj4gPiA+ID4gZGV0ZWN0IGEgY2hpcCByZXZp c2lvbiB1c2luZyBhIGJpdCB3aGljaCBjYW4gYmUgY2hhbmdlZCBieSBzb2Z0d2FyZQo+ID4gPiA+ IGUuZy4KPiA+ID4gPiBib290bG9hZGVyPyBEZXNwaXRlIHRoYXQgdGhpcyBiaXQgc2V0cyBkZWJv dW5jZSB0aW1lIGZvcgo+ID4gPiA+IFBNSUNfT05fUkVRLCBob3cgaXMgdGhpcyByZWxhdGVkIHRv IEJVQ0sxIHZvbHRhZ2UgcmFuZ2U/Cj4gPiA+Cj4gPiA+Cj4gPiA+Cj4gPiA+IFRoZXJlIGFyZSBv bGQgYW5kIG5ldyB0d28ga2luZCBQTUlDIHBjYTk0NTFhLgo+ID4KPiA+Cj4gPgo+ID4gVGhlcmUg aXMgb25seSBvbmUgcGFydCBtZW50aW9uZWQgaW4gdGhlIG9yZGVyaW5nIG9wdGlvbnMuIEhvdyBj YW4gSQo+ID4gZGlzdGluZ3Vpc2ggdGhlbT8gQW55IGNoaXAgSUQsIGRhdGUgY29kZXMsIG1hcmtp bmdzPwo+IAo+IFllcywgdGhlcmUgaXMgb25seSBvbmUgcGFydC4gV2UgZGlzdGluZ3Vpc2ggdGhl IG5ldyBhbmQgb2xkIHBhcnQgYnkgdGhpcwo+IGJpdAogVG9mZl9EZWIgb2YgUENBOTQ1MF9SRUdf UFdSQ1RSTCByZXNldCB2YWx1ZS4gVGhlIHJlc2V0IHZhbHVlIDAgbWVhbnMKPiBpdCdzIG9sZCBw YXJ0LCBhbmQgdGhlIHJlc2V0IHZhbHVlIDEgbWVhbnMgaXQncyBuZXcgcGFydC4KCklzIHRoZSAi b2xkIiBwYXJ0IGJ5IGNvaW5jaWRlbmNlIGFuIHVub2ZmaWNpYWwgcHJlcmVsZWFzZS9zYW1wbGUg Y2hpcD8KCj4gPgo+ID4KPiA+ID4gVGhpcyBiaXQgc2V0cyBkZWJvdW5jZSB0aW1lIGluCj4gPiA+ IFBDQTk0NTBfUkVHX1BXUkNUUkwgd2FzIHNldCBkaWZmZXJlbnQgdmFsdWUgYnkgaGFyZHdhcmUg aW4gb3JkZXIgdG8KPiA+ID4gb25seSBkaXN0aW5ndWlzaCB0aGUgb2xkIGFuZCBuZXcgUE1JQy4g VGhpcyBiaXQgaXNuJ3QgcmVsYXRlZCB0byB0aGUKPiA+ID4gQlVDSzEgdm9sdGFnZSByYW5nZS4g SWYgdGhlIHBtaWNfdHJpbSBpcyB0cnVlIHRoYXQgbWVhbnMgaXQncyBuZXcKPiA+ID4gcGNhOTQ1 MWEuCj4KPiA+Cj4gPgo+ID4gQnV0IHRoaXMgYml0IGlzIHdyaXRhYmxlLiBIb3cgZG8geW91IGtu b3cgaXQgaGFzIG5vdCBiZWVuIG1vZGlmaWVkIHNpbmNlCj4gPiByZXNldD8KPiBZZXMsIHdlIGRv bid0IGNvbnNpZGVyIG1vZGlmeSB0aGUgZGVib3VuY2UgYml0IGNhc2UuIE1vZGlmeSB0aGUgVG9m Zl9kZWIKPiB2YWx1ZQogd2lsbCBpbmZsdWVuY2UgdGhlIG9sZCBhbmQgbmV3IHBhcnQganVkZ2Vt ZW50LgoKVGhpcyBqdWRnZW1lbnQgc2VlbXMgYnJva2VuIHRvIG1lLiBIb3cgY2FuIEkga25vdyBv ZmZsaW5lIHdoZXRoZXIgSSBoYXZlIG9sZCAKb3IgbmV3IHBhcnRzPyBJIHdvdWxkIGxpa2UgdG8g a25vdyBpZiB0aGVyZSBpcyBhIGRpZmZlcmVuY2Ugb24gc29tZSBteSBib2FyZHMuCgo+IEZvciBl eGFtcGxlLCB0aGlzIGRlZmF1bHQgdmFsdWUgb2YgVG9mZl9kZWIgaXMgMSBpbiB0aGUgbmV3IHBh cnQsIGlmIHRoZQo+IGN1c3RvbWVycwogY2hhbmdlIHRoZSBUb2ZmX2RlYiB2YWx1ZSBmcm9tIDEg dG8gMCwgYW5kIHRoZW4gbWFrZSB0aGUgYm9hcmQKPiB3YXJtIHJlc2V0LCB0aGUgVG9mZl9kZWIg dmFsdWUgc3RpbGwga2VlcCAwLCBpZiB0aGUgVG9mZl9kZWIgdmFsdWUgaXMgMCwKPiB0aGUgUE1J QyBkcml2ZXIgd2lsbCB0aGluayB0aGlzIHBhcnQgaXMgb2xkIHBhcnQuIEJ1dCB0aGlzIHBhcnQg aXMgbmV3IHBhcnQKPiBpbiBmYWN0LgoKVGhpcyBzaG91bGQgc2hvdyB5b3UgaXQncyBhIGJhZCBp ZGVhIHRvIGRlY2lkZSB0aGUgY2hpcCByZXZpc2lvbiBkZXBlbmRpbmcgb24gClRvZmZfZGViLgoK PiBIYXZlIGRpc2N1c3NlZCB0aGlzIGlzc3VlIHdpdGggb3VyIGludGVybmFsIHRlYW0gbWVtYmVy LCB3ZSB3aWxsIGFkZCBhIG5vdGUKPiB0byBQQ0E5NDUxCiBkYXRhc2hlZXQg4oCTIOKAnFBsZWFz ZSBjb250cmFjdCBOWFAgSWYgeW91IHdhbnQgdG8gY2hhbmdlCj4gVG9mZl9kZWIu4oCdIEJ1dCB0 aWxsIG5vdywgd2UgYW0gbm90IGF3YXJlIGFueSBjdXN0b21lcnMgY2FzZSB3aGljaCBuZWVkIHRv Cj4gYWRqdXN0IFRvZmZfZGViLgo+IAo+IE1ha2UgaXQgbW9yZSBjbGVhcjogSWYgY3VzdG9tZXJz IGRvIG5lZWQgdG8gbWFudWFsbHkgYWRqdXN0IFRvZmZfZGViLCBJdAo+IG5lZWQgUE1JQyBkcml2 ZXIKIHVwZGF0ZSB0byBieXBhc3MgdGhpcyBiaXQgY2hlY2sgYW5kIGRpcmVjdGx5IGFwcGx5Cj4g Y29ycmVzcG9uZGluZyB2b2x0YWdlIGNvbmZpZyB0YWJsZSBvbGQgb3IgbmV3LiBUaGFuayB5b3Ug dmVyeSBtdWNoIGZvciB5b3VyCj4gY29tbWVudHMgYW5kIGVmZm9ydHMuCgpJbiB0aGlzIGNhc2Ug SSBuZWVkIHRvIGtub3cgaWYgSSB1c2Ugb2xkLCBuZXcgb3IgYm90aCByZXZpc2lvbiBvZiB0aGVz ZSBwYXJ0cy4KCkJlc3QgcmVnYXJkcywKQWxleGFuZGVyCi0tIApUUS1TeXN0ZW1zIEdtYkggfCBN w7xobHN0cmHDn2UgMiwgR3V0IERlbGxpbmcgfCA4MjIyOSBTZWVmZWxkLCBHZXJtYW55CkFtdHNn ZXJpY2h0IE3DvG5jaGVuLCBIUkIgMTA1MDE4Ckdlc2Now6RmdHNmw7xocmVyOiBEZXRsZWYgU2No bmVpZGVyLCBSw7xkaWdlciBTdGFobCwgU3RlZmFuIFNjaG5laWRlcgpodHRwOi8vd3d3LnRxLWdy b3VwLmNvbS8KCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96008881F for ; Tue, 17 Oct 2023 14:02:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b="OAzxZG3E" Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15810102; Tue, 17 Oct 2023 07:02:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1697551330; x=1729087330; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jANLk1Fnic8hXh7J6ape/eAxnsf8qTgjV0Zfaqe390w=; b=OAzxZG3EzLlUe/nZ8WwyY760l7RoAC3ShpkYCxZWeFEnhgFcK1q+AoHI je7++6piGLHBTmomZXXw/WtkmXgmslpe5Jf/hqezPakpktSVK803j2sDx 7y72ds6oW16yYbDbAUy1uXXHH//MQIAMddx/yppba9CBWJNUCNQzXSmAp ewh2Lxz7mxBgGghErsL6qpJS66e0CUE//h9WV3HJMasndR80Gqeakjx4R hDdfmDy3DZLEEMKQ5jhFSIe9AN2f73BX4GHauSQKckxjy5ZewK1OQ4399 9rfiNhYWHWQUF2rnjnatE4GomZnB5oLfQjmKa3rOV3/IzojaqApl3OX0k A==; X-IronPort-AV: E=Sophos;i="6.03,232,1694728800"; d="scan'208";a="33509080" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 17 Oct 2023 16:02:08 +0200 Received: from steina-w.localnet (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id BC0BB280082; Tue, 17 Oct 2023 16:02:07 +0200 (CEST) From: Alexander Stein To: Jacky Bai , "lgirdwood@gmail.com" , "broonie@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" , Joy Zou Cc: "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1 2/3] regulator: pca9450: add pca9451a support Date: Tue, 17 Oct 2023 16:02:09 +0200 Message-ID: <2213718.72vocr9iq0@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <20230531065724.3671795-1-joy.zou@nxp.com> <4630917.iIbC2pHGDl@steina-w> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Hi, Am Dienstag, 1. August 2023, 12:17:20 CEST schrieb Joy Zou: > > -----Original Message----- > > From: Alexander Stein > > > > >=20 Sent: 2023=E5=B9=B47=E6=9C=885=E6=97=A5 21:13 > > To: Jacky Bai >; > > lgirdwood@gmail.com; > > broonie@kernel.org; > > robh+dt@kernel.org; > > krzysztof.kozlowski+dt@linaro.org > g>; conor+dt@kernel.org; > > shawnguo@kernel.org; > > s.hauer@pengutronix.de; > > linux-arm-kernel@lists.infradead.org > ead.org>; Joy Zou > Cc: > > kernel@pengutronix.de; > > festevam@gmail.com; dl-linux-imx > > >; > > devicetree@vger.kernel.org; > > linux-arm-kernel@lists.infradead.org > ead.org>; > > linux-kernel@vger.kernel.org > > Subject: [EXT] Re: [PATCH v1 2/3] regulator: pca9450: add pca9451a > > support> > > > > > > Caution: This is an external email. Please take care when clicking links > > or opening attachments. When in doubt, report the message using the > > 'Report this email' button > > > > > > > > > > Hello, > > > > > > > > Am Mittwoch, 5. Juli 2023, 08:50:24 CEST schrieb Joy Zou: > >=20 > > > > > > > > > > -----Original Message----- > > > > From: Alexander Stein > > > > > > > om>> Sent: 2023=E5=B9=B45=E6=9C=8831=E6=97=A5 19:35 > > > > To: Jacky Bai >; > > > > lgirdwood@gmail.com; > > > > broonie@kernel.org; > > > > robh+dt@kernel.org; > > > > krzysztof.kozlowski+dt@linaro.org > > > o.org>; conor+dt@kernel.org; > > > > shawnguo@kernel.org; > > > > s.hauer@pengutronix.de; > > > > linux-arm-kernel@lists.infradead.org > > > fradead.org> Cc: kernel@pengutronix.de; > > > > festevam@gmail.com; dl-linux-imx > > > > >; > > > > devicetree@vger.kernel.org; > > > > linux-arm-kernel@lists.infradead.org > > > fradead.org>; > > > > linux-kernel@vger.kernel.org; > > > > Joy Zou > > =20 > > > > > =20 > > > > Subject: Re: [PATCH v1 2/3] regulator: pca9450: add pca9451a > > > > support > > > > > > > > > > > > > > > > Hi, > > > >=20 > > > > > @@ -104,7 +104,15 @@ static const struct regulator_ops > > > > > pca9450_ldo_regulator_ops =3D { * 0.60 to 2.1875V (12.5mV step) > > > > > > > > > > > > > > > > > > > > */ > > > > > > > > > > > > > > > > > > > > static const struct linear_range pca9450_dvs_buck_volts[] =3D { > > > > > > > > > > > > > > > > > > > > - REGULATOR_LINEAR_RANGE(600000, 0x00, 0x7F, 12500), > > > > > + REGULATOR_LINEAR_RANGE(600000, 0x00, 0x7F, 12500), }; > > > > > + > > > > > +/* > > > > > + * BUCK1/3 > > > > > + * 0.65 to 2.2375V (12.5mV step) > > > > > > > > > > > > > > > > > > > > > > > > Reading this comment, it seems the same distinction needs to be done > > > > for > > > > BUCK3 as well, no? > > > > > > > > > > > > Sorry for the late reply! > > > The BUCK1 and BUCK3 are dual phase, so don't need to be done for BUCK= 3. > > > > > > > > > > > > > > > > > > > > > > > > > > + */ > > > > > +static const struct linear_range pca9450_trim_dvs_buck_volts[] = =3D { > > > > > + REGULATOR_LINEAR_RANGE(650000, 0x00, 0x7F, 12500), > > > > > > > > > > > > > > > > > > > > }; >=20 >=20 >=20 > > > > > @@ -708,8 +917,9 @@ static int pca9450_i2c_probe(struct i2c_client > > > > > *i2c) > > > > > > > > > > > > > > > > > > > > const struct pca9450_regulator_desc *regulator_desc; > > > > > struct regulator_config config =3D { }; > > > > > struct pca9450 *pca9450; > > > > > > > > > > > > > > > > > > > > - unsigned int device_id, i; > > > > > + unsigned int device_id, i, val; > > > > > > > > > > > > > > > > > > > > unsigned int reset_ctrl; > > > > > > > > > > > > > > > > > > > > + bool pmic_trim =3D false; > > > > > > > > > > > > > > > > > > > > int ret; > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > if (!i2c->irq) { > > > > > > > > > > > > > > > > > > > > @@ -721,6 +931,22 @@ static int pca9450_i2c_probe(struct > > > > > i2c_client > > > > > *i2c) > > > > > > > > > > > > > > > > > > > > if (!pca9450) > > > > > > > > > > > > > > > > > > > > return -ENOMEM; > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > + pca9450->regmap =3D devm_regmap_init_i2c(i2c, > > > > > + > > > > > > > > > > > > > > > > &pca9450_regmap_config); > > > > > > > > > > > > > > > > > + if (IS_ERR(pca9450->regmap)) { > > > > > + dev_err(&i2c->dev, "regmap initialization failed\n"= ); > > > > > + return PTR_ERR(pca9450->regmap); > > > > > + } > > > > > + > > > > > + ret =3D regmap_read(pca9450->regmap, PCA9450_REG_PWRCTRL, > > > > > > > > > > > > > > > > &val); > > > > > > > > > > > > > > > > > + if (ret) { > > > > > + dev_err(&i2c->dev, "Read device id error\n"); > > > > > + return ret; > > > > > + } > > > > > + > > > > > + if (val & PCA9450_REG_PWRCTRL_TOFF_DEB) > > > > > + pmic_trim =3D true; > > > > > > > > > > > > > > > > > > > > > > > > PCA9450_REG_PWRCTRL is a read/write register. How is it possible to > > > > detect a chip revision using a bit which can be changed by software > > > > e.g. > > > > bootloader? Despite that this bit sets debounce time for > > > > PMIC_ON_REQ, how is this related to BUCK1 voltage range? > > > > > > > > > > > > There are old and new two kind PMIC pca9451a. > > > > > > > > There is only one part mentioned in the ordering options. How can I > > distinguish them? Any chip ID, date codes, markings? >=20 > Yes, there is only one part. We distinguish the new and old part by this > bit Toff_Deb of PCA9450_REG_PWRCTRL reset value. The reset value 0 means > it's old part, and the reset value 1 means it's new part. Is the "old" part by coincidence an unofficial prerelease/sample chip? > > > > > > > This bit sets debounce time in > > > PCA9450_REG_PWRCTRL was set different value by hardware in order to > > > only distinguish the old and new PMIC. This bit isn't related to the > > > BUCK1 voltage range. If the pmic_trim is true that means it's new > > > pca9451a. > > > > > > > But this bit is writable. How do you know it has not been modified since > > reset? > Yes, we don't consider modify the debounce bit case. Modify the Toff_deb > value will influence the old and new part judgement. This judgement seems broken to me. How can I know offline whether I have ol= d=20 or new parts? I would like to know if there is a difference on some my boar= ds. > For example, this default value of Toff_deb is 1 in the new part, if the > customers change the Toff_deb value from 1 to 0, and then make the board > warm reset, the Toff_deb value still keep 0, if the Toff_deb value is 0, > the PMIC driver will think this part is old part. But this part is new pa= rt > in fact. This should show you it's a bad idea to decide the chip revision depending = on=20 Toff_deb. > Have discussed this issue with our internal team member, we will add a no= te > to PCA9451 datasheet =E2=80=93 =E2=80=9CPlease contract NXP If you want to change > Toff_deb.=E2=80=9D But till now, we am not aware any customers case which= need to > adjust Toff_deb. >=20 > Make it more clear: If customers do need to manually adjust Toff_deb, It > need PMIC driver update to bypass this bit check and directly apply > corresponding voltage config table old or new. Thank you very much for yo= ur > comments and efforts. In this case I need to know if I use old, new or both revision of these par= ts. Best regards, Alexander =2D-=20 TQ-Systems GmbH | M=C3=BChlstra=C3=9Fe 2, Gut Delling | 82229 Seefeld, Germ= any Amtsgericht M=C3=BCnchen, HRB 105018 Gesch=C3=A4ftsf=C3=BChrer: Detlef Schneider, R=C3=BCdiger Stahl, Stefan Sch= neider http://www.tq-group.com/