From: David Howells <dhowells@warthog.cambridge.redhat.com>
To: "YOSHIFUJI Hideaki / ?$B5HF#1QL@?(B" <yoshfuji@linux-ipv6.org>,
chris@wirex.com, davem@redhat.com, torvalds@transmeta.com,
dhowells@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix net/rxrpc/proc.c
Date: Tue, 13 May 2003 10:25:04 +0100 [thread overview]
Message-ID: <22151.1052817904@warthog.warthog> (raw)
In-Reply-To: <22117.1052817698@warthog.warthog>
> > Thanks, sorry, I should have Cc:'d you in the first place, my apology.
> > Seems like the rxrpc_proc_calls_fops should get an owner as well?
> > (relative to the last patch)
>
> Should all file_operations tables associated with this be "owned" in this
> manner?
Hmmm... actually, looking at the code, it ought to be unnecessary as the proc
entries are "owned", eg:
int rxrpc_proc_init(void)
{
struct proc_dir_entry *p;
proc_rxrpc = proc_mkdir("rxrpc",proc_net);
if (!proc_rxrpc)
goto error;
proc_rxrpc->owner = THIS_MODULE;
...
}
David
prev parent reply other threads:[~2003-05-13 9:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-13 0:38 [PATCH] fix net/rxrpc/proc.c Chris Wright
2003-05-13 1:49 ` David S. Miller
2003-05-13 2:00 ` Chris Wright
2003-05-13 2:26 ` YOSHIFUJI Hideaki / 吉藤英明
2003-05-13 3:05 ` Chris Wright
2003-05-13 3:07 ` David S. Miller
2003-05-13 3:13 ` YOSHIFUJI Hideaki / 吉藤英明
2003-05-13 9:21 ` David Howells
2003-05-13 9:25 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22151.1052817904@warthog.warthog \
--to=dhowells@warthog.cambridge.redhat.com \
--cc=chris@wirex.com \
--cc=davem@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.