From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:35976 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728029AbeHVLkQ (ORCPT ); Wed, 22 Aug 2018 07:40:16 -0400 From: Laurent Pinchart To: Jacopo Mondi Cc: "open list:DRM DRIVERS FOR RENESAS" , "open list:DRM DRIVERS FOR RENESAS" Subject: Re: [PATCH 1/3] drm: rcar-du: Rename and document dpll_ch field Date: Wed, 22 Aug 2018 11:17:24 +0300 Message-ID: <2217806.dZf7rhU4vc@avalon> In-Reply-To: <1534922509-15197-2-git-send-email-jacopo+renesas@jmondi.org> References: <1534922509-15197-1-git-send-email-jacopo+renesas@jmondi.org> <1534922509-15197-2-git-send-email-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Jacopo, Thank you for the patch. On Wednesday, 22 August 2018 10:21:47 EEST Jacopo Mondi wrote: > Document and re-name the 'dpll_ch' field to a more precise 'dpll_mask' for > consistency with the 'channels_mask' field defined in 'struct > rcar_du_device_info'. > > Signed-off-by: Jacopo Mondi > --- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 6 +++--- > drivers/gpu/drm/rcar-du/rcar_du_drv.h | 3 ++- > 3 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c index 2664336..5454884 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > @@ -211,7 +211,7 @@ static void rcar_du_crtc_set_display_timing(struct > rcar_du_crtc *rcrtc) u32 dsmr; > u32 escr; > > - if (rcdu->info->dpll_ch & (1 << rcrtc->index)) { > + if (rcdu->info->dpll_mask & (1 << rcrtc->index)) { > unsigned long target = mode_clock; > struct dpll_info dpll = { 0 }; > unsigned long extclk; > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 02aee6c..b42145c 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -215,7 +215,7 @@ static const struct rcar_du_device_info > rcar_du_r8a7795_info = { }, > }, > .num_lvds = 1, > - .dpll_ch = BIT(2) | BIT(1), > + .dpll_mask = BIT(2) | BIT(1), > }; > > static const struct rcar_du_device_info rcar_du_r8a7796_info = { > @@ -243,7 +243,7 @@ static const struct rcar_du_device_info > rcar_du_r8a7796_info = { }, > }, > .num_lvds = 1, > - .dpll_ch = BIT(1), > + .dpll_mask = BIT(1), > }; > > static const struct rcar_du_device_info rcar_du_r8a77965_info = { > @@ -271,7 +271,7 @@ static const struct rcar_du_device_info > rcar_du_r8a77965_info = { }, > }, > .num_lvds = 1, > - .dpll_ch = BIT(1), > + .dpll_mask = BIT(1), > }; > > static const struct rcar_du_device_info rcar_du_r8a77970_info = { > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.h > b/drivers/gpu/drm/rcar-du/rcar_du_drv.h index b3a25e8..6453b33 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.h > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.h > @@ -55,6 +55,7 @@ struct rcar_du_output_routing { > * @channels_mask: bit mask of available DU channels > * @routes: array of CRTC to output routes, indexed by output > (RCAR_DU_OUTPUT_*) * @num_lvds: number of internal LVDS encoders > + * @dpll_mask: mask of DU channels equipped with a DPLL I'd way "bit mask" instead of "mask" in the description. Apart from that, Reviewed-by: Laurent Pinchart and taken in my tree. > */ > struct rcar_du_device_info { > unsigned int gen; > @@ -63,7 +64,7 @@ struct rcar_du_device_info { > unsigned int channels_mask; > struct rcar_du_output_routing routes[RCAR_DU_OUTPUT_MAX]; > unsigned int num_lvds; > - unsigned int dpll_ch; > + unsigned int dpll_mask; > }; > > #define RCAR_DU_MAX_CRTCS 4 -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 1/3] drm: rcar-du: Rename and document dpll_ch field Date: Wed, 22 Aug 2018 11:17:24 +0300 Message-ID: <2217806.dZf7rhU4vc@avalon> References: <1534922509-15197-1-git-send-email-jacopo+renesas@jmondi.org> <1534922509-15197-2-git-send-email-jacopo+renesas@jmondi.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 260CE89F89 for ; Wed, 22 Aug 2018 08:16:28 +0000 (UTC) In-Reply-To: <1534922509-15197-2-git-send-email-jacopo+renesas@jmondi.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jacopo Mondi Cc: "open list:DRM DRIVERS FOR RENESAS" , "open list:DRM DRIVERS FOR RENESAS" List-Id: dri-devel@lists.freedesktop.org SGkgSmFjb3BvLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBXZWRuZXNkYXksIDIyIEF1 Z3VzdCAyMDE4IDEwOjIxOjQ3IEVFU1QgSmFjb3BvIE1vbmRpIHdyb3RlOgo+IERvY3VtZW50IGFu ZCByZS1uYW1lIHRoZSAnZHBsbF9jaCcgZmllbGQgdG8gYSBtb3JlIHByZWNpc2UgJ2RwbGxfbWFz aycgZm9yCj4gY29uc2lzdGVuY3kgd2l0aCB0aGUgJ2NoYW5uZWxzX21hc2snIGZpZWxkIGRlZmlu ZWQgaW4gJ3N0cnVjdAo+IHJjYXJfZHVfZGV2aWNlX2luZm8nLgo+IAo+IFNpZ25lZC1vZmYtYnk6 IEphY29wbyBNb25kaSA8amFjb3BvK3JlbmVzYXNAam1vbmRpLm9yZz4KPiAtLS0KPiAgZHJpdmVy cy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmMgfCAyICstCj4gIGRyaXZlcnMvZ3B1L2Ry bS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMgIHwgNiArKystLS0KPiAgZHJpdmVycy9ncHUvZHJtL3Jj YXItZHUvcmNhcl9kdV9kcnYuaCAgfCAzICsrLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDYgaW5zZXJ0 aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L3JjYXItZHUvcmNhcl9kdV9jcnRjLmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJf ZHVfY3J0Yy5jIGluZGV4IDI2NjQzMzYuLjU0NTQ4ODQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmNh ci1kdS9yY2FyX2R1X2NydGMuYwo+IEBAIC0yMTEsNyArMjExLDcgQEAgc3RhdGljIHZvaWQgcmNh cl9kdV9jcnRjX3NldF9kaXNwbGF5X3RpbWluZyhzdHJ1Y3QKPiByY2FyX2R1X2NydGMgKnJjcnRj KSB1MzIgZHNtcjsKPiAgCXUzMiBlc2NyOwo+IAo+IC0JaWYgKHJjZHUtPmluZm8tPmRwbGxfY2gg JiAoMSA8PCByY3J0Yy0+aW5kZXgpKSB7Cj4gKwlpZiAocmNkdS0+aW5mby0+ZHBsbF9tYXNrICYg KDEgPDwgcmNydGMtPmluZGV4KSkgewo+ICAJCXVuc2lnbmVkIGxvbmcgdGFyZ2V0ID0gbW9kZV9j bG9jazsKPiAgCQlzdHJ1Y3QgZHBsbF9pbmZvIGRwbGwgPSB7IDAgfTsKPiAgCQl1bnNpZ25lZCBs b25nIGV4dGNsazsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9k dV9kcnYuYwo+IGIvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYyBpbmRleCAw MmFlZTZjLi5iNDIxNDVjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3Jj YXJfZHVfZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5j Cj4gQEAgLTIxNSw3ICsyMTUsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHJjYXJfZHVfZGV2aWNl X2luZm8KPiByY2FyX2R1X3I4YTc3OTVfaW5mbyA9IHsgfSwKPiAgCX0sCj4gIAkubnVtX2x2ZHMg PSAxLAo+IC0JLmRwbGxfY2ggPSAgQklUKDIpIHwgQklUKDEpLAo+ICsJLmRwbGxfbWFzayA9ICBC SVQoMikgfCBCSVQoMSksCj4gIH07Cj4gCj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcmNhcl9kdV9k ZXZpY2VfaW5mbyByY2FyX2R1X3I4YTc3OTZfaW5mbyA9IHsKPiBAQCAtMjQzLDcgKzI0Myw3IEBA IHN0YXRpYyBjb25zdCBzdHJ1Y3QgcmNhcl9kdV9kZXZpY2VfaW5mbwo+IHJjYXJfZHVfcjhhNzc5 Nl9pbmZvID0geyB9LAo+ICAJfSwKPiAgCS5udW1fbHZkcyA9IDEsCj4gLQkuZHBsbF9jaCA9ICBC SVQoMSksCj4gKwkuZHBsbF9tYXNrID0gIEJJVCgxKSwKPiAgfTsKPiAKPiAgc3RhdGljIGNvbnN0 IHN0cnVjdCByY2FyX2R1X2RldmljZV9pbmZvIHJjYXJfZHVfcjhhNzc5NjVfaW5mbyA9IHsKPiBA QCAtMjcxLDcgKzI3MSw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcmNhcl9kdV9kZXZpY2VfaW5m bwo+IHJjYXJfZHVfcjhhNzc5NjVfaW5mbyA9IHsgfSwKPiAgCX0sCj4gIAkubnVtX2x2ZHMgPSAx LAo+IC0JLmRwbGxfY2ggPSAgQklUKDEpLAo+ICsJLmRwbGxfbWFzayA9ICBCSVQoMSksCj4gIH07 Cj4gCj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcmNhcl9kdV9kZXZpY2VfaW5mbyByY2FyX2R1X3I4 YTc3OTcwX2luZm8gPSB7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3Jj YXJfZHVfZHJ2LmgKPiBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmggaW5k ZXggYjNhMjVlOC4uNjQ1M2IzMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1k dS9yY2FyX2R1X2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9k cnYuaAo+IEBAIC01NSw2ICs1NSw3IEBAIHN0cnVjdCByY2FyX2R1X291dHB1dF9yb3V0aW5nIHsK PiAgICogQGNoYW5uZWxzX21hc2s6IGJpdCBtYXNrIG9mIGF2YWlsYWJsZSBEVSBjaGFubmVscwo+ ICAgKiBAcm91dGVzOiBhcnJheSBvZiBDUlRDIHRvIG91dHB1dCByb3V0ZXMsIGluZGV4ZWQgYnkg b3V0cHV0Cj4gKFJDQVJfRFVfT1VUUFVUXyopICogQG51bV9sdmRzOiBudW1iZXIgb2YgaW50ZXJu YWwgTFZEUyBlbmNvZGVycwo+ICsgKiBAZHBsbF9tYXNrOiBtYXNrIG9mIERVIGNoYW5uZWxzIGVx dWlwcGVkIHdpdGggYSBEUExMCgpJJ2Qgd2F5ICJiaXQgbWFzayIgaW5zdGVhZCBvZiAibWFzayIg aW4gdGhlIGRlc2NyaXB0aW9uLiBBcGFydCBmcm9tIHRoYXQsCgpSZXZpZXdlZC1ieTogTGF1cmVu dCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgoKYW5kIHRha2Vu IGluIG15IHRyZWUuCgo+ICAgKi8KPiAgc3RydWN0IHJjYXJfZHVfZGV2aWNlX2luZm8gewo+ICAJ dW5zaWduZWQgaW50IGdlbjsKPiBAQCAtNjMsNyArNjQsNyBAQCBzdHJ1Y3QgcmNhcl9kdV9kZXZp Y2VfaW5mbyB7Cj4gIAl1bnNpZ25lZCBpbnQgY2hhbm5lbHNfbWFzazsKPiAgCXN0cnVjdCByY2Fy X2R1X291dHB1dF9yb3V0aW5nIHJvdXRlc1tSQ0FSX0RVX09VVFBVVF9NQVhdOwo+ICAJdW5zaWdu ZWQgaW50IG51bV9sdmRzOwo+IC0JdW5zaWduZWQgaW50IGRwbGxfY2g7Cj4gKwl1bnNpZ25lZCBp bnQgZHBsbF9tYXNrOwo+ICB9Owo+IAo+ICAjZGVmaW5lIFJDQVJfRFVfTUFYX0NSVENTCQk0Cgot LSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg==