All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Timur Kristóf" <timur.kristof@gmail.com>
To: "Koenig, Christian" <Christian.Koenig@amd.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"SHANMUGAM, SRINIVASAN" <SRINIVASAN.SHANMUGAM@amd.com>
Cc: "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: Reduce stack usage in IP block soft reset
Date: Mon, 22 Jun 2026 13:53:32 +0200	[thread overview]
Message-ID: <2217972.9o76ZdvQCi@timur-max> (raw)
In-Reply-To: <IA0PR12MB82084FFD926ED6F878B843AD90EF2@IA0PR12MB8208.namprd12.prod.outlook.com>

On 2026. június 22., hétfő 13:18:55 közép-európai nyári idő SHANMUGAM, 
SRINIVASAN wrote:
> 
> Hi Srini,
> 
> I'm sorry for the trouble, I haven't seen this warning.
> Please give me a moment, I can send a fix later today.
> 
> Thanks & best regards,
> 
> 
> 
> Thanks Timur.
> Sounds good.
> While looking into the issue, I noticed that the temporary array is only
> used to collect the affected rings before passing them to the multi-ring
> reset helpers. It looks like the intermediate array may be avoidable by
> having the helpers iterate directly over adev->rings[] while applying the
> same ring_type_mask filter.

Thank you Srini. I agree, I had the same idea in mind.

I'll write a patch this afternoon and give it some testing to make sure I 
don't accidentally regress the functionality, then I can send it to ML 
tomorrow at the latest.

Best regards,
Timur




      reply	other threads:[~2026-06-22 11:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-19 17:17 [PATCH] drm/amdgpu: Reduce stack usage in IP block soft reset Srinivasan Shanmugam
2026-06-19 18:17 ` Alex Deucher
2026-06-20  1:17   ` SHANMUGAM, SRINIVASAN
2026-06-22  8:15 ` Christian König
2026-06-22  9:01   ` SHANMUGAM, SRINIVASAN
2026-06-22  9:10     ` SHANMUGAM, SRINIVASAN
2026-06-22 11:07       ` Timur Kristóf
2026-06-22 11:18         ` SHANMUGAM, SRINIVASAN
2026-06-22 11:53           ` Timur Kristóf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2217972.9o76ZdvQCi@timur-max \
    --to=timur.kristof@gmail.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=SRINIVASAN.SHANMUGAM@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.