From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sander Eikelenboom Subject: Re: [PATCH] pass-through: fix unbinding of MSI interrupts Date: Wed, 6 Aug 2014 10:20:02 +0200 Message-ID: <22210458.20140806102002@eikelenboom.it> References: <53E0F42C02000078000297BF@mail.emea.novell.com> <53E0FDDF.5090304@oracle.com> <20140805155723.GB20827@laptop.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XEwS7-0008KS-A0 for xen-devel@lists.xenproject.org; Wed, 06 Aug 2014 08:20:07 +0000 In-Reply-To: <20140805155723.GB20827@laptop.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: xen-devel , Boris Ostrovsky , Jan Beulich List-Id: xen-devel@lists.xenproject.org Tuesday, August 5, 2014, 5:57:23 PM, you wrote: > On Tue, Aug 05, 2014 at 11:53:03AM -0400, Boris Ostrovsky wrote: >> On 08/05/2014 09:11 AM, Jan Beulich wrote: >> >Commit 568da4f8 ("pt-irq fixes and improvements") went a little too far >> >in its cleaning up of pt_irq_destroy_bind(): While neither of the two >> >lists need any maintenance, the actual unbinding still needs to be >> >done. Fix this and at once >> >- move all variables applying only to the PCI/MSI-translate cases into >> > scopes where they can't be used in error, >> >- limit the final (optional) log message to the cases it actually >> > applies and enhance it to make clear how much cleaning up was >> > actually done. >> > >> >Reported-by: Sander Eikelenboom >> >Signed-off-by: Jan Beulich >> >> >> Tested-by: Boris Ostrovsky > Might as well join the club :-) > Tested-by: Konrad Rzeszutek Wilk Can't stay behind ;-) Tested-by: Sander Eikelenboom >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xen.org >> http://lists.xen.org/xen-devel