From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48D6AC54E58 for ; Mon, 18 Mar 2024 15:53:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5AFB510E6D1; Mon, 18 Mar 2024 15:53:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.b="gwRvodGd"; dkim-atps=neutral Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0AB8110E6D1 for ; Mon, 18 Mar 2024 15:53:24 +0000 (UTC) Message-ID: <22229306-aa72-4367-b029-fbdff4410cec@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710777203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u2fhW2XsomTNdCpefo2Y8uVowFyGOPa7DoCroUYHuXk=; b=gwRvodGdcbILQ+b8YI+F3em9ZFo2G15b7eb75ycddqP88fLN0j4PuBzDMVddeCxSFlOgBX 59nwzRSYzIUUUXINo27wZ4D6Fklty9A/hp9VIh3/zpz9Q8x5BQ54iBnLb7QBB5rYlH1uV7 SReV9oeTK+U/JfWA8bBdR+cVOi/RL0Y= Date: Mon, 18 Mar 2024 23:53:11 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] drm: bridge: thc63lvd1024: Switch to use of_graph_get_remote_node() Content-Language: en-US To: Laurent Pinchart Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20240316172800.1168390-1-sui.jingfeng@linux.dev> <20240318153326.GD13682@pendragon.ideasonboard.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sui Jingfeng In-Reply-To: <20240318153326.GD13682@pendragon.ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 2024/3/18 23:33, Laurent Pinchart wrote: > Hi Sui, > > Thank you for the patch. > > On Sun, Mar 17, 2024 at 01:28:00AM +0800, Sui Jingfeng wrote: >> To reduce boilerplate, use of_graph_get_remote_node() helper instead of >> the hand-rolling code. >> >> Signed-off-by: Sui Jingfeng >> --- >> drivers/gpu/drm/bridge/thc63lvd1024.c | 24 +++--------------------- >> 1 file changed, 3 insertions(+), 21 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c b/drivers/gpu/drm/bridge/thc63lvd1024.c >> index d4c1a601bbb5..5f99f9724081 100644 >> --- a/drivers/gpu/drm/bridge/thc63lvd1024.c >> +++ b/drivers/gpu/drm/bridge/thc63lvd1024.c >> @@ -123,28 +123,10 @@ static int thc63_parse_dt(struct thc63_dev *thc63) >> struct device_node *endpoint; >> struct device_node *remote; >> >> - endpoint = of_graph_get_endpoint_by_regs(thc63->dev->of_node, >> - THC63_RGB_OUT0, -1); >> - if (!endpoint) { >> - dev_err(thc63->dev, "Missing endpoint in port@%u\n", >> - THC63_RGB_OUT0); >> - return -ENODEV; >> - } >> - >> - remote = of_graph_get_remote_port_parent(endpoint); >> - of_node_put(endpoint); >> - if (!remote) { >> - dev_err(thc63->dev, "Endpoint in port@%u unconnected\n", >> - THC63_RGB_OUT0); >> + remote = of_graph_get_remote_node(thc63->dev->of_node, >> + THC63_RGB_OUT0, -1); >> + if (!remote) > The old logic is equivalent to of_graph_get_remote_node(), but now the > driver will fail probing without an error message. That's not very nice > as it leads to difficult to debug problems. I would keep one dev_err() > here: > > dev_err(thc63->dev, "No remote endpoint for port@%u\n", > THC63_RGB_OUT0); > > As your patch has been merged already, would you like to post a > follow-up patch to fix this ? Yes, this is indeed a difference. I will post a follow-up patch to fix this. >> return -ENODEV; >> - } >> - >> - if (!of_device_is_available(remote)) { >> - dev_err(thc63->dev, "port@%u remote endpoint is disabled\n", >> - THC63_RGB_OUT0); >> - of_node_put(remote); >> - return -ENODEV; >> - } >> >> thc63->next = of_drm_find_bridge(remote); >> of_node_put(remote); -- Best regards, Sui