Re: [PATCH] linkstation / kurobox support

[Kumar Gala <galak@kernel.crashing.org>]

On Jan 28, 2007, at 4:31 PM, Guennadi Liakhovetski wrote:

> On Sat, 2 Dec 2006, Benjamin Herrenschmidt wrote:
>
>> On Sat, 2006-12-02 at 11:56 +0100, Arnd Bergmann wrote:
>>
>>>> +#ifdef CONFIG_BLK_DEV_INITRD
>>>> +       if (initrd_start)
>>>> +               ROOT_DEV = Root_RAM0;
>>>> +       else
>>>> +#endif
>>>> +#ifdef CONFIG_ROOT_NFS
>>>> +               ROOT_DEV = Root_NFS;
>>>> +#else
>>>> +               ROOT_DEV = Root_HDA1;
>>>> +#endif
>>>> +
>>>
>>> This looks wrong. Didn't the same code come up recently in a  
>>> review for
>>> another platform? What was the conclusion?
>>
>> It's a copy paste that we inhertit from the big bang...  Should  
>> probably
>> go...
>
> ...and there it goes. Re-diffed against 2.6.20-rc6. For inclusion in
> 2.6.21.
>
> Thanks
> Guennadi
> ---
> Guennadi Liakhovetski
>
> Linkstation systems capable of running mainline kernels use u-boot  
> as a
> bootloader, so, specifying a suitable kernel command is not a problem.
> Don't guess. Also extend linkstation_defconfig to support the  
> linkstation HS
> model with a IT8212 IDE controller and kuroboxHD/HD-HLAN linkstation
> models with a tulip ethernet chip. The latter also require a slightly
> different .dts file, which is also included with this patch.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

applied

- k