Re: [PATCH] drm/amd: Adjust ASPM support quirk to cover more Intel hosts

["Timur Kristóf" <timur.kristof@gmail.com>]

On Sunday, April 19, 2026 6:16:52 AM Central European Summer Time Mario 
Limonciello wrote:
> Some of the same issues identified in commit c770ef19673fb
> ("drm/amd/amdgpu: disable ASPM in some situations") also affect
> Tiger Lake systems with GFX11 connected over USB4. Widen the net
> to also match these hosts.

Wouldn't it be better to check that the connection is through USB4 rather than 
entirely disable ASPM accross all these families of CPUs?

> 
> Fixes: d9b3a066dfcd3 ("drm/amd: Exclude dGPUs in eGPU enclosures from DPM
> quirks") Closes: https://gitlab.freedesktop.org/drm/amd/-/work_items/5145
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index
> bc7e96b58d3fc..b11c4b5fa8fcd 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1334,18 +1334,15 @@ static bool amdgpu_device_aspm_support_quirk(struct
> amdgpu_device *adev) #if IS_ENABLED(CONFIG_X86)
>  	struct cpuinfo_x86 *c = &cpu_data(0);
> 
> -	if (!(amdgpu_ip_version(adev, GC_HWIP, 0) == IP_VERSION(12, 0, 0) 
||
> -		  amdgpu_ip_version(adev, GC_HWIP, 0) == IP_VERSION(12, 
0, 1)))
> -		return false;
> -
> -	if (c->x86 == 6 &&
> -		adev->pm.pcie_gen_mask & 
CAIL_PCIE_LINK_SPEED_SUPPORT_GEN5) {
> +	if (c->x86_vendor == X86_VENDOR_INTEL) {
>  		switch (c->x86_model) {
>  		case VFM_MODEL(INTEL_ALDERLAKE):
>  		case VFM_MODEL(INTEL_ALDERLAKE_L):
>  		case VFM_MODEL(INTEL_RAPTORLAKE):
>  		case VFM_MODEL(INTEL_RAPTORLAKE_P):
>  		case VFM_MODEL(INTEL_RAPTORLAKE_S):
> +		case VFM_MODEL(INTEL_TIGERLAKE):
> +		case VFM_MODEL(INTEL_TIGERLAKE_L):
>  			return true;
>  		default:
>  			return false;