From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: tools brainstorming Date: Wed, 08 Apr 2015 18:16:12 +0200 Message-ID: <2232884.6IKBPajdgE@xps13> References: <3571725.20GtF5MAnU@xps13> <0C5AFCA4B3408848ADF2A3073F7D8CC86D58F9C2@IRSMSX109.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Wiles, Keith" , "Butler, Siobhan A" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-04-08 15:53, Wiles, Keith: > One of the biggest problems with any style is helping the developer > maintain the style. Using some tool does help and I have used astyle > before, not bad code formatter. Here is a few that seem to be reasonable. > > http://astyle.sourceforge.net/ > > http://uncrustify.sourceforge.net/ > > http://sourceforge.net/projects/gcgreatcode/ I'm not sure it's a good idea to convert the codebase automatically. The coding style must be a reference for new patches and they must be automatically checked with a dedicated checkpatch tool. By forbidding patches which don't comply, the codebase will be naturally converted over time. I didn't review this proposal yet. My first comment is that it's too long to read :) When a consensus is done, it must be added with a patch with custom checkpatch addition.