From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Bruce Richardson <bruce.richardson@intel.com>,
Nicolas Chautru <nicolas.chautru@intel.com>,
Liron Himi <lironh@marvell.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Tianfei Zhang <tianfei.zhang@intel.com>,
Andy Pei <andy.pei@intel.com>,
Kamil Chalupnik <kamilx.chalupnik@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Jerin Jacob <jerinj@marvell.com>
Subject: Re: [PATCH] build: fix dependencies lookup
Date: Mon, 16 Jan 2023 11:00:57 +0100 [thread overview]
Message-ID: <2233012.CrzyxZ31qj@thomas> (raw)
In-Reply-To: <CAJFAV8wrtHVBS9-oG9upqfwN4cgjHe8K9UEvzJRJ=aR4QiYG0Q@mail.gmail.com>
16/01/2023 10:23, David Marchand:
> On Sun, Jan 15, 2023 at 5:53 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > The first parameter of the Meson function "find_library()"
> > should be the library name without the "lib" prefix.
> >
> > Otherwise Meson prints this warning:
> > WARNING: find_library('libexecinfo') starting in "lib"
> > only works by accident and is not portable
> >
> > Fixes: 1cd512b2f532 ("build: detect execinfo library on Linux")
> > Fixes: e1defba4cf66 ("raw/ifpga/base: support device tree")
> > Fixes: a489f5dbf437 ("baseband/turbo_sw: support meson build")
> > Fixes: 72c00ae9dba7 ("regex/cn9k: use cnxk infrastructure")
> > Cc: stable@dpdk.org
>
> This patch depends on
> https://patchwork.dpdk.org/project/dpdk/patch/20230108095920.327672-1-thomas@monjalon.net/
> which is not marked for backport.
It does not depend really (logically), it is just a patch conflict
because they are changing close lines.
> So either the latter is marked for backport too, or the order of those
> two patches should be inverted (to make it easier for LTS
> maintainers).
I understand what you mean: if this patch is applied first,
it is easier to backport because context did not change compared to old versions.
> Otherwise, it lgtm.
So let's merge it :)
next prev parent reply other threads:[~2023-01-16 10:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 16:53 [PATCH] build: fix dependencies lookup Thomas Monjalon
2023-01-16 9:06 ` Bruce Richardson
2023-01-16 9:23 ` David Marchand
2023-01-16 10:00 ` Thomas Monjalon [this message]
2023-02-06 11:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2233012.CrzyxZ31qj@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=andy.pei@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=kamilx.chalupnik@intel.com \
--cc=lironh@marvell.com \
--cc=nicolas.chautru@intel.com \
--cc=stable@dpdk.org \
--cc=tianfei.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.