Re: [PATCH] uvcvideo: Fix empty packet statistic

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Kieran,

Thank you for the patch.

On Monday 03 Apr 2017 12:25:32 Kieran Bingham wrote:
> From: Kieran Bingham <kieran.bingham@ideasonboard.com>
> 
> The frame counters are inadvertently counting packets with content as
> empty.
> 
> Fix it by correcting the logic expression
> 
> Fixes: 7bc5edb00bbd [media] uvcvideo: Extract video stream statistics
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and applied to my tree.

> ---
>  drivers/media/usb/uvc/uvc_video.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/usb/uvc/uvc_video.c
> b/drivers/media/usb/uvc/uvc_video.c index 075a0fe77485..7777ed24908b 100644
> --- a/drivers/media/usb/uvc/uvc_video.c
> +++ b/drivers/media/usb/uvc/uvc_video.c
> @@ -818,7 +818,7 @@ static void uvc_video_stats_decode(struct uvc_streaming
> *stream,
> 
>  	/* Update the packets counters. */
>  	stream->stats.frame.nb_packets++;
> -	if (len > header_size)
> +	if (len <= header_size)
>  		stream->stats.frame.nb_empty++;
> 
>  	if (data[1] & UVC_STREAM_ERR)

-- 
Regards,

Laurent Pinchart