From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>, prateekag@cse.iitb.ac.in
Cc: dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [PATCH] app: do not call printf in signal handlers
Date: Wed, 28 Jun 2023 02:44:09 +0200 [thread overview]
Message-ID: <2234390.KTMopqUuYO@thomas> (raw)
In-Reply-To: <20230615201404.GB32486@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
15/06/2023 22:14, Tyler Retzlaff:
> On Mon, Jun 12, 2023 at 05:11:50PM -0700, Stephen Hemminger wrote:
> > Using printf is not async-signal safe and worst case may lead to deadlock.
> > Remove printf from signal handlers present in several applications.
> >
> > Testpmd was already fixed by
> > commit 0fd1386c30c3 ("app/testpmd: cleanup cleanly from signal")
> >
> > Signed-off-by: Prateek Agarwal <prateekag@cse.iitb.ac.in>
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
>
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Applied, thanks for reviving this old patch.
prev parent reply other threads:[~2023-06-28 0:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 17:51 [dpdk-dev] [PATCH] Remove printf from signal handler Prateek Agarwal
2020-12-08 2:58 ` Li, Xiaoyun
2020-12-10 0:28 ` prateekag
2020-12-10 3:14 ` Li, Xiaoyun
2020-12-10 9:24 ` Ananyev, Konstantin
2020-12-11 13:38 ` prateekag
2023-06-13 0:11 ` [PATCH] app: do not call printf in signal handlers Stephen Hemminger
2023-06-15 20:14 ` Tyler Retzlaff
2023-06-28 0:44 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2234390.KTMopqUuYO@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=prateekag@cse.iitb.ac.in \
--cc=roretzla@linux.microsoft.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.