From: Aaron Williams <awilliams@marvell.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [EXT] Re: Cavium/Marvell Octeon Support
Date: Tue, 5 Nov 2019 02:13:13 +0000 [thread overview]
Message-ID: <2235710.XZ1BuITEuP@flash> (raw)
In-Reply-To: <20191104172216.GA11173@bill-the-cat>
Hi Wolfgang,
On Monday, November 4, 2019 9:22:16 AM PST Tom Rini wrote:
> On Thu, Oct 31, 2019 at 06:01:34PM +0000, Aaron Williams wrote:
> > Hi Wolfgang,
> >
> > On Thursday, October 31, 2019 3:40:27 AM PDT Wolfgang Denk wrote:
> > > Dear Aaron,
> > >
> > > In message <1889679.7FQr5zsBR1@flash> you wrote:
> > > > Currently we are using 39MB under arch/mips. I think I can easily cut
> > > > this
> > > > down to 15MB or smaller, especially by moving some code here to the
> > > > appropriate driver directories (i.e. DRAM, pcie, watchdog, etc.)
> > > >
> > > > It will still be a large SoC, though.
> > >
> > > Have you already looked at formal requirements, like coding style
> > > etc.? Did you ever run your additions through checkpatch.pl, for
> > > example?
> >
> > We did follow the formal coding style. Everything will go through
> > checkpatch. My biggest complaint about it is the 80 columns for debug and
> > other print statements.
>
> checkpatch doesn't complain about those when they use standard logging
> functions, however.
It complains plenty about printf(), debug() and a number of other standard U-
Boot logging calls.
Regards,
Aaron
next prev parent reply other threads:[~2019-11-05 2:13 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 3:50 [U-Boot] Cavium/Marvell Octeon Support Aaron Williams
2019-10-24 6:44 ` Chris Packham
2019-10-25 15:13 ` Daniel Schwierzeck
2019-10-26 22:15 ` Tom Rini
2019-10-27 3:08 ` [U-Boot] [EXT] " Aaron Williams
2019-10-27 2:34 ` Aaron Williams
2019-10-29 13:12 ` Wolfgang Denk
2019-10-30 16:20 ` Daniel Schwierzeck
2019-10-30 17:21 ` Wolfgang Denk
2019-10-30 21:23 ` Aaron Williams
2019-10-31 10:36 ` Wolfgang Denk
2019-10-31 17:59 ` Aaron Williams
2019-11-04 15:44 ` Wolfgang Denk
2019-11-04 16:23 ` Tom Rini
2019-11-05 2:08 ` Aaron Williams
2019-11-05 8:37 ` Wolfgang Denk
2019-11-05 10:22 ` Aaron Williams
2019-11-05 11:36 ` Wolfgang Denk
2019-11-05 23:09 ` Aaron Williams
2019-11-06 15:06 ` Wolfgang Denk
2019-11-06 22:18 ` Aaron Williams
2019-11-07 0:21 ` Tom Rini
2019-11-05 14:15 ` Tom Rini
2019-11-05 1:57 ` Aaron Williams
2019-11-05 8:33 ` Wolfgang Denk
2019-11-05 14:16 ` Tom Rini
2019-10-30 22:05 ` [U-Boot] " Tom Rini
2019-10-30 23:36 ` [U-Boot] [EXT] " Aaron Williams
2019-10-31 10:40 ` Wolfgang Denk
2019-10-31 18:01 ` Aaron Williams
2019-11-04 17:22 ` Tom Rini
2019-11-05 2:13 ` Aaron Williams [this message]
2019-11-05 14:09 ` Tom Rini
2019-10-31 13:26 ` Tom Rini
2019-10-31 18:04 ` Aaron Williams
-- strict thread matches above, loose matches on Subject: below --
2019-11-06 0:03 Aaron Williams
2019-11-07 0:34 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2235710.XZ1BuITEuP@flash \
--to=awilliams@marvell.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.