From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FB73C433EF for ; Fri, 15 Oct 2021 21:34:36 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C89916109E for ; Fri, 15 Oct 2021 21:34:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C89916109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8EE66181C; Fri, 15 Oct 2021 23:33:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8EE66181C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1634333673; bh=sfslgEVh6E6+qlaFeS7mLmrwgNe66NsHcDGVl4BYKoA=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=egUrQvQkTPP17GGX6EjXSLs3OOJWRuxB85NbwKKCifWo/9GPWJYZKnUF+yr8hAeVJ Un5lJKG3S38OPuDcNQ5f8gk70YwJNwb3LeiLjdm72pU5748YSqgox8At2xjqGiAkB/ kA6YJwKdbLcCLkMAIcoNowWPG6RVvkQnSmbxUpbk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1C415F8025B; Fri, 15 Oct 2021 23:33:43 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D7F43F80269; Fri, 15 Oct 2021 23:33:40 +0200 (CEST) Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A2EE9F80167 for ; Fri, 15 Oct 2021 23:33:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A2EE9F80167 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qis8HY5a" Received: by mail-lf1-x129.google.com with SMTP id y26so47200959lfa.11 for ; Fri, 15 Oct 2021 14:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gix2t0OaFc3liLwqh7FD+UgpYjMWRC2yF5wlNLCRBI8=; b=qis8HY5aJowC4EqJFx3MOPhEGhcXjXhZTpVf0O0ZaJ8dAFgGw91o/hVODkU7FRxcw6 AZU8vc1BfB4zTjM1P62wns5tOI3qN2C+s4pQ1Wsy7bv7gKL7jKc2hWKLs86XVr4W4TUT h5GijvI+PE96P1JI/y2GSZq49aFy6a6+/4SPzO/ECa11w6Y/Kv6VmU9qceSy5gDjzk8o pnepTbIkXzhYSl8fZ83W2Z3QQXtAUBpmlgoDMhpCXuKK0p9NHv69rY9hNa2BbT6Eg8it MsEqAMGICMa6VJqyKAXdLuPQ4xTTE1dI1LqDGKMGRp/pg/8J7tVBDb3taihP7FUws+6E ilHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gix2t0OaFc3liLwqh7FD+UgpYjMWRC2yF5wlNLCRBI8=; b=LRJfpw53WisNA6yllcgKknh+hbLIj0Z3sdmpasQc9JzwRmBCGMolTXT9STQ9qdEUfp 4Z1P/dPoRzpBAISvLgI/aBe8cI3xGdGs4+EQXEBTWCUTJUY3qW0SGQSBBRgjmW1aQ45T fVmw5e5q2bkQdMOrymylisT5ZRhHPllJhTmbHWfp//hs3g/zwMQY4cu9V1rZb1scPz91 eB9vUyqoe8WpH5CZrXruFRc4YsdOThRyQet1I2i597C+Ph0PK5dhsQv9kyL78WaYaojx KNU+Iivvph4gMrdD7fvfFRp0ZpVcieLYwkad+yxzrgb2f7oyZLwv9Tbh+XHz3Dl9wA5T c4kA== X-Gm-Message-State: AOAM533sgNUZcZLzl3edyBouw5Habg0slUmNwwh5MQkgMPrakDDzNXKF 5SfbJw29rj//3leRb5cBGOZAn8mpTIw= X-Google-Smtp-Source: ABdhPJyGE7Et43k/hdPxjdpBoYE8kfL5iTjenGOdjS4PvWxGzZHpGXrxlrYYk3a+u1/JkqbbVxvBCQ== X-Received: by 2002:a05:6512:3b94:: with SMTP id g20mr13375031lfv.77.1634333616241; Fri, 15 Oct 2021 14:33:36 -0700 (PDT) Received: from archbook.localnet (84-72-105-84.dclient.hispeed.ch. [84.72.105.84]) by smtp.gmail.com with ESMTPSA id f23sm689425ljn.110.2021.10.15.14.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 14:33:35 -0700 (PDT) From: Nicolas Frattaroli To: Liam Girdwood , Mark Brown , Rob Herring , Heiko Stuebner , Robin Murphy Subject: Re: [PATCH] ASoC: dt-bindings: rockchip: i2s-tdm: fix rockchip, cru requirement Date: Fri, 15 Oct 2021 23:33:34 +0200 Message-ID: <2236749.301RoY5kYM@archbook> In-Reply-To: <8553b0cd-95e4-c3db-c75a-d3b28e99f131@arm.com> References: <20211015143115.1445707-1-frattaroli.nicolas@gmail.com> <8553b0cd-95e4-c3db-c75a-d3b28e99f131@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: Rob Herring , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Freitag, 15. Oktober 2021 19:44:56 CEST Robin Murphy wrote: > On 2021-10-15 15:31, Nicolas Frattaroli wrote: > > The behaviour described in the bindings is exactly the opposite > > of what it should be, so this patch fixes the description and > > adjusts the if conditions for adding rockchip,cru to required. > > > > Fixes: 510f1c133aed ("ASoC: dt-bindings: rockchip: add i2s-tdm bindings") > > Signed-off-by: Nicolas Frattaroli > > --- > > > > .../devicetree/bindings/sound/rockchip,i2s-tdm.yaml | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml > > b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml index > > ce3e18b50230..93f5221e9381 100644 > > --- a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml > > +++ b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml > > > > @@ -86,7 +86,7 @@ properties: > > $ref: /schemas/types.yaml#/definitions/phandle > > > > description: > > The phandle of the cru. > > > > - Required if neither trcm-sync-tx-only nor trcm-sync-rx-only are > > specified. + Required if either trcm-sync-tx-only or > > trcm-sync-rx-only are specified.> > > rockchip,grf: > > $ref: /schemas/types.yaml#/definitions/phandle > > > > @@ -147,8 +147,13 @@ required: > > allOf: > > - if: > > properties: > > - rockchip,trcm-sync-tx-only: false > > - rockchip,trcm-sync-rx-only: false > > + rockchip,trcm-sync-tx-only: true > > + then: > > + required: > > + - rockchip,cru > > + - if: > > + properties: > > + rockchip,trcm-sync-rx-only: true > > FWIW, isn't this just a long-winded way to say > > if: > anyOf: > - properties: > rockchip,trcm-sync-tx-only: true > - properties: > rockchip,trcm-sync-rx-only: true > > which itself could still be more concisely > > if: > not: > properties: > rockchip,trcm-sync-tx-only: false > rockchip,trcm-sync-rx-only: false > > ? Hi Robin, you are absolutely correct. I'm not very familiar with dtschema yet, so I mostly just did what I know would work, as I didn't know about "not" or "anyOf" in this context. However I don't think this patch is going to get a V2 because I may have found a way to easily get rid of the CRU property altogether, making this patch sort of obsolete in the very near future. Thank you for your review nonetheless, I learned some more dtschema today thanks to it. :) > > Robin. > > > then: > > required: > > - rockchip,cru Regards, Nicolas Frattaroli From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 760ECC433EF for ; Fri, 15 Oct 2021 21:33:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 310B260EE2 for ; Fri, 15 Oct 2021 21:33:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 310B260EE2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AXmVjhTU9v7UM2Ly4Xh81BsNYjbA+ik1QVVOiqfnCyo=; b=TxErx1RsvHFasM qW+1di/y0y1xlQZ4Sm2HgkH+pwQ64i3vEnYqxKnjgfzdqwW2f5M0xh6TE0ZJ5DBwkHxZbwIh4Noc4 R0C8H5S8/GhRhOHbBUbieTiqmmj8cUUdFRgx7Cy3t3f5UsjRYpLeWwGafUASUK1kgcF/f9z2a38Gt dTJKjreEmiXTvusNheysZVvsqWJgDzOGouL+f4cB98FrRQNaQ/VM6uucn75GH7HoXCF40RlQF0Vst azM7jj2Fkk42U1SEK7fiuDFPJ2KOCODlL3/bQQcDFln9a+FxBQEVV6lqqQGubTTPI6WIsp8Vq0aOb hmuJy1R/y3Nt/TLbpq1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbUpk-008pRC-Ut; Fri, 15 Oct 2021 21:33:44 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbUpi-008pOp-6x; Fri, 15 Oct 2021 21:33:43 +0000 Received: by mail-lf1-x130.google.com with SMTP id x27so47346335lfu.5; Fri, 15 Oct 2021 14:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gix2t0OaFc3liLwqh7FD+UgpYjMWRC2yF5wlNLCRBI8=; b=qis8HY5aJowC4EqJFx3MOPhEGhcXjXhZTpVf0O0ZaJ8dAFgGw91o/hVODkU7FRxcw6 AZU8vc1BfB4zTjM1P62wns5tOI3qN2C+s4pQ1Wsy7bv7gKL7jKc2hWKLs86XVr4W4TUT h5GijvI+PE96P1JI/y2GSZq49aFy6a6+/4SPzO/ECa11w6Y/Kv6VmU9qceSy5gDjzk8o pnepTbIkXzhYSl8fZ83W2Z3QQXtAUBpmlgoDMhpCXuKK0p9NHv69rY9hNa2BbT6Eg8it MsEqAMGICMa6VJqyKAXdLuPQ4xTTE1dI1LqDGKMGRp/pg/8J7tVBDb3taihP7FUws+6E ilHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gix2t0OaFc3liLwqh7FD+UgpYjMWRC2yF5wlNLCRBI8=; b=vUmvW0HWK/RQcPAOPBYmM/tbFOdDBFtMSox18snhPr51aq/C4H8bqPf4nXf1GhbI2C GhaL5TZjJ6FHS9bFwfnnjSv+hESWBV82dtxYDGph59cROlTlfwsiRw9WNkihg6NBSP6+ EXYcLr0Ht09p86nNAtQea+kce4ztNsCDqx+OT4C2FBGV2tCMxHJG5G+JqwT+FZt7u6V4 pi3zLsgZrDWDDAb9GidvPhrKcDdinlieP9I2tvdZGDuTwo3Fw+E78isq9wJjuKEozP9w A4BVSYSTsaYK61RrawL0NQIAbhal5uOtjXDoStj57iAbVqDyplaDv12WvOp8rJVYSQzV TJew== X-Gm-Message-State: AOAM5312e8nlPSayrszN9AHcuBK7gGm1LUOPUwXPLbXnlkvC9I0s7u3A WRhTQ+Y69pbNTC/DhM8VbVY= X-Google-Smtp-Source: ABdhPJyGE7Et43k/hdPxjdpBoYE8kfL5iTjenGOdjS4PvWxGzZHpGXrxlrYYk3a+u1/JkqbbVxvBCQ== X-Received: by 2002:a05:6512:3b94:: with SMTP id g20mr13375031lfv.77.1634333616241; Fri, 15 Oct 2021 14:33:36 -0700 (PDT) Received: from archbook.localnet (84-72-105-84.dclient.hispeed.ch. [84.72.105.84]) by smtp.gmail.com with ESMTPSA id f23sm689425ljn.110.2021.10.15.14.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 14:33:35 -0700 (PDT) From: Nicolas Frattaroli To: Liam Girdwood , Mark Brown , Rob Herring , Heiko Stuebner , Robin Murphy Cc: Rob Herring , linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: dt-bindings: rockchip: i2s-tdm: fix rockchip, cru requirement Date: Fri, 15 Oct 2021 23:33:34 +0200 Message-ID: <2236749.301RoY5kYM@archbook> In-Reply-To: <8553b0cd-95e4-c3db-c75a-d3b28e99f131@arm.com> References: <20211015143115.1445707-1-frattaroli.nicolas@gmail.com> <8553b0cd-95e4-c3db-c75a-d3b28e99f131@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211015_143342_312393_DDDDA24F X-CRM114-Status: GOOD ( 24.94 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Freitag, 15. Oktober 2021 19:44:56 CEST Robin Murphy wrote: > On 2021-10-15 15:31, Nicolas Frattaroli wrote: > > The behaviour described in the bindings is exactly the opposite > > of what it should be, so this patch fixes the description and > > adjusts the if conditions for adding rockchip,cru to required. > > > > Fixes: 510f1c133aed ("ASoC: dt-bindings: rockchip: add i2s-tdm bindings") > > Signed-off-by: Nicolas Frattaroli > > --- > > > > .../devicetree/bindings/sound/rockchip,i2s-tdm.yaml | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml > > b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml index > > ce3e18b50230..93f5221e9381 100644 > > --- a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml > > +++ b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml > > > > @@ -86,7 +86,7 @@ properties: > > $ref: /schemas/types.yaml#/definitions/phandle > > > > description: > > The phandle of the cru. > > > > - Required if neither trcm-sync-tx-only nor trcm-sync-rx-only are > > specified. + Required if either trcm-sync-tx-only or > > trcm-sync-rx-only are specified.> > > rockchip,grf: > > $ref: /schemas/types.yaml#/definitions/phandle > > > > @@ -147,8 +147,13 @@ required: > > allOf: > > - if: > > properties: > > - rockchip,trcm-sync-tx-only: false > > - rockchip,trcm-sync-rx-only: false > > + rockchip,trcm-sync-tx-only: true > > + then: > > + required: > > + - rockchip,cru > > + - if: > > + properties: > > + rockchip,trcm-sync-rx-only: true > > FWIW, isn't this just a long-winded way to say > > if: > anyOf: > - properties: > rockchip,trcm-sync-tx-only: true > - properties: > rockchip,trcm-sync-rx-only: true > > which itself could still be more concisely > > if: > not: > properties: > rockchip,trcm-sync-tx-only: false > rockchip,trcm-sync-rx-only: false > > ? Hi Robin, you are absolutely correct. I'm not very familiar with dtschema yet, so I mostly just did what I know would work, as I didn't know about "not" or "anyOf" in this context. However I don't think this patch is going to get a V2 because I may have found a way to easily get rid of the CRU property altogether, making this patch sort of obsolete in the very near future. Thank you for your review nonetheless, I learned some more dtschema today thanks to it. :) > > Robin. > > > then: > > required: > > - rockchip,cru Regards, Nicolas Frattaroli _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5995BC433EF for ; Fri, 15 Oct 2021 21:34:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 242AD60EE2 for ; Fri, 15 Oct 2021 21:34:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 242AD60EE2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9LCSDzTK3ImBfauDDwc8Jm7Fv8hR17sc2MjbJRs6Qbs=; b=hIPgSBxNPC3zYr 9U24RutDJRHg27kokJViptlCCp63/UpilpUdjoBCt3Sq/Neira2l2EkBfMP5jujjxP091r+KRlqPO wuYRZLSHQ1ZEBDsWzbRW4yduebtI35DD8DdGjKQuGppQFgynpcr1YlzwLv8XZsajMwuYFRuIbGKO8 bw4eXQTHaeesKfGCe7dOQZZwgmoXuLjUgpKHkq7xOTg62hffo6kXZUAIC4pKltf737oXueI7P03+9 KQnkEmC4Zwx5E82WMiX6ZtLuDzdpxgVfIgHUoxUKZRXaeUKoUggjw1DJtZF9vlifS2e8euGO3utH2 c6k49QBmxpqJMZ7tN4fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbUpm-008pRM-Vn; Fri, 15 Oct 2021 21:33:47 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbUpi-008pOp-6x; Fri, 15 Oct 2021 21:33:43 +0000 Received: by mail-lf1-x130.google.com with SMTP id x27so47346335lfu.5; Fri, 15 Oct 2021 14:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gix2t0OaFc3liLwqh7FD+UgpYjMWRC2yF5wlNLCRBI8=; b=qis8HY5aJowC4EqJFx3MOPhEGhcXjXhZTpVf0O0ZaJ8dAFgGw91o/hVODkU7FRxcw6 AZU8vc1BfB4zTjM1P62wns5tOI3qN2C+s4pQ1Wsy7bv7gKL7jKc2hWKLs86XVr4W4TUT h5GijvI+PE96P1JI/y2GSZq49aFy6a6+/4SPzO/ECa11w6Y/Kv6VmU9qceSy5gDjzk8o pnepTbIkXzhYSl8fZ83W2Z3QQXtAUBpmlgoDMhpCXuKK0p9NHv69rY9hNa2BbT6Eg8it MsEqAMGICMa6VJqyKAXdLuPQ4xTTE1dI1LqDGKMGRp/pg/8J7tVBDb3taihP7FUws+6E ilHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gix2t0OaFc3liLwqh7FD+UgpYjMWRC2yF5wlNLCRBI8=; b=vUmvW0HWK/RQcPAOPBYmM/tbFOdDBFtMSox18snhPr51aq/C4H8bqPf4nXf1GhbI2C GhaL5TZjJ6FHS9bFwfnnjSv+hESWBV82dtxYDGph59cROlTlfwsiRw9WNkihg6NBSP6+ EXYcLr0Ht09p86nNAtQea+kce4ztNsCDqx+OT4C2FBGV2tCMxHJG5G+JqwT+FZt7u6V4 pi3zLsgZrDWDDAb9GidvPhrKcDdinlieP9I2tvdZGDuTwo3Fw+E78isq9wJjuKEozP9w A4BVSYSTsaYK61RrawL0NQIAbhal5uOtjXDoStj57iAbVqDyplaDv12WvOp8rJVYSQzV TJew== X-Gm-Message-State: AOAM5312e8nlPSayrszN9AHcuBK7gGm1LUOPUwXPLbXnlkvC9I0s7u3A WRhTQ+Y69pbNTC/DhM8VbVY= X-Google-Smtp-Source: ABdhPJyGE7Et43k/hdPxjdpBoYE8kfL5iTjenGOdjS4PvWxGzZHpGXrxlrYYk3a+u1/JkqbbVxvBCQ== X-Received: by 2002:a05:6512:3b94:: with SMTP id g20mr13375031lfv.77.1634333616241; Fri, 15 Oct 2021 14:33:36 -0700 (PDT) Received: from archbook.localnet (84-72-105-84.dclient.hispeed.ch. [84.72.105.84]) by smtp.gmail.com with ESMTPSA id f23sm689425ljn.110.2021.10.15.14.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 14:33:35 -0700 (PDT) From: Nicolas Frattaroli To: Liam Girdwood , Mark Brown , Rob Herring , Heiko Stuebner , Robin Murphy Cc: Rob Herring , linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: dt-bindings: rockchip: i2s-tdm: fix rockchip, cru requirement Date: Fri, 15 Oct 2021 23:33:34 +0200 Message-ID: <2236749.301RoY5kYM@archbook> In-Reply-To: <8553b0cd-95e4-c3db-c75a-d3b28e99f131@arm.com> References: <20211015143115.1445707-1-frattaroli.nicolas@gmail.com> <8553b0cd-95e4-c3db-c75a-d3b28e99f131@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211015_143342_312393_DDDDA24F X-CRM114-Status: GOOD ( 24.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Freitag, 15. Oktober 2021 19:44:56 CEST Robin Murphy wrote: > On 2021-10-15 15:31, Nicolas Frattaroli wrote: > > The behaviour described in the bindings is exactly the opposite > > of what it should be, so this patch fixes the description and > > adjusts the if conditions for adding rockchip,cru to required. > > > > Fixes: 510f1c133aed ("ASoC: dt-bindings: rockchip: add i2s-tdm bindings") > > Signed-off-by: Nicolas Frattaroli > > --- > > > > .../devicetree/bindings/sound/rockchip,i2s-tdm.yaml | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml > > b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml index > > ce3e18b50230..93f5221e9381 100644 > > --- a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml > > +++ b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml > > > > @@ -86,7 +86,7 @@ properties: > > $ref: /schemas/types.yaml#/definitions/phandle > > > > description: > > The phandle of the cru. > > > > - Required if neither trcm-sync-tx-only nor trcm-sync-rx-only are > > specified. + Required if either trcm-sync-tx-only or > > trcm-sync-rx-only are specified.> > > rockchip,grf: > > $ref: /schemas/types.yaml#/definitions/phandle > > > > @@ -147,8 +147,13 @@ required: > > allOf: > > - if: > > properties: > > - rockchip,trcm-sync-tx-only: false > > - rockchip,trcm-sync-rx-only: false > > + rockchip,trcm-sync-tx-only: true > > + then: > > + required: > > + - rockchip,cru > > + - if: > > + properties: > > + rockchip,trcm-sync-rx-only: true > > FWIW, isn't this just a long-winded way to say > > if: > anyOf: > - properties: > rockchip,trcm-sync-tx-only: true > - properties: > rockchip,trcm-sync-rx-only: true > > which itself could still be more concisely > > if: > not: > properties: > rockchip,trcm-sync-tx-only: false > rockchip,trcm-sync-rx-only: false > > ? Hi Robin, you are absolutely correct. I'm not very familiar with dtschema yet, so I mostly just did what I know would work, as I didn't know about "not" or "anyOf" in this context. However I don't think this patch is going to get a V2 because I may have found a way to easily get rid of the CRU property altogether, making this patch sort of obsolete in the very near future. Thank you for your review nonetheless, I learned some more dtschema today thanks to it. :) > > Robin. > > > then: > > required: > > - rockchip,cru Regards, Nicolas Frattaroli _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A393C433EF for ; Fri, 15 Oct 2021 21:33:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C2AD60EE2 for ; Fri, 15 Oct 2021 21:33:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243100AbhJOVfp (ORCPT ); Fri, 15 Oct 2021 17:35:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243079AbhJOVfo (ORCPT ); Fri, 15 Oct 2021 17:35:44 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8047C061570; Fri, 15 Oct 2021 14:33:37 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id x192so12039906lff.12; Fri, 15 Oct 2021 14:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gix2t0OaFc3liLwqh7FD+UgpYjMWRC2yF5wlNLCRBI8=; b=qis8HY5aJowC4EqJFx3MOPhEGhcXjXhZTpVf0O0ZaJ8dAFgGw91o/hVODkU7FRxcw6 AZU8vc1BfB4zTjM1P62wns5tOI3qN2C+s4pQ1Wsy7bv7gKL7jKc2hWKLs86XVr4W4TUT h5GijvI+PE96P1JI/y2GSZq49aFy6a6+/4SPzO/ECa11w6Y/Kv6VmU9qceSy5gDjzk8o pnepTbIkXzhYSl8fZ83W2Z3QQXtAUBpmlgoDMhpCXuKK0p9NHv69rY9hNa2BbT6Eg8it MsEqAMGICMa6VJqyKAXdLuPQ4xTTE1dI1LqDGKMGRp/pg/8J7tVBDb3taihP7FUws+6E ilHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gix2t0OaFc3liLwqh7FD+UgpYjMWRC2yF5wlNLCRBI8=; b=3bO+DnadSFUCh8FtN9H91OaFfk+VMU3Ap1To/C3KizwrW+nGuQ9wklarWQvNyC077W 4mDYGhrdgiTEe28Z/yTTIWqoChDEcThErh074cf2XeLF4eZxVekX9uwfec+m1EjdKzTS ROZ6Ybz8M/vxiN5IEVaLhS8oBRS4Qzgkr25O1puhZk4JWh+y/IXHobotHwsnLvlvvrZZ ORwpcZvVjF1Fv5GAxCRt8SgrKEbC3hwCEI8YNm3Bd5kbqyNLQ1XimEeiqpFzmbQYkjaq Xj04wxshPm0Sb5AP1/HJD9FEJvqUqWrVHUuFbFeeoVABJziyJ1ZxtVeXf5xBrTqaD0lR Dr1Q== X-Gm-Message-State: AOAM530TUhXLK1jrZONlk/PYy0jAs4z4rBN8LpZB5XfDvqFDBSWtv41r um/co+J+UOzcv6jK6ZuI33Q= X-Google-Smtp-Source: ABdhPJyGE7Et43k/hdPxjdpBoYE8kfL5iTjenGOdjS4PvWxGzZHpGXrxlrYYk3a+u1/JkqbbVxvBCQ== X-Received: by 2002:a05:6512:3b94:: with SMTP id g20mr13375031lfv.77.1634333616241; Fri, 15 Oct 2021 14:33:36 -0700 (PDT) Received: from archbook.localnet (84-72-105-84.dclient.hispeed.ch. [84.72.105.84]) by smtp.gmail.com with ESMTPSA id f23sm689425ljn.110.2021.10.15.14.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 14:33:35 -0700 (PDT) From: Nicolas Frattaroli To: Liam Girdwood , Mark Brown , Rob Herring , Heiko Stuebner , Robin Murphy Cc: Rob Herring , linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: dt-bindings: rockchip: i2s-tdm: fix rockchip, cru requirement Date: Fri, 15 Oct 2021 23:33:34 +0200 Message-ID: <2236749.301RoY5kYM@archbook> In-Reply-To: <8553b0cd-95e4-c3db-c75a-d3b28e99f131@arm.com> References: <20211015143115.1445707-1-frattaroli.nicolas@gmail.com> <8553b0cd-95e4-c3db-c75a-d3b28e99f131@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Freitag, 15. Oktober 2021 19:44:56 CEST Robin Murphy wrote: > On 2021-10-15 15:31, Nicolas Frattaroli wrote: > > The behaviour described in the bindings is exactly the opposite > > of what it should be, so this patch fixes the description and > > adjusts the if conditions for adding rockchip,cru to required. > > > > Fixes: 510f1c133aed ("ASoC: dt-bindings: rockchip: add i2s-tdm bindings") > > Signed-off-by: Nicolas Frattaroli > > --- > > > > .../devicetree/bindings/sound/rockchip,i2s-tdm.yaml | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml > > b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml index > > ce3e18b50230..93f5221e9381 100644 > > --- a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml > > +++ b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml > > > > @@ -86,7 +86,7 @@ properties: > > $ref: /schemas/types.yaml#/definitions/phandle > > > > description: > > The phandle of the cru. > > > > - Required if neither trcm-sync-tx-only nor trcm-sync-rx-only are > > specified. + Required if either trcm-sync-tx-only or > > trcm-sync-rx-only are specified.> > > rockchip,grf: > > $ref: /schemas/types.yaml#/definitions/phandle > > > > @@ -147,8 +147,13 @@ required: > > allOf: > > - if: > > properties: > > - rockchip,trcm-sync-tx-only: false > > - rockchip,trcm-sync-rx-only: false > > + rockchip,trcm-sync-tx-only: true > > + then: > > + required: > > + - rockchip,cru > > + - if: > > + properties: > > + rockchip,trcm-sync-rx-only: true > > FWIW, isn't this just a long-winded way to say > > if: > anyOf: > - properties: > rockchip,trcm-sync-tx-only: true > - properties: > rockchip,trcm-sync-rx-only: true > > which itself could still be more concisely > > if: > not: > properties: > rockchip,trcm-sync-tx-only: false > rockchip,trcm-sync-rx-only: false > > ? Hi Robin, you are absolutely correct. I'm not very familiar with dtschema yet, so I mostly just did what I know would work, as I didn't know about "not" or "anyOf" in this context. However I don't think this patch is going to get a V2 because I may have found a way to easily get rid of the CRU property altogether, making this patch sort of obsolete in the very near future. Thank you for your review nonetheless, I learned some more dtschema today thanks to it. :) > > Robin. > > > then: > > required: > > - rockchip,cru Regards, Nicolas Frattaroli