From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] drm/cma: remove to allocate shmfs backing store
Date: Thu, 28 Aug 2014 14:30:59 +0200
Message-ID: <22378574.9TNJn11Yi2@avalon>
References: <1409120792-423-1-git-send-email-jy0922.shim@samsung.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from galahad.ideasonboard.com (galahad.ideasonboard.com
 [185.26.127.97])
 by gabe.freedesktop.org (Postfix) with ESMTP id 8221F6E040
 for <dri-devel@lists.freedesktop.org>; Thu, 28 Aug 2014 05:30:09 -0700 (PDT)
In-Reply-To: <1409120792-423-1-git-send-email-jy0922.shim@samsung.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Hi Joonyoung,

Thank you for the patch.

On Wednesday 27 August 2014 15:26:32 Joonyoung Shim wrote:
> Initialize GEM object using drm_gem_private_object_init instead of
> drm_gem_object_init. It doesn't need to have shmfs backing store because
> the CMA GEM object uses CMA area.
> 
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/drm_gem_cma_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c
> b/drivers/gpu/drm/drm_gem_cma_helper.c index e467e67..a65cbd0 100644
> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
> @@ -52,7 +52,7 @@ __drm_gem_cma_create(struct drm_device *drm, unsigned int
> size)
> 
>  	gem_obj = &cma_obj->base;
> 
> -	ret = drm_gem_object_init(drm, gem_obj, size);
> +	ret = drm_gem_private_object_init(drm, gem_obj, size);
>  	if (ret)
>  		goto error;

-- 
Regards,

Laurent Pinchart