From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0176CDB465 for ; Thu, 19 Oct 2023 11:35:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235229AbjJSLfo (ORCPT ); Thu, 19 Oct 2023 07:35:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233155AbjJSLfo (ORCPT ); Thu, 19 Oct 2023 07:35:44 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8D0EBE; Thu, 19 Oct 2023 04:35:39 -0700 (PDT) Received: from i5e861907.versanet.de ([94.134.25.7] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qtRJM-0003Gm-Q2; Thu, 19 Oct 2023 13:35:32 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Chris Morgan , linux-rockchip@lists.infradead.org, Krzysztof Kozlowski Cc: linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, sebastian.reichel@collabora.com, sboyd@kernel.org, mturquette@baylibre.com, daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, neil.armstrong@linaro.org, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, Chris Morgan Subject: Re: [PATCH 4/5] dt-bindings: arm: rockchip: Add Powkiddy RK2023 Date: Thu, 19 Oct 2023 13:35:31 +0200 Message-ID: <2239084.Dhsi8hcfAM@diego> In-Reply-To: References: <20231018161848.346947-1-macroalpha82@gmail.com> <20231018161848.346947-5-macroalpha82@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Am Donnerstag, 19. Oktober 2023, 11:21:47 CEST schrieb Krzysztof Kozlowski: > On 18/10/2023 18:18, Chris Morgan wrote: > > From: Chris Morgan > > > > The Powkiddy RK2023 is a handheld gaming device made by Powkiddy and > > powered by the Rockchip RK3566 SoC. > > > > Signed-off-by: Chris Morgan > > --- > > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > index a349bf4da6bc..a6612185a7ff 100644 > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > @@ -674,6 +674,11 @@ properties: > > - const: powkiddy,rgb30 > > - const: rockchip,rk3566 > > > > + - description: Powkiddy RK2023 > > + items: > > + - const: powkiddy,rk2023 > > This cuold be just enum in previous entry :/ but I remember we talked > about this once with Heiko. Keeping similar devices together is perfectly fine. Like we do for example with the Rock PI 4A/4A+/B/B+/C family directly below. The powkiddy,rk2023 really looks like very similar to the rgb30, so could do something similar. The variant I don't like is having one big enum for _all_ boards using the same soc. Heiko > Acked-by: Krzysztof Kozlowski > > > + - const: rockchip,rk3566 > > > > Best regards, > Krzysztof > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED2E9CDB483 for ; Thu, 19 Oct 2023 11:35:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RggLvKhDBdEwoCayiFhMXI9lrwtzhD/YULKGwjJt3qo=; b=pgkc0eycvxH1JG xewBmZSoAz33fpxGaoUppt8q0ODA/R1TRO8ygfAkWQXZLHcM2Nzt6HlVpUGvtHYmzWG4jLp/pgyu6 tR5l5YCSjmSgpgZvC+BUVQUpEeW+e3RoFukf+ASDeekm31TGNG7M1yt2QUuzqRReqZgzQa729wxx8 GhKuytXszQp8jJB0obOLo4oKoCfhZG1eRscbpVgAU0WA5iV0JCuX4rWZgUWy9yWsqEMXUOr1bfiv+ sSUX9+rznZJpV+KrRRMc8lbXLHc9iDgHw4JwqoQWZmMqnwWA50I7/ekE3PSS8KenEm9pHuCYq4bOA Nc9rk1U/xI3OWJv6Dsrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtRJS-00HBBg-2P; Thu, 19 Oct 2023 11:35:38 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtRJQ-00HBAx-2P for linux-rockchip@lists.infradead.org; Thu, 19 Oct 2023 11:35:37 +0000 Received: from i5e861907.versanet.de ([94.134.25.7] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qtRJM-0003Gm-Q2; Thu, 19 Oct 2023 13:35:32 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Chris Morgan , linux-rockchip@lists.infradead.org, Krzysztof Kozlowski Cc: linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, sebastian.reichel@collabora.com, sboyd@kernel.org, mturquette@baylibre.com, daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, neil.armstrong@linaro.org, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, Chris Morgan Subject: Re: [PATCH 4/5] dt-bindings: arm: rockchip: Add Powkiddy RK2023 Date: Thu, 19 Oct 2023 13:35:31 +0200 Message-ID: <2239084.Dhsi8hcfAM@diego> In-Reply-To: References: <20231018161848.346947-1-macroalpha82@gmail.com> <20231018161848.346947-5-macroalpha82@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231019_043536_784159_5F5BB5C6 X-CRM114-Status: GOOD ( 19.38 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Am Donnerstag, 19. Oktober 2023, 11:21:47 CEST schrieb Krzysztof Kozlowski: > On 18/10/2023 18:18, Chris Morgan wrote: > > From: Chris Morgan > > > > The Powkiddy RK2023 is a handheld gaming device made by Powkiddy and > > powered by the Rockchip RK3566 SoC. > > > > Signed-off-by: Chris Morgan > > --- > > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > index a349bf4da6bc..a6612185a7ff 100644 > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > @@ -674,6 +674,11 @@ properties: > > - const: powkiddy,rgb30 > > - const: rockchip,rk3566 > > > > + - description: Powkiddy RK2023 > > + items: > > + - const: powkiddy,rk2023 > > This cuold be just enum in previous entry :/ but I remember we talked > about this once with Heiko. Keeping similar devices together is perfectly fine. Like we do for example with the Rock PI 4A/4A+/B/B+/C family directly below. The powkiddy,rk2023 really looks like very similar to the rgb30, so could do something similar. The variant I don't like is having one big enum for _all_ boards using the same soc. Heiko > Acked-by: Krzysztof Kozlowski > > > + - const: rockchip,rk3566 > > > > Best regards, > Krzysztof > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05960CDB465 for ; Thu, 19 Oct 2023 11:35:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 48AED10E098; Thu, 19 Oct 2023 11:35:38 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 16D5B10E098 for ; Thu, 19 Oct 2023 11:35:36 +0000 (UTC) Received: from i5e861907.versanet.de ([94.134.25.7] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qtRJM-0003Gm-Q2; Thu, 19 Oct 2023 13:35:32 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Chris Morgan , linux-rockchip@lists.infradead.org, Krzysztof Kozlowski Subject: Re: [PATCH 4/5] dt-bindings: arm: rockchip: Add Powkiddy RK2023 Date: Thu, 19 Oct 2023 13:35:31 +0200 Message-ID: <2239084.Dhsi8hcfAM@diego> In-Reply-To: References: <20231018161848.346947-1-macroalpha82@gmail.com> <20231018161848.346947-5-macroalpha82@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, neil.armstrong@linaro.org, sboyd@kernel.org, sam@ravnborg.org, mturquette@baylibre.com, Chris Morgan , sebastian.reichel@collabora.com, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, linux-clk@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am Donnerstag, 19. Oktober 2023, 11:21:47 CEST schrieb Krzysztof Kozlowski: > On 18/10/2023 18:18, Chris Morgan wrote: > > From: Chris Morgan > > > > The Powkiddy RK2023 is a handheld gaming device made by Powkiddy and > > powered by the Rockchip RK3566 SoC. > > > > Signed-off-by: Chris Morgan > > --- > > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > index a349bf4da6bc..a6612185a7ff 100644 > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > @@ -674,6 +674,11 @@ properties: > > - const: powkiddy,rgb30 > > - const: rockchip,rk3566 > > > > + - description: Powkiddy RK2023 > > + items: > > + - const: powkiddy,rk2023 > > This cuold be just enum in previous entry :/ but I remember we talked > about this once with Heiko. Keeping similar devices together is perfectly fine. Like we do for example with the Rock PI 4A/4A+/B/B+/C family directly below. The powkiddy,rk2023 really looks like very similar to the rgb30, so could do something similar. The variant I don't like is having one big enum for _all_ boards using the same soc. Heiko > Acked-by: Krzysztof Kozlowski > > > + - const: rockchip,rk3566 > > > > Best regards, > Krzysztof > >