From: Heiner Kallweit <hkallweit1@gmail.com>
To: Peter Tyser <ptyser@xes-inc.com>, Lee Jones <lee.jones@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] mfd: lpc_ich: convert name to const char*
Date: Thu, 2 Dec 2021 10:42:51 +0100 [thread overview]
Message-ID: <223bc330-5be1-136b-7b42-e4bc1331d28f@gmail.com> (raw)
This change reduces the memory footprint of the structs (admittedly
not much), and it allows the compiler to store names only once.
E.g. i2c-i801 uses name "Intel PCH" twice. All users assign static
strings to name, and only usage of name is in iTCO_wdt_probe() for
printing a syslog info message. So we don't really have to worry
about potential issues like use after free.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/mfd/lpc_ich.c | 2 +-
include/linux/mfd/lpc_ich.h | 2 +-
include/linux/platform_data/itco_wdt.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index f10e53187..acb33a180 100644
--- a/drivers/mfd/lpc_ich.c
+++ b/drivers/mfd/lpc_ich.c
@@ -889,7 +889,7 @@ static int lpc_ich_finalize_wdt_cell(struct pci_dev *dev)
info = &lpc_chipset_info[priv->chipset];
pdata->version = info->iTCO_version;
- strlcpy(pdata->name, info->name, sizeof(pdata->name));
+ pdata->name = info->name;
cell->platform_data = pdata;
cell->pdata_size = sizeof(*pdata);
diff --git a/include/linux/mfd/lpc_ich.h b/include/linux/mfd/lpc_ich.h
index 39967a5ec..6dec7d992 100644
--- a/include/linux/mfd/lpc_ich.h
+++ b/include/linux/mfd/lpc_ich.h
@@ -27,7 +27,7 @@ enum {
};
struct lpc_ich_info {
- char name[32];
+ const char *name;
unsigned int iTCO_version;
unsigned int gpio_version;
enum intel_spi_type spi_type;
diff --git a/include/linux/platform_data/itco_wdt.h b/include/linux/platform_data/itco_wdt.h
index 45d860cac..c6941c089 100644
--- a/include/linux/platform_data/itco_wdt.h
+++ b/include/linux/platform_data/itco_wdt.h
@@ -19,7 +19,7 @@
* @no_reboot_use_pmc: Use PMC BXT API to set and clear NO_REBOOT bit
*/
struct itco_wdt_platform_data {
- char name[32];
+ const char *name;
unsigned int version;
bool no_reboot_use_pmc;
};
--
2.34.1
next reply other threads:[~2021-12-02 9:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 9:42 Heiner Kallweit [this message]
2021-12-29 13:16 ` [PATCH] mfd: lpc_ich: convert name to const char* Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=223bc330-5be1-136b-7b42-e4bc1331d28f@gmail.com \
--to=hkallweit1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ptyser@xes-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.